Re: 'g' in the group buffer still very slow

[Martin Rohde <martin.rohde@gmx.de>]

On Day 55 of The Aftermath 3168, Kai Großjohann wrote:

> Martin Rohde <martin.rohde@gmx.de> writes:
>
>> On Day 54 of The Aftermath 3168, Kai Großjohann wrote:
>>
>>> You can put the definition in the server parameters, like this:
>>>
>>> (add-to-list 'gnus-secondary-select-methods
>>>              '(nntp "servername"
>>>                (nntp-address "host.name.of.server")
>>>                (nntp-open-connection-function nntp-open-telnet-stream)
>>>                ...other.nntp-open-telnet.settings...))
>>
>> Oops. Sorry, then Kevin was right, nntp-delete-echo has to be
>> buffer-local.
>
> Yes.
>
>> I fixed the cleaning of the server-buffer after sending "MyNOOP"
>> like you suggested and it works, but I like the version of Kevin
>> very much. In my opinion it works just as well as testing for an
>> echo in nntp-open-connection, but saves code and time.
>
> Hm?  If the code is simpler, I'm all for it, but I don't see what time
> it saves.  Is it quicker to implement or easier to maintain, or does
> it run quicker?

Sorry, I mixed some things up.
All it saves is the sending of "MyNOOP". It is wrong to speak of
"saving time". 

It just saves the additional code in nntp-open-connection, that's
why I prefer it. But the other version works as well, so if you're
prefering your way, I can send you the working patch, too.

>> Hm, but it is right to refer to nntp-open-connection-function
>> globally, isn't it? It is connection-dependend, too, but I just
>> found it as a global variable...(That's why I thought, that it
>> would be independent...)
>
> Code referring to a buffer-local variable looks the same as code
> referring to a global variable.  See this:
>
> (defvar x nil)          ; declare
> (setq x 1)              ; global value
> ; switch to some buffer foo
> (make-local-variable 'x); now it will be local to the foo buffer
> x => 1                  ; local value same as global initially
> (setq x 2)              ; set the local value
> x => 2                  ; local value
> ; switch back to previous buffer
> x => 1                  ; access global value again
>
> As you can see, the setq looks the same and the access also looks the
> same.  The only difference is the make-local-variable.

Yes, but i couldn't see a 

(make-local-variable nntp-open-connection-function) 

anywhere. Furthermore, I am not in a special buffer, when I check it
(or am I?), so that's why I asked.

>> If so, here is yet another try:
>
> Looks good to me, even though I'm not so sure about the logic.
>
> First of all, you still test the connection function, is that still
> necessary?  If the look-for-echo test works well, it should be okay to
> apply it always, making the code (a tiny bit) simpler.

I thought, it would make the start of gnus a bit faster when you are
using nntp-open-network-stream, because otherwise you would still
have the delay from nntp-accept-response when nntp-send-command is
called for the first time.

> Secondly, and this is the logic part, the check-for-echo variable
> starts out as nil.  I didn't look very closely, but I thought that the
> echo check is skipped when the variable is nil...

Its global value is nil, but in nntp-make-process-buffer it is
initialized as

(set (make-local-variable 'nntp-process-delete-echo) t)

The (defvar nntp-process-delete-echo nil) ist just a dummy
declaration (because of "free variable"-warnings). For it has to be
checked locally in the server-buffers, it doesn't matter, what its
global value is, as you explained before. 

Martin