Gnus development mailing list
 help / color / mirror / Atom feed
From: TSUCHIYA Masatoshi <tsuchiya@namazu.org>
Subject: Continuation lines for persistent articles
Date: Sun, 13 Oct 2002 14:47:30 +0900	[thread overview]
Message-ID: <87d6qelwjx.fsf@pine.kuee.kyoto-u.ac.jp> (raw)

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hello, Gnus developers.

I found the bug that continuation lines are not treated for persistent
articles.  For example, when an article whose subject consists of
continuation lines is entered to cache, its subject is truncated to
the first new-line.  So, I propose the following change.

2002-10-13  TSUCHIYA Masatoshi  <tsuchiya@namazu.org>

	* gnus-cache.el (gnus-cache-possibly-enter-article): Fold
	continuation lines and turn TAB into SPC before parsing.


[-- Attachment #2: Type: text/plain, Size: 577 bytes --]

--- gnus-cache.el.orig	2002-08-05 16:30:26.000000000 +0900
+++ gnus-cache.el	2002-10-13 14:21:41.000000000 +0900
@@ -179,6 +179,11 @@
 	    (when (> (buffer-size) 0)
 	      (let ((coding-system-for-write gnus-cache-coding-system))
 		(gnus-write-buffer file))
+	      (save-restriction
+		(nnheader-narrow-to-headers)
+		(nnheader-ms-strip-cr)
+		(nnheader-fold-continuation-lines)
+		(subst-char-in-region (point-min) (point-max) ?\t ? ))
 	      (setq headers (nnheader-parse-head t))
 	      (mail-header-set-number headers number)
 	      (gnus-cache-change-buffer group)

[-- Attachment #3: Type: text/plain, Size: 229 bytes --]


I am worry that all functions which call nnheader-parse-head() must
fold continuation lines before calling it.  If this observation is
right, a better approach would make nnheader-parse-head() fold them.

-- 
TSUCHIYA Masatoshi

             reply	other threads:[~2002-10-13  5:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-13  5:47 TSUCHIYA Masatoshi [this message]
2002-10-13 17:27 ` Kai Großjohann
2002-10-17 13:19   ` TSUCHIYA Masatoshi
2002-10-17 13:32   ` TSUCHIYA Masatoshi
2002-10-17 15:09     ` Katsumi Yamaoka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d6qelwjx.fsf@pine.kuee.kyoto-u.ac.jp \
    --to=tsuchiya@namazu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).