Re: The Gnus logo in the modeline is displayed with a non-transparent background

[asjo@koldfront.dk (Adam Sjøgren)]

Eric writes:

> Huh, now that you mention it, I see all the images are too small on my
> (hdpi) monitor, too. Oh well, at least they're transparent!

The only place the advice don't work is in the modeline, for me :-)

> I wonder if you could play with that `find-image' advice and make it
> work. Isn't 'imagemagick an odd :type for the image found?

I think that is the type you use when you want to be able to scale the
image...

> I wonder if that's necessary to make the re-scaling work correctly.
> What happens if you hard-code it to 'xpm, just for this case?

Good question, I can see that
/usr/src/emacs/etc/images/gnus/gnus-pointer.xpm is the file loaded.
Maybe I should just try skipping the advice for that file.

 find-image image before: (image :type xpm :file /usr/src/emacs/etc/images/gnus/gnus-pointer.xpm :ascent center)
 find-image spec after:         (:type imagemagick :file /usr/src/emacs/etc/images/gnus/gnus-pointer.xpm :ascent center :width 27 :height 20)

Modifying the advice thus gives the expected result:

  (defadvice find-image (after scale-image-size activate)
    "Scale the image size."
    (condition-case nil
        (let* ((magnitude (frame-parameter nil 'image-dpi-scale-magnitude))
               (image (copy-sequence ad-return-value))
               (size (image-size image t))
               (spec (cdr image))
               (image-width (or (plist-get spec :width) (car size)))
               (image-height (or (plist-get spec :height) (cdr size))))
          (when (not (string= (plist-get spec :type) "xpm")) ; skip xpm files, such as emacs/etc/images/gnus/gnus-pointer.xpm
            (plist-put spec :width (round (* image-width magnitude)))
            (plist-put spec :height (round (* image-height magnitude)))
            (plist-put spec :type 'imagemagick))
          (setq ad-return-value image))
      (error nil)))


  Best regards,

    Adam

-- 
 "Vi sitter i samma bil                                       Adam Sjøgren
  En silvergrå missil                                    asjo@koldfront.dk
  En bomb i motsatt fil
  Vi sitter i samma bil"