Gnus development mailing list
 help / color / mirror / Atom feed
From: Christopher Schmidt <christopher@ch.ristopher.com>
To: ding@gnus.org
Subject: gnus-configure-posting-styles: Use with-silent-modifications
Date: Mon, 17 Dec 2012 19:59:01 +0000 (GMT)	[thread overview]
Message-ID: <87ehioa1ro@ch.ristopher.com> (raw)

Right at the end of gnus-configure-posting-styles there is this form:

    (when (or name address)
      (add-hook 'message-setup-hook
                `(lambda ()
                   (set (make-local-variable 'user-mail-address)
                        ,(or (cdr address) user-mail-address))
                   (let ((user-full-name ,(or (cdr name) (user-full-name)))
                         (user-mail-address
                          ,(or (cdr address) user-mail-address)))
                     (save-excursion
                       (message-remove-header "From")
                       (message-goto-eoh)
                       (insert "From: " (message-make-from) "\n"))))
                nil 'local))

When the hook is run, the message buffer will be modified and undo
information will be stored in buffer-undo-list.  That does not feel
right.  I think the body forms of this save-excursion should be embedded
in a with-silent-modifications.

        Christopher



             reply	other threads:[~2012-12-17 19:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-17 19:59 Christopher Schmidt [this message]
2012-12-25 11:43 ` Lars Ingebrigtsen
2013-01-29 17:49   ` Christopher Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ehioa1ro@ch.ristopher.com \
    --to=christopher@ch.ristopher.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).