Re: Attach file improvement

[Hobbit <werehobbit@yandex.ru>]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> This patch is more than 10 lines long, so we'll need FSF copyright
> assignment papers.  Do you have assignment papers on file with the
> FSF?

Well, if you compare my patch with the original file mml.el you'd see
that it mostly consists of mere copy of old Gnus code:

For example, fragments from mml.el:

;; mml.el line #1197
(defun mml-minibuffer-read-disposition (type &optional default filename)
  (unless default
    (setq default (mml-content-disposition type filename)))
  (let ((disposition (completing-read                      ;; <-- look
		      (format "Disposition (default %s): " default)
		      '(("attachment") ("inline") (""))
		      nil t nil nil default)))
    (if (not (equal disposition ""))
	disposition
      default)))

;;mml.el line #1280
(defun mml-attach-file (file &optional type description disposition)

;;mml.el line #1296
     (list file type description disposition)))

;; mml.el line #491
(if (and (not raw)
      (member (car (split-string type "/")) '("text" "message")))

And this is the patch:

+(defun mml-minibuffer-read-charset (&optional default);; copy&rename
+  (let ((charset (completing-read     ;;<----- variable renamed
+      (format "Charset: " default)    ;; <-- prompt changed
+                  mm-mime-mule-charset-alist
+                  nil t nil nil default))) ;; just copied
+    (if (not (equal charset ""))           ;; just copied
+        charset                            ;; just copied
+      default)))                           ;; just copied


+(defun mml-attach-file (file &optional type description ;; copied
+                             disposition charset);; <- param added

+body) or \"attachment\" (separate from the body). CHARSET is file
+charset."                          

+      (charset (when (member (car (split-string type "/"))
+                             '("text" "message")) ;; partial copy
+                 (mml-minibuffer-read-charset)));; from line #491


+  (list file type description disposition charset)));; var added
+            'charset charset                        ;; var added

So my autorship is much smaller than it could seem. "Real" weight of
the patch is near 10 lines (if not less).

>> | C-c C-a
>> | Attach file: ~/file.txt
>> | Content type (default text/plain): <RET>
>> | Charset: cp855
>

> The other thing I don't quite understand is that Emacs is usually
> able to tell what the charset is automatically, so why does the user
> need to be prompted here?

Unfortunately, in the cyrillic world things are much more difficult,
because there are several popular charsets which use same codes for
different cyrillic letters.

For example, a file with contents (in hex codes)

0xCE, 0xC5, 0xD4

could be read using charset koi8-r as

CYRILLIC SMALL LETTER EN
CYRILLIC SMALL LETTER IE
CYRILLIC SMALL LETTER TE

whereas in charset windows-1251 it's

CYRILLIC CAPITAL LETTER O
CYRILLIC CAPITAL LETTER IE
CYRILLIC CAPITAL LETTER EF

So how could we know what charset to use without asking a user?