dysfunctional code in message-generate-headers

[Andreas Seltenreich <andreas+ding@gate450.dyndns.org>]

[-- Attachment #1: Type: text/plain, Size: 959 bytes --]

Hi,

there's some discussion in de.comm.software.gnus about an unintuitive
behavior of Message.  Currently, a "References" header that was
inserted on buffer creation and deleted by the user is inserted again
when the mail is being sent.  There's also an older bug report about
this: <news:87lkok9nnw.fsf@jidanni.org>.

Looking at the code, it seems that message-generate-headers already
has some provision to avoid repeated insertion.  However, the code
doesn't cause any effect at the moment, as it only puts /non-optional/
headers into message-inserted-headers, while the check to avoid
repeated insertion only applies to /optional/ ones.

This looks like a bug to me, and actually putting optional headers
into message-inserted-headers as in the attached patch results in the
behavior desired in the bug reports.

I'd like to propose this patch for No Gnus for now, since it
essentially enables an old feature for the first time.  WDYT?

regards,
andreas

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 448 bytes --]

*** message.el	15 Mar 2007 22:41:21 -0000	7.202
--- message.el	26 Mar 2007 00:37:08 -0000
***************
*** 5580,5585 ****
--- 5580,5586 ----
  		      (if formatter
  			  (funcall formatter header value)
  			(insert header-string ": " value))
+ 		      (push header-string message-inserted-headers)
  		      (goto-char (message-fill-field))
  		      ;; We check whether the value was ended by a
  		      ;; newline.  If not, we insert one.