From: Andrea Russo <rast4ndy@gmail.com>
Subject: [PATCH] Make message-insert-citation-line works with nnrss groups
Date: Thu, 14 Sep 2006 21:41:09 +0200 [thread overview]
Message-ID: <87ejuekzhm.fsf@onosendai.org> (raw)
Hi,
There is a bug in `message-insert-citation-line' that happens when
trying to reply to an article in a nnrss group.
Various blogging software doesn't set a `From' header in blog posts,
so when gnus tries to cite the author of the post, it hits a `Wrong
type argument' error.
This patch tries to fix this.
Best Regards,
Andrea Russo.
--- orig/lisp/gnus/ChangeLog
+++ mod/lisp/gnus/ChangeLog
@@ -1,3 +1,8 @@
+2006-09-14 Andrea Russo <rast4ndy@gmail.com>
+
+ * message.el (message-insert-citation-line): Check if the from header
+ is nil. This may happens in articles from nnrss groups.
+
--- orig/lisp/gnus/message.el
+++ mod/lisp/gnus/message.el
@@ -3346,9 +3346,11 @@
(defun message-insert-citation-line ()
"Insert a simple citation line."
(when message-reply-headers
- (insert (mail-header-from message-reply-headers) " writes:")
- (newline)
- (newline)))
+ (let ((from (mail-header-from message-reply-headers)))
+ (when from
+ (insert from " writes:"))
+ (newline)
+ (newline))))
(defun message-position-on-field (header &rest afters)
(let ((case-fold-search t))
next reply other threads:[~2006-09-14 19:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-14 19:41 Andrea Russo [this message]
2006-09-14 23:57 ` Katsumi Yamaoka
2006-09-16 6:52 ` Katsumi Yamaoka
2006-09-16 10:50 ` Andrea Russo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ejuekzhm.fsf@onosendai.org \
--to=rast4ndy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).