face renaming

face renaming

[Miles Bader]

I've just renamed a bunch of faces in the Emacs trunk to remove the
trailing "-face".  I've added face-aliases to the old names so they'll
more or less continue working.

I'd like to do the same thing in Gnus, but I'm not sure if this is OK
given the compatibility requirements of the 5.10 branch -- I think the
face-alias feature was first added in Emacs 21.1 (I no longer have a
copy of Emacs 20 around to check, and the ChangeLogs are a bit
ambiguous, but that seems right to me).

Any comment?

Thanks,

-Miles
-- 
"I distrust a research person who is always obviously busy on a task."
   --Robert Frosch, VP, GM Research

Re: face renaming

[Katsumi Yamaoka]

>>>>> In <buoll5c82dm.fsf@mctpc71.ucom.lsi.nec.co.jp>
>>>>>	Miles Bader <miles@lsi.nec.co.jp> wrote:

> I've just renamed a bunch of faces in the Emacs trunk to remove the
> trailing "-face".  I've added face-aliases to the old names so they'll
> more or less continue working.

> I'd like to do the same thing in Gnus, but I'm not sure if this is OK
> given the compatibility requirements of the 5.10 branch -- I think the
> face-alias feature was first added in Emacs 21.1 (I no longer have a
> copy of Emacs 20 around to check, and the ChangeLogs are a bit
> ambiguous, but that seems right to me).

> Any comment?

The face-alias feature is surely not available in Emacs 20.
However, I think it is not always necessary to offer the face
aliases because the default face attributions are not so bad.
Emacs 20 users who have customized faces will probably notice
the change, and deal with it by themselves.

Re: face renaming

[Miles Bader]

On 6/15/05, Katsumi Yamaoka <yamaoka@jpl.org> wrote:
> The face-alias feature is surely not available in Emacs 20.
> However, I think it is not always necessary to offer the face
> aliases because the default face attributions are not so bad.
> Emacs 20 users who have customized faces will probably notice
> the change, and deal with it by themselves.

Good point.

Unless somebody else objects, I'll go ahead and do this sometime in
the next few days.

Thanks,

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: face renaming

[Arne Jørgensen]

Katsumi Yamaoka <yamaoka@jpl.org> writes:

> Emacs 20 users who have customized faces will probably notice
> the change, and deal with it by themselves.

And Emacs 20 is only supported in the v5-10 branch and not in No Gnus.

Kind regards,
-- 
Arne Jørgensen <http://arnested.dk/>

Re: face renaming

[David S. Goldberg]

Will there be any negative effect on XEmacs users?
-- 
Dave Goldberg
david.goldberg6@verizon.net

Re: face renaming

[Katsumi Yamaoka]

>>>>> In <mj7u0jzv5kw.fsf@mm117419-pc.MITRE.ORG> 
>>>>>	david.goldberg6@verizon.net (David S. Goldberg) wrote:

> Will there be any negative effect on XEmacs users?

Oh, the face aliases won't work with not only Emacs 20 but also
XEmacs.  I think it's not a matter for the same reason, though.
The way to make the face alias is as follows:

(defface gnus-article-button ...)
(put 'gnus-article-button-face 'face-alias 'gnus-article-button)

Re: face renaming

[Miles Bader]

Ok, it's done.  Switch mode to "complain".

I use gnus 5.10, so I didn't test my merge into the trunk, but I think
the two branches are pretty much the same in this area (I looked for
extra faces in the trunk, but only found one)...

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: face renaming

[Didier Verna]

Miles Bader <miles@lsi.nec.co.jp> wrote:

> Ok, it's done.  Switch mode to "complain".

        Here's one :-) Gnus doesn't start anymore on XEmacs.


Debugger entered--Lisp error: (error "No such face" gnus-group-news-1-empty-face)
  put-text-property(1 64 face gnus-group-news-1-empty-face nil)
  gnus-put-text-property-excluding-characters-with-faces(1 79 face gnus-group-news-1-empty-face)
  gnus-group-highlight-line()
  run-hooks(gnus-group-highlight-line)
  apply(run-hooks gnus-group-highlight-line)
  gnus-run-hooks(gnus-group-update-hook)
  gnus-group-insert-group-line("nntp+lrde:lrde.c++" 1 ((expire (99 . 110) (112 . 115) 117 (122 . 134) (136 . 141) (147 . 149) (156 . 163) (165 . 202)) (reply 136 138 165 184 186 188 190 192 197) (tick 116 (118 . 121)) (seen (11 . 110) (112 . 151) (153 . 202))) 0 "nntp:lrde")
  gnus-topic-prepare-topic((("lrde" visible nil nil)) 2 5 nil nil 1 nil)
  gnus-topic-prepare-topic((("News" visible nil nil) (("Free" visible nil nil)) (("comp.emacs" visible nil nil)) (("comp.lang" visible nil nil)) (("comp.text" visible nil nil)) (("GNU" visible nil nil)) (("misc.misc" visible nil nil)) (("epita" visible nil nil)) (("lrde" visible nil nil)) (("mirrored lists" visible nil nil))) 1 5 nil nil 1 nil)
  gnus-topic-prepare-topic((("Top" visible nil nil) (("Mails" visible nil nil) (...) (...) (...) (...) (...) (...) (...) (...) (...)) (("News" visible nil nil) (...) (...) (...) (...) (...) (...) (...) (...) (...)) (("Test" invisible nil nil)) (("Styles" invisible nil nil)) (("Archive" invisible nil nil))) 0 5 nil nil 1 nil)
  gnus-group-prepare-topics(5 nil nil)
  gnus-group-list-groups(nil)
  byte-code("..." [gnus-slave gnus-current-startup-file gnus-startup-file did-connect level dont-connect gnus-group-quit gnus-run-hooks gnus-startup-hook gnus-make-newsrc-file gnus-dribble-read-file gnus-request-create-group "queue" (nndraft "") "drafts" (nndraft "") gnus-setup-news nil gnus-setup-news-hook gnus-start-draft-setup gnus-group-list-groups gnus-group-first-unread-group gnus-configure-windows group gnus-group-set-mode-line gnus-started-hook gnus-use-dribble-file gnus-agent] 4)
  gnus-1(nil nil nil)
  gnus(nil)



> I use gnus 5.10, so I didn't test my merge into the trunk, but I think the
> two branches are pretty much the same in this area (I looked for extra faces
> in the trunk, but only found one)...

        So, I've been away for a while. What are those different branches ?

--
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 53 14 59 22   didier@xemacs.org

Re: face renaming

[Didier Verna]

Miles Bader <miles@lsi.nec.co.jp> wrote:

> Ok, it's done.  Switch mode to "complain".
>
> I use gnus 5.10, so I didn't test my merge into the trunk, but I think
> the two branches are pretty much the same in this area (I looked for
> extra faces in the trunk, but only found one)...

  Miles, what about my complain in <muxu0jea7ri.fsf@uzeb.lrde.epita.fr> ? 
Anyway, FYI, I've just implemented a face aliasing feature in XEmacs 21.5 CVS.

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 53 14 59 22   didier@xemacs.org

Re: face renaming

[Miles Bader]

2005/7/19, Didier Verna <didier@lrde.epita.fr>:
>   Miles, what about my complain in <muxu0jea7ri.fsf@uzeb.lrde.epita.fr> ?

Sorry was zoning.

From the backtrace it looks like it's referencing an old face name;
the face names that gnus-group-highlight-line uses seem to come from
the variable `gnus-group-highlight'; I changed the default value of
that to reflect my face name changes, but is it possible that you have
it customized?

If xemacs barfs on non-existant faces, I suppose
`gnus-group-highlight-line' could do an alias lookup itself to handle
old versions of xemacs.

> Anyway, FYI, I've just implemented a face aliasing feature in XEmacs 21.5 CVS.

That's good.

I was going to add a `deffacealias' function, and replace all the
calls to `put' with uses of that.  Presumably following the form of
the `defvaralias' function.

-Miles
-- 
Do not taunt Happy Fun Ball.

Re: face renaming

[Didier Verna]

Miles Bader <snogglethorpe@gmail.com> wrote:

>>From the backtrace it looks like it's referencing an old face name;
> the face names that gnus-group-highlight-line uses seem to come from
> the variable `gnus-group-highlight'; I changed the default value of
> that to reflect my face name changes, but is it possible that you have
> it customized?

        Yes. The point is that while I find acceptable that user-level face
customizations are lost (in fact, not taken into account), Gnus should still
be able to launch properly. However, XEmacs throws an error if you try to
put-text-property a non existent face.


> If xemacs barfs on non-existant faces, I suppose `gnus-group-highlight-line'
> could do an alias lookup itself to handle old versions of xemacs.

        But who knows where else the problem might occur ? Maybe it would be
simpler (and safer) to still defface the old names ?

-- 
Didier Verna, didier@lrde.epita.fr, http://www.lrde.epita.fr/~didier

EPITA / LRDE, 14-16 rue Voltaire   Tel.+33 (1) 44 08 01 85
94276 Le Kremlin-Bicêtre, France   Fax.+33 (1) 53 14 59 22   didier@xemacs.org

Re: face renaming

[Miles Bader]

2005/7/19, Didier Verna <didier@lrde.epita.fr>:
>         But who knows where else the problem might occur ? Maybe it would be
> simpler (and safer) to still defface the old names ?

I think the best thing is to change it all to deffacealias (or
gnus-deffacealias), and let the xemacs version of that macro do
whatever crap it needs to do.

-Miles
-- 
Do not taunt Happy Fun Ball.