From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18893 invoked from network); 19 Dec 2022 18:05:42 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 19 Dec 2022 18:05:42 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p7KWD-009vxB-Es for ml@inbox.vuxu.org; Mon, 19 Dec 2022 12:05:41 -0600 Received: from lists1.math.uh.edu ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.96) (envelope-from ) id 1p7KWD-004ZQ1-0a for ml@inbox.vuxu.org; Mon, 19 Dec 2022 12:05:41 -0600 Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtp (Exim 4.96) (envelope-from ) id 1p7KWA-004ZPv-20 for ding@lists.math.uh.edu; Mon, 19 Dec 2022 12:05:38 -0600 Received: from quimby.gnus.org ([95.216.78.240]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p7KW8-009vwg-AU for ding@lists.math.uh.edu; Mon, 19 Dec 2022 12:05:38 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ItUqjEjbqzG4pb+r3vCqPxwtTkw/GCQqc6nXyC6V7oY=; b=KQVNpuex/rXLePHJA3d1OS+Jy2 9vTSKg3IhoPodXBEzqF1QCOgOkd9IiFWRAdhYNeJOelq5GnvpFhViaTdBNiPC1/E0UDVHMjvmDL+g SvdKQiEENXHrNiOplbGN/XasL72JwhZW+1irRNY932orolk8tEe1mp2/CaLazlOg0Ud8=; Received: from mail.ericabrahamsen.net ([52.70.2.18]) by quimby.gnus.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7KW0-0004Vl-R3; Mon, 19 Dec 2022 19:05:31 +0100 Received: from localhost (c-71-197-232-41.hsd1.wa.comcast.net [71.197.232.41]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id C4538FA011; Mon, 19 Dec 2022 18:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1671473126; bh=ItUqjEjbqzG4pb+r3vCqPxwtTkw/GCQqc6nXyC6V7oY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lbjXw43vf52HB3UAN/pQKTBzMVu1oqqHxx95CaiWrIYkkzgHhQCQreYPM5jztkNKd P5SwBPb1VKj4rXEiezMErGdyu1kJuMOoIgo4onanRl4JnyHIhECEgbDjRzQP0EWNsE 4i6jK/+0HKn5IUlEmKSFsnPFKkZoVMN/x2VwVoj8= From: Eric Abrahamsen To: Eli Zaretskii Cc: fweimer@redhat.com, larsi@gnus.org, emacs-devel@gnu.org, ding@gnus.org Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently In-Reply-To: <83tu1rcm2m.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 19 Dec 2022 19:58:25 +0200") References: <20210122180801.14756.84264@vcs0.savannah.gnu.org> <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org> <874jtvq8c2.fsf@oldenburg.str.redhat.com> <83k02qiicb.fsf@gnu.org> <87bko26ptd.fsf@oldenburg.str.redhat.com> <83r0wygh9b.fsf@gnu.org> <87k02nze8a.fsf@oldenburg.str.redhat.com> <83zgbjcoeq.fsf@gnu.org> <87k02ns2sg.fsf@ericabrahamsen.net> <83tu1rcm2m.fsf@gnu.org> Date: Mon, 19 Dec 2022 10:05:24 -0800 Message-ID: <87fsdbs1zv.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-ID: Precedence: bulk Eli Zaretskii writes: >> From: Eric Abrahamsen >> Cc: Florian Weimer , larsi@gnus.org, >> emacs-devel@gnu.org, ding@gnus.org >> Date: Mon, 19 Dec 2022 09:48:15 -0800 >>=20 >> On 12/19/22 19:07 PM, Eli Zaretskii wrote: >> >> Going back to older mail, I see that previously the From: header was >> >> written in encoded form to .overview (slightly wrapped to avoid SMTP >> >> issues): >> >>=20 >> >> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec' >> >> 'hello3.spec.' -> 'hello3.spec' >> >> =3D?utf-8?b?572X5YuH5YiaKFlvbmdnYW5nIEx1bykgdmlhIEVsZnV0aWxzLWRldmVs?= =3D >> >> Thu, 24 Nov 2022 16:27:56 +0800 >> >> >> >> <20220920084307.1696-1-luoyonggang@gmail.com> >> >> <20220920084307.1696-2-luoyonggang@gmail.com> >> >> >> >> >> >> <20221019194930.GC24703@redhat.com> >> >> <3bf19d05c8976411432709fae1cc2bcc2d21d700.camel@klomp.org> >> >> <586fbfd512763e539f0d06e8ffa308da34be5368.camel@wildebeest.org> >> >> 705 32 Xref: oldenburg.str.redhat.com >> >> lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler" >> >> , elfutils-devel@sourceware.org To: Mark Wielaard >> >> >> >>=20 >> >> Now it uses unencoded form: >> >>=20 >> >> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows =E7= =BD=97 >> >> =E5=8B=87=E5=88=9A(Yonggang Luo) via Elfutils-devel >> >> Mon, 19 Dec 2022 20:32:48 +0800 >> >> >> >> <20221217165213.152-1-luoyonggang@gmail.com> >> >> <20221217165213.152-14-luoyonggang@gmail.com> 1074 43 Xref: >> >> oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To: >> >> elfutils-devel@sourceware.org >> > >> > Is that a problem? I think this was part of the reason for that >> > change in nnml.el. >>=20 >> It would definitely be a problem to change the on-disk representation of >> data in the .overview files! Lots of code depends on a very specific >> format for those files; I've broken things badly in the past by removing >> header encoding there. > > But this change is there since Emacs 28, so if it's a problem, someone > would have hollered already, no? > > Or are you saying that the changes I installed are causing the > difference? If so, I don't see how that could happen, since the > change just ignores any errors signaled by rfc2047, and if rfc2047 > does signal an error, what is stored in the file is the same string as > what we did before the new function nnml--encode-headers was added and > we started using it. > > So unless I'm missing something, the changes I installed cannot cause > any new problems we didn't have since quite long ago. Sorry, I misunderstood -- I thought this change was introducing a difference in the saved files. My mistake for not following along closely enough. Maybe all this warrants some regression tests in ./test/lisp/mail?