From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 8404 invoked from network); 25 Jul 2021 18:27:46 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 25 Jul 2021 18:27:46 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m7iql-00150O-Ug for ml@inbox.vuxu.org; Sun, 25 Jul 2021 13:27:43 -0500 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.94) (envelope-from ) id 1m7iql-00B7fD-A7 for ml@inbox.vuxu.org; Sun, 25 Jul 2021 13:27:43 -0500 Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1m7c85-00B3y5-SL for ding@lists.math.uh.edu; Sun, 25 Jul 2021 06:17:09 -0500 Received: from quimby.gnus.org ([95.216.78.240]) by mx2.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1m7c83-008PXB-BB for ding@lists.math.uh.edu; Sun, 25 Jul 2021 06:17:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=DRkJEs4XbLWoC3hYjFklSI9M0IJeZT/s9K67wzZoND8=; b=mmrEG6CKgXqUsZb5F/Ma3Ykq/h zdmCuR9L41nxOl3PH8HvUtvMwL9OwoDV/9pIYJ4MepdYWq1eOWpLFBiovcKLU7NPyC4onQo9lCs7K 03zJNlYe/1ojuz07ksU3emxysj2XBxOxypS3rqtMPZdKaCjTz5xu1L3DhhTyZthk9usY=; Received: from mout02.posteo.de ([185.67.36.66]) by quimby.gnus.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m7c7u-00008s-JH for ding@gnus.org; Sun, 25 Jul 2021 13:17:01 +0200 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 455CD240103 for ; Sun, 25 Jul 2021 13:16:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.org; s=2017; t=1627211817; bh=ken4r+lT/IfX5maaWTL/J7EMCfjiNfRi8VNsSOfIlgA=; h=From:To:Cc:Subject:Date:From; b=B9hMqOeNi9uls6UzsyBTTszTFUGTxZge2mWPdsbTYWqDuMIqViKJ5Iqnwi5zlmLDK rwvKb2RxfpcSrnbjDj/BYqw8LyKwCsbxhLZLSGFpHaGLZsWiOxK3eCzer8Hm60ZiuL zwwQIpH59M8PQmCJ9ZJR18NWFf6wCqs4RHOWIcWhu0+K+dPWhwbuEj52cNwfnDjghc uf9HOjmVleRFLGhix4q9Ouy001Puy++jgpmDrRKoQfMtl6LJSYmeiX9zTPJl89hbxn ZugZZhvW3U4A36tIu1pEpzNQ7PjZ6yzxAP/5WStW1GzfalCT0sAbht2+AOJ0d40Opl hBT3GaMZ9pNXA== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4GXgVw3BKcz9rxS; Sun, 25 Jul 2021 13:16:56 +0200 (CEST) From: Alexandr Vityazev To: Eric Abrahamsen Cc: ding@gnus.org Subject: Re: Help testing gnus-search fixups References: <87sg12uejj.fsf@ericabrahamsen.net> <87fsx1g98n.fsf@tullinup.koldfront.dk> <877didvavo.fsf@ericabrahamsen.net> <87eeclnhl5.fsf@tullinup.koldfront.dk> <87a6n9ov0e.fsf@tullinup.koldfront.dk> <87zgv97x1u.fsf@ku.dk> <87pmw4ly9a.fsf@tullinup.koldfront.dk> <87k0mclxo8.fsf@tullinup.koldfront.dk> <87zgv7thls.fsf@ericabrahamsen.net> <87bl6tuqcb.fsf@posteo.org> <87mtqd83f7.fsf@ericabrahamsen.net> <87bl6sual8.fsf@posteo.org> <87h7gj9x2w.fsf@ericabrahamsen.net> Date: Sun, 25 Jul 2021 11:17:19 +0000 In-Reply-To: <87h7gj9x2w.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Sat, 24 Jul 2021 15:16:39 -0700") Message-ID: <87fsw21w3k.fsf@posteo.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-ID: Precedence: bulk --=-=-= Content-Type: text/plain On 2021-07-24, 15:16 -0700, Eric Abrahamsen wrote: > On 07/23/21 18:52 PM, Alexandr Vityazev wrote: >> On 2021-07-23, 08:18 -0700, Eric Abrahamsen wrote: >> >>> On 07/23/21 13:12 PM, Alexandr Vityazev wrote: >>>> Hi! >>>> >>>> GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, >>>> cairo version 1.16.0). Gnus v5.13. >>>> >>>> I tested the new version of gnus-search-indexed-parse-output yesterday >>>> and the search with notmuch completely fails. gnus-verbose is set to >>>> 10. press GG and type any search query, with the patch, I get: >>>> >>>> Doing /home/akagi/.guix-profile/bin/notmuch query on >>>> (nnmaildir+posteo:Drafts nnmaildir+posteo:Inbox nnmaildir+posteo:Sent >>>> nnmaildir+posteo:Trash nnmaildir+posteo:Notes)... >>>> Group nnselect:nnselect-87lf5xus2s.fsf contains no messages >>> >>> Hi, thanks for the report. Would you mind running your query on the >>> command line (using the same syntax as gnus-search does, mostly >>> output=files), and sending me the resulting list of file names >>> (off-list, if you prefer). I'll try to find out why the parsing process >>> is failing. >>> >>> >> notmuch search --output=files test >> >> >> >> in *Group* GG with "test" query, I get: >> >> Doing /home/akagi/.guix-profile/bin/notmuch query on >> (nnmaildir+posteo:Drafts nnmaildir+posteo:Inbox nnmaildir+posteo:Sent >> nnmaildir+posteo:Trash nnmaildir+posteo:Notes nnmaildir+posteo:Junk)... >> Group nnselect:nnselect-87czr8uasp.fsf contains no messages > > Hmm, I'm not able to reproduce this: it's a little difficult since I > don't actually have the files on my machine, but as far as I can tell > the search results are being parsed correctly. Are you familiar with > edebug at all? Is there any chance I could get you to step through the > function and see where things are going off? > > Thanks, > Eric > > I tested gnus-search-indexed-parse-output with edebug and found where something is going on. The attached patch fixes the issue for me. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnus-search-gnus-search-indexed-parse-output-Fix-sea.patch Content-Description: gnus-search-indexed-parse-output >From bfba4f38289223c3e78b19a73ad9133d015f8420 Mon Sep 17 00:00:00 2001 From: Alexandr Vityazev Date: Sun, 25 Jul 2021 14:09:39 +0300 Subject: [PATCH] gnus-search: gnus-search-indexed-parse-output: Fix search issue. * lisp/gnus/gnus-search.el (gnus-search-indexed-parse-output): Setting the group variable after the article variable. --- lisp/gnus/gnus-search.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/gnus/gnus-search.el b/lisp/gnus/gnus-search.el index 39bde837b3..80c3ce62f1 100644 --- a/lisp/gnus/gnus-search.el +++ b/lisp/gnus/gnus-search.el @@ -1384,7 +1384,6 @@ Returns a list of [group article score] vectors." nil t) nil t) nil t)) - (setq group (gnus-group-full-name group server)) (setq article (file-name-nondirectory f-name) article ;; TODO: Provide a cleaner way of producing final @@ -1394,6 +1393,7 @@ Returns a list of [group article score] vectors." (nnmaildir-base-name-to-article-number (substring article 0 (string-match ":" article)) group (string-remove-prefix "nnmaildir:" server)))) + (setq group (gnus-group-full-name group server)) (when (and (numberp article) (or (null groups) (member group groups))) -- 2.32.0 --=-=-= Content-Type: text/plain -- Best regards, Alexandr Vityazev --=-=-=--