Re: Gnorb and org-refile-use-outline-path

[Eric Abrahamsen <eric@ericabrahamsen.net>]

Michael Heerdegen <michael_heerdegen@web.de> writes:

> Eric Abrahamsen <eric@ericabrahamsen.net> writes:
>
>> > (let ((org-refile-use-outline-path
>> >        (if (eq gnorb-gnus-refile-use-outline-path 'use-org-value-maybe)
>> >            (or org-refile-use-outline-path 'file)
>> >          gnorb-gnus-refile-use-outline-path)))
>> >   code...)
>> >
>
>> Huh. That looks like a lot of work
>
> Not really.  What is really nontrivial work is to find out all places
> where you need to bind `org-refile-use-outline-path'.

Well that's not too hard, there are only four spots, I think.

> Then factor the
>
> (if (eq gnorb-gnus-refile-use-outline-path 'use-org-value-maybe)
>     (or org-refile-use-outline-path 'file)
>   gnorb-gnus-refile-use-outline-path)

> part into a defun `gnorb-get-gnus-refile-use-outline-path', and all you
> have to do is to bind `org-refile-use-outline-path' to
> (gnorb-get-gnus-refile-use-outline-path) instead of
> gnorb-gnus-refile-use-outline-path in all those places.

This should work fine, right?

#+begin_src elisp
(let ((org-refile-use-outline-path
       (if (eq gnorb-gnus-refile-use-outline-path 'org)
	   org-refile-use-outline-path
	 gnorb-gnus-refile-use-outline-path)))
  ...)
#+end_src

Then default the gnorb option to 'org.

> If you had to treat several variables this way, it would be better to
> define a macro `gnorb-with-org-bindings' that expands into a `let'.  But
> that's still a small and trivial change.

Yup, I'll leave that for later.

Thanks,
Eric