From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/86835 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: Re: Gnus cleanup Date: Fri, 12 Feb 2016 15:19:25 +1100 Organization: Programmerer Ingebrigtsen Message-ID: <87fuwyy302.fsf@gnus.org> References: <87h9hied21.fsf@gnus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1455250815 12197 80.91.229.3 (12 Feb 2016 04:20:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 12 Feb 2016 04:20:15 +0000 (UTC) Cc: ding@gnus.org To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 12 05:20:00 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aU5D3-0005km-F6 for ged-emacs-devel@m.gmane.org; Fri, 12 Feb 2016 05:19:57 +0100 Original-Received: from localhost ([::1]:56267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aU5D2-0006T0-HL for ged-emacs-devel@m.gmane.org; Thu, 11 Feb 2016 23:19:56 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59402) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aU5Cp-0006Sp-Sw for emacs-devel@gnu.org; Thu, 11 Feb 2016 23:19:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aU5Ck-0007wS-Tw for emacs-devel@gnu.org; Thu, 11 Feb 2016 23:19:43 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:39267) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aU5Ck-0007w6-Lz for emacs-devel@gnu.org; Thu, 11 Feb 2016 23:19:38 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1aU5Ci-0005T8-D3 for emacs-devel@gnu.org; Fri, 12 Feb 2016 05:19:36 +0100 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Feb 2016 05:19:36 +0100 Original-Received: from larsi by cpe-60-225-211-161.nsw.bigpond.net.au with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Fri, 12 Feb 2016 05:19:36 +0100 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: emacs-devel@gnu.org Original-Lines: 26 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: cpe-60-225-211-161.nsw.bigpond.net.au Mail-Copies-To: never User-Agent: Gnus/ (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:8RL8Vo+FoMPfD6DjSjuvndc10f8= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199787 gmane.emacs.gnus.general:86835 Archived-At: I've now completed the first pass over the Gnus sources, removing almost all XEmacs compat code. It has, of course, not all been tested very well, but it should be "obviously correct". :-) Virtually all of the changes involve either removing the first part after (if (featurep 'xemacs) ...) and leaving the "else" part in place. The compat function removal can be a little bit more invasive, but it's basically usually just replacing gnus-called-interactively-p with called-interactively-p, so it should also be "obviously" correct. But please do submit bug reports if this all blows up. The next thing I was going to do is grep for "boundp" and look whether the code looks like compat code or not. This may introduce actual bugs, because various builds of Emacs may have various things defined, but I'll try to be careful. But instead of jumping straight into that, I think I'm going to make the Gnus build warning free first, which should help when doing cleanup, I think. But, again, these will be "real changes", and may introduce bugs. But I hope not. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no