Gnus development mailing list
 help / color / mirror / Atom feed
From: "Łukasz Stelmach" <stlman@poczta.fm>
To: ding@gnus.org
Subject: [BUG] mml2015-epg-find-usable-key finds unusable key
Date: Wed, 13 Feb 2013 20:55:50 +0100	[thread overview]
Message-ID: <87fw106la1.fsf%stlman@poczta.fm> (raw)

[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]

Hi,

It looks like there is a sort of bug in mml2015-epg-encrypt at line
1117.

http://git.gnus.org/cgit/gnus.git/tree/lisp/mml2015.el?id=6e422932976e94d6dbb7ad602c5be3eb481fe46c#n1117)

The whole form that begins at line 1113 converts list of recipients
provided as email addresses, key IDs or anything gpg can digest into epg
"objects". Unfortunately there is one corner case that makes this code
fail. That is when a key is valid but a uid on it has been revoked.

Let's follow the code. epg-list-keys returns all keys for an ID. That
seems correct, however, since it knows the uid we are looking for it
might check if the uid hasn't been revoked. mml2015-epg-find-usable-key,
on the other hand, knows nothing about the recipient, it just checks
validity of the *keys* not uids.

epg.el is a part of emacs, mml2015.el belongs to gnus. IMHO it is
mml2015-epg-find-usable-key that should be fixed. The function should
accept and additional (optional?) parameter with a recipient uid as
passed to epg-list-keys and reject keys with all uids matching the
recipient parameter revoked.

I'd like to know opinion of someone who knows better than I the ideas
behind this code.

-- 
Miłego dnia,
Łukasz Stelmach

[-- Attachment #2: Type: application/pgp-signature, Size: 619 bytes --]

             reply	other threads:[~2013-02-13 19:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-13 19:55 Łukasz Stelmach [this message]
2013-02-14 19:28 ` Łukasz Stelmach
2013-02-15  4:05 ` Daiki Ueno
2013-02-15  7:59   ` Łukasz Stelmach
2013-02-15  9:14     ` Daiki Ueno
2013-02-16 18:35   ` Łukasz Stelmach
2013-02-16 21:11     ` Łukasz Stelmach
2013-02-17  3:12       ` Daiki Ueno
2013-02-17  7:47         ` Łukasz Stelmach
2013-02-17  9:02           ` Daiki Ueno
2013-02-17 10:20             ` Daiki Ueno
2013-02-17 21:29               ` Łukasz Stelmach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fw106la1.fsf%stlman@poczta.fm \
    --to=stlman@poczta.fm \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).