From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: spam.el: asking about removing spam-use-BBDB
Date: Wed, 09 Nov 2011 08:20:32 -0600 [thread overview]
Message-ID: <87fwhxwf67.fsf@lifelogs.com> (raw)
In-Reply-To: <87ty6kop7a.fsf@lifelogs.com>
On Thu, 03 Nov 2011 17:45:13 -0400 Ted Zlatanov <tzz@lifelogs.com> wrote:
TZ> On Tue, 01 Nov 2011 21:14:29 -0400 david.goldberg6@verizon.net (Dave Goldberg) wrote:
>>>> I'll support the BBDB backend to spam.el. I just need to fix the
>>>> `bbdb-search-simple' bug, it should work fine otherwise.
>>> Well like I said, since a recent update, it's almost having the
>>> opposite effect as what I want with many messages from people in .bbdb
>>> going into the spam group. I'm more than happy to try to help debug
>>> this, but I don't know where to begin.
DG> my trivial fix is:
DG> (if (fboundp 'bbdb-search-simple)
DG> (bbdb-search-simple nil who) ;; v2
DG> (bbdb-search (bbdb-records) who)) ;; v3
DG> Obviously I have no clue if that would continue to work as desired with bbdb v3, though.
TZ> It doesn't work exactly right, unfortunately. I'll look at it when I
TZ> get a chance. I'm really sorry for the inconvenience.
I comitted a fix that removes the whole `bbdb-search*' issue. It also
avoids the BBDB autoloads. Please test and let me know.
Simplest test to verify it pick knownemail@knownhost.com out of BBDB,
then:
(spam-exists-in-BBDB-p "knownemail@knownhost.com")
The fundamental issue is with the `bbdb-search' defmacro and
compile-time detection of BBDB. I'm not good enough with that part of
Emacs to tell what's up, but I think I've taken the right (and faster)
approach.
Ted
next prev parent reply other threads:[~2011-11-09 14:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-11 12:09 Ted Zlatanov
2011-10-12 0:42 ` Dave Goldberg
2011-10-22 18:50 ` Dave Goldberg
2011-10-23 2:18 ` Eric Abrahamsen
2011-10-24 2:22 ` Dave Goldberg
2011-10-24 9:21 ` Richard Riley
2011-10-24 13:24 ` Ted Zlatanov
2011-10-24 13:26 ` Ted Zlatanov
2011-10-25 2:08 ` Dave Goldberg
2011-11-02 1:14 ` Dave Goldberg
2011-11-03 21:45 ` Ted Zlatanov
2011-11-09 14:20 ` Ted Zlatanov [this message]
2011-11-11 16:29 ` Dave Goldberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwhxwf67.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).