Proposed code to cleanup gnus on Emacs exit

Proposed code to cleanup gnus on Emacs exit

[John Wiegley]

I'm a bit surprised Gnus doesn't do this already: This code will make sure
that when you exit Emacs, and Gnus is running, that everything gets cleaned up
as it should:

--8<---------------cut here---------------start------------->8---
;;; Cleanup all Gnus buffers on exit

(defun exit-gnus-on-exit ()
  (if (and (fboundp 'gnus-group-exit)
	   (gnus-alive-p))
      (with-current-buffer (get-buffer "*Group*")
	(let (gnus-interactive-exit)
	  (gnus-group-exit)))))

(add-hook 'kill-emacs-hook 'exit-gnus-on-exit)
--8<---------------cut here---------------end--------------->8---

John

Re: Proposed code to cleanup gnus on Emacs exit

[Lars Magne Ingebrigtsen]

John Wiegley <jwiegley@gmail.com> writes:

> I'm a bit surprised Gnus doesn't do this already: This code will make
> sure that when you exit Emacs, and Gnus is running, that everything
> gets cleaned up as it should:

Adding large and error-prone chunks of code to the general Emacs exit
isn't a good idea, in my opinion.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Proposed code to cleanup gnus on Emacs exit

[John Wiegley]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Adding large and error-prone chunks of code to the general Emacs exit isn't
> a good idea, in my opinion.

Are you referring to Gnus?  I've been using that exit code for about 13 years
now, and have yet to experience problems with it.

John

Re: Proposed code to cleanup gnus on Emacs exit

[Richard Riley]

John Wiegley <jwiegley@gmail.com> writes:

>>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Adding large and error-prone chunks of code to the general Emacs exit isn't
>> a good idea, in my opinion.
>
> Are you referring to Gnus?  I've been using that exit code for about 13 years
> now, and have yet to experience problems with it.

I added it to my setup and it works fine - a +1 from me.

Re: Proposed code to cleanup gnus on Emacs exit

[Ted Zlatanov]

On Sat, 10 Sep 2011 19:42:53 -0500 John Wiegley <jwiegley@gmail.com> wrote: 

>>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>> Adding large and error-prone chunks of code to the general Emacs exit isn't
>> a good idea, in my opinion.

JW> Are you referring to Gnus?  I've been using that exit code for about
JW> 13 years now, and have yet to experience problems with it.

How about making it optional and off by default, toggled on by a
boolean?  It seems useful.

Ted

Re: Proposed code to cleanup gnus on Emacs exit

[John Wiegley]

>>>>> Ted Zlatanov <tzz@lifelogs.com> writes:

JW> Are you referring to Gnus?  I've been using that exit code for about 13
JW> years now, and have yet to experience problems with it.

> How about making it optional and off by default, toggled on by a boolean?
> It seems useful.

Sounds like a good compromise to me.

John

Re: Proposed code to cleanup gnus on Emacs exit

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> How about making it optional and off by default, toggled on by a
> boolean?  It seems useful.

I don't really see the need.  The dribble file is saved, and that should
be sufficient.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Proposed code to cleanup gnus on Emacs exit

[Dave Abrahams]

on Thu Oct 06 2011, Lars Magne Ingebrigtsen <larsi-AT-gnus.org> wrote:

> Ted Zlatanov <tzz@lifelogs.com> writes:
>
>> How about making it optional and off by default, toggled on by a
>> boolean?  It seems useful.
>
> I don't really see the need.  The dribble file is saved, and that should
> be sufficient.

But then you get an alarming message and a prompt the next time you
start up gnus.  Why shouldn't it just be safe and smooth to quit emacs
whenever?

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Re: Proposed code to cleanup gnus on Emacs exit

[Lars Magne Ingebrigtsen]

Dave Abrahams <dave@boostpro.com> writes:

> But then you get an alarming message and a prompt the next time you
> start up gnus.

I don't think it's particularly alarming.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Re: Proposed code to cleanup gnus on Emacs exit

[John Wiegley]

>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Dave Abrahams <dave@boostpro.com> writes:
>> But then you get an alarming message and a prompt the next time you start
>> up gnus.

> I don't think it's particularly alarming.

I find myself alarmed.

John

Re: Proposed code to cleanup gnus on Emacs exit

[Dan Christensen]

Dave Abrahams <dave@boostpro.com> writes:

> But then you get an alarming message and a prompt the next time you
> start up gnus.  Why shouldn't it just be safe and smooth to quit emacs
> whenever?

If I'm in the middle of reading a message, get distracted, and then quit
emacs, gnus might mark the article as read and I'd never get to see it
again.  Those prompts about unsaved summary buffers are helpful
reminders that you might want to finish what you were in the middle of.

Dan

Re: Proposed code to cleanup gnus on Emacs exit

[Dave Abrahams]

on Thu Oct 06 2011, Lars Magne Ingebrigtsen <larsi-AT-gnus.org> wrote:

> Dave Abrahams <dave@boostpro.com> writes:
>
>> But then you get an alarming message and a prompt the next time you
>> start up gnus.
>
> I don't think it's particularly alarming.

Of course not.  Can't we at least read the dribble file unconditionally?
IIRC Gnus can become hopelessly borked if you answer "no" to that
prompt.  In fact, I seem to remember you telling me years ago to just
answer yes always.

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Re: Proposed code to cleanup gnus on Emacs exit

[Dan Christensen]

Dave Abrahams <dave@boostpro.com> writes:

> Can't we at least read the dribble file unconditionally?

Please, no.  If I accidentally catch up a group or something else gets
messed up, then what I do is exit emacs *without* saving the .newsrc.eld
and then start Gnus without reading the dribble file.  You are proposing
removing both of those options, which would get rid of that safety net.

Dan

Re: Proposed code to cleanup gnus on Emacs exit

[Dave Abrahams]

on Fri Oct 07 2011, Dan Christensen <jdc-AT-uwo.ca> wrote:

> Dave Abrahams <dave@boostpro.com> writes:
>
>> Can't we at least read the dribble file unconditionally?
>
> Please, no.  If I accidentally catch up a group or something else gets
> messed up, then what I do is exit emacs *without* saving the .newsrc.eld
> and then start Gnus without reading the dribble file.  You are proposing
> removing both of those options, which would get rid of that safety net.

This seems like optimizing the 1% case at the expense of the other 99.

`M-x gnus-no-dribble RET'?


-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

Re: Proposed code to cleanup gnus on Emacs exit

[Michael Cook]

Dan Christensen <jdc@uwo.ca> writes:

> Dave Abrahams <dave@boostpro.com> writes:
>
>> Can't we at least read the dribble file unconditionally?
>
> Please, no.  If I accidentally catch up a group or something else gets
> messed up, then what I do is exit emacs *without* saving the .newsrc.eld
> and then start Gnus without reading the dribble file.  You are proposing
> removing both of those options, which would get rid of that safety net.

Your safety net could be to remove the dribble file before
restarting gnus.  After all, you knew something had gone wrong
before you decided to exit without saving.

Michael

Re: Proposed code to cleanup gnus on Emacs exit

[Richard Riley]

Dan Christensen <jdc@uwo.ca> writes:

> Dave Abrahams <dave@boostpro.com> writes:
>
>> Can't we at least read the dribble file unconditionally?
>
> Please, no.  If I accidentally catch up a group or something else gets
> messed up, then what I do is exit emacs *without* saving the .newsrc.eld
> and then start Gnus without reading the dribble file.  You are proposing
> removing both of those options, which would get rid of that safety net.

So the poor solution remains because of the chance of one person making
the wrong decision and issuing a legitimate command which then gnus acts
correctly on? Better would be if you want to be able to undo stuff then
use git or something on your .eld file.

Re: Proposed code to cleanup gnus on Emacs exit

[Steinar Bang]

>>>>> Dave Abrahams <dave@boostpro.com>:

> This seems like optimizing the 1% case at the expense of the other 99.

Just stating for the record: as a long term gnus user, I'm comfortable
with the current behaviour, and see no need for a change.

Re: Proposed code to cleanup gnus on Emacs exit

[Reiner Steib]

On Thu, Sep 29 2011, Ted Zlatanov wrote:

> On Sat, 10 Sep 2011 19:42:53 -0500 John Wiegley <jwiegley@gmail.com> wrote: 
[ `gnus-group-exit' in `kill-emacs-hook´ ]
> How about making it optional and off by default, toggled on by a
> boolean?  It seems useful.

If such code is added to `kill-emacs-hook´, it should query to save
the ~/.newsrc.eld file instead of doing it unconditionally.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/