Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

[Lars Ingebrigtsen]

Julien Danjou <julien@danjou.info> writes:

>     Revert "message: insert mail-header-separator read-only and intangible"

Any particular reason?  Seemed like a good idea to me...  only I'd do it
with overlays instead of text properties so that it'd be less "sticky"
when kill'n'yanking it.

Or perhaps just defaulting the separator to "" might be nicer.  And
perhaps display the division with a non-textual display property of some
kind?  The separator text has always annoyed me.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 748 bytes --]

On Thu, Feb 03 2011, Lars Ingebrigtsen wrote:

>
> Any particular reason?  Seemed like a good idea to me...  only I'd do it
> with overlays instead of text properties so that it'd be less "sticky"
> when kill'n'yanking it.
>
> Or perhaps just defaulting the separator to "" might be nicer.  And
> perhaps display the division with a non-textual display property of some
> kind?  The separator text has always annoyed me.

At least draft edition failed with an read only error, and rather than
looking 3h for why, I preferred to revert for now so people do not get
annoyed. :)

I do think it's a good idea too, it just had some side effect I want to
fix before reapplying it. :)

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

[Julien Danjou]

[-- Attachment #1: Type: text/plain, Size: 349 bytes --]

On Thu, Feb 03 2011, Julien Danjou wrote:

> I do think it's a good idea too, it just had some side effect I want to
> fix before reapplying it. :)

Ok, seems good know, so I reapplied it.

I did not add code to re-add the properties when editing a draft. I'm
not sure if it's worth it.

-- 
Julien Danjou
❱ http://julien.danjou.info

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

[Adam Sjøgren]

On Thu, 03 Feb 2011 17:30:02 +0100, Julien wrote:

> On Thu, Feb 03 2011, Julien Danjou wrote:
>> I do think it's a good idea too, it just had some side effect I want to
>> fix before reapplying it. :)

> Ok, seems good know, so I reapplied it.

Could this be what breaks gnus-summary-resend-message (S D r) with the
error "Text is read-only" appearing in the mini buffer?

*Messages* shows "message-resend: Text is read-only".


  Best regards,

    Adam

-- 
 "Här kommer rädslan, gamle vän                               Adam Sjøgren
  När alla fjärilar i magen vaknar upp                   asjo@koldfront.dk
  Viskar välkommen hem"

Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

[Adam Sjøgren]

On Thu, 03 Feb 2011 19:12:19 +0100, Adam wrote:

> Could this be what breaks gnus-summary-resend-message (S D r) with the
> error "Text is read-only" appearing in the mini buffer?

> *Messages* shows "message-resend: Text is read-only".

git bisect says:

    bd10f37e4630719920f82122d7c7ae7523567762 is the first bad commit
    commit bd10f37e4630719920f82122d7c7ae7523567762
    Author: Julien Danjou <julien@danjou.info>
    Date:   Thu Feb 3 16:26:11 2011 +0100

        message: insert mail-header-separator read-only and intangible


  Best regards,

    Adam

-- 
 "Här kommer rädslan, gamle vän                               Adam Sjøgren
  När alla fjärilar i magen vaknar upp                   asjo@koldfront.dk
  Viskar välkommen hem"

Re: [gnus git] branch master updated: =1= Revert "message: insert mail-header-separator read-only and intangible"

[Lars Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> Could this be what breaks gnus-summary-resend-message (S D r) with the
> error "Text is read-only" appearing in the mini buffer?

Yes.  Should be fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen