From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/76163 Path: news.gmane.org!not-for-mail From: asjo@koldfront.dk (Adam =?utf-8?Q?Sj=C3=B8gren?=) Newsgroups: gmane.emacs.gnus.general,gmane.emacs.bbdb.user Subject: Re: gcc tab completion strangeness Date: Mon, 31 Jan 2011 20:44:21 +0100 Organization: koldfront - analysis & revolution, Copenhagen, Denmark Message-ID: <87fws8vox6.fsf@topper.koldfront.dk> References: <871v4kio15.fsf@micropit.couberia.bzh> <87lj2sbidu.fsf@member.fsf.org> <87pqs4jx2a.fsf@ericabrahamsen.net> <87ipxwwg22.fsf@topper.koldfront.dk> <87sjwa5wod.fsf@topper.koldfront.dk> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1296503084 4382 80.91.229.12 (31 Jan 2011 19:44:44 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 31 Jan 2011 19:44:44 +0000 (UTC) Cc: bbdb-info@lists.sourceforge.net, Tassilo Horn , jidanni@jidanni.org, ding@gnus.org To: Stefan Monnier Original-X-From: ding-owner+M24515@lists.math.uh.edu Mon Jan 31 20:44:39 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pjzfx-0003EL-I2 for ding-account@gmane.org; Mon, 31 Jan 2011 20:44:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Pjzft-0001Tr-3d; Mon, 31 Jan 2011 13:44:33 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Pjzfr-0001Td-Ox for ding@lists.math.uh.edu; Mon, 31 Jan 2011 13:44:31 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1Pjzfp-0002vs-Bc for ding@lists.math.uh.edu; Mon, 31 Jan 2011 13:44:30 -0600 Original-Received: from 2505ds5-by.0.fullrate.dk ([95.166.24.143] helo=topper.koldfront.dk) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1Pjzfn-0004wu-N3 for ding@gnus.org; Mon, 31 Jan 2011 20:44:27 +0100 Original-Received: by topper.koldfront.dk (Postfix, from userid 1000) id 96D6050FA736; Mon, 31 Jan 2011 20:44:21 +0100 (CET) X-Hashcash: 1:21:110131:ding@gnus.org::CIjPIT7QykfwnlMy:00007DHR X-Now-Playing: I Can Only Give You Everything, Them Again (Them) X-Hashcash: 1:21:110131:tassilo@member.fsf.org::dG9Ei+flNoDialXV:0000000000000000000000000000000000000000sDF X-Hashcash: 1:21:110131:monnier@iro.umontreal.ca::0L/n44EeonGDk2cv:00000000000000000000000000000000000005xK2 X-Hashcash: 1:21:110131:jidanni@jidanni.org::Qf7d835UUYUeqmHY:000000000000000000000000000000000000000000A+ke X-Hashcash: 1:21:110131:bbdb-info@lists.sourceforge.net::1PL5Fx75oUSj/Inl:000000000000000000000000000000PwMm X-Face: )qY&CseJ?.:=8F#^~GcSA?F=9eu'{KAFfL1C3/A&:nE?PW\i65"ba0NS)97,Q(^@xk}n4Ou rPuR#V8I(J_@~H($[ym:`K_+]*kjvW>xH5jbgLBVFGXY:(#4P>zVBklLbdL&XxL\M)%T}3S/IS9lMJ ^St'=VZBR (Stefan Monnier's message of "Mon, 31 Jan 2011 10:05:38 -0500") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) X-Spam-Score: -1.9 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:76163 gmane.emacs.bbdb.user:2436 Archived-At: On Mon, 31 Jan 2011 10:05:38 -0500, Stefan wrote: >> I looks quite ugly. > Yes, I'd rather not hard code that much info about BBDB-internals in > message.el. Can you try the patch below instead, which should work > about as well, but without relying on internal knowledge about BBDB? In my brief testing your patch below works great - thanks for looking into this! > =3D=3D=3D modified file 'lisp/gnus/message.el' > --- lisp/gnus/message.el 2011-01-25 04:08:28 +0000 > +++ lisp/gnus/message.el 2011-01-31 15:04:55 +0000 > @@ -7867,7 +7867,12 @@ > (eudc-expand-inline)) > ((and (memq 'bbdb message-expand-name-databases) > (fboundp 'bbdb-complete-name)) > - (bbdb-complete-name)) > + (let ((starttick (buffer-modified-tick))) > + (or (bbdb-complete-name) > + ;; Apparently, bbdb-complete-name can return nil even when > + ;; completion took place. So let's double check the buf= fer was > + ;; not modified. > + (!=3D starttick (buffer-modified-tick))))) > (t > (expand-abbrev)))) =20 Best regards, Adam --=20 "My ethicator machine must've had a built-in moral Adam Sj=C3=B8= gren compromise spectral release phantasmatron!" asjo@koldfront.dk