Re: spam splitting : "already done".

[Ted Zlatanov <tzz@lifelogs.com>]

On Thu, 27 Jan 2011 17:48:42 -0800 Lars Ingebrigtsen <larsi@gnus.org> wrote: 

LI> Richard Riley <rileyrg@googlemail.com> writes:
>> Should that say "when nil all unread articles are checked for
>> spam". There may or may not be marking involved.

LI> I see.  Perhaps the spam checking should be running on only the unseen
LI> articles?  Ted?

The spam processors are run on whatever is spam-marked.

spam-marks are applied when you enter the group according to the basic
rules, using `spam-mark-new-messages-in-spam-group-as-spam'[1] and
`spam-mark-only-unseen-as-spam'.  It also matters if the group is a spam
group and if you've customized the group or topic.

The goal is to mark only articles you haven't seen before as spam.  It
sounds like the problem is that you're getting seen but unread articles
marked as spam (and you have spam-mark-only-unseen-as-spam set to t).
The logic is (IMO) very simple, see below.  Can you please add

(debug 1 spam-mark-new-messages-in-spam-group-as-spam 
       2 spam-mark-only-unseen-as-spam
       3 (spam-group-spam-contents-p gnus-newsgroup-name)
       4 gnus-newsgroup-name)

right before the (when...) below, hit `M-C-e' to evaluate, then tell us
what you get in the debug trace?  Hit `q' to abort it or `c' to
continue, then just remove the debug line and use `M-C-e' again to get
back the original behavior.

The reason for this is to make sure that your variables and parameters
are set to what you think.  Can you also confirm my understanding of
your problem is correct, and that you're not getting the results we're
expecting?

Thanks and sorry for the lengthy explanation...
Ted

[1] contender for "longest variable name with a purpose" :)

(defun spam-mark-junk-as-spam-routine ()
  ;; check the global list of group names spam-junk-mailgroups and the
  ;; group parameters
  (when (spam-group-spam-contents-p gnus-newsgroup-name)
    (gnus-message 6 "Marking %s articles as spam"
                  (if spam-mark-only-unseen-as-spam
                      "unseen"
                    "unread"))
    (let ((articles (if spam-mark-only-unseen-as-spam
                        gnus-newsgroup-unseen
                      gnus-newsgroup-unreads)))
      (if spam-mark-new-messages-in-spam-group-as-spam
          (dolist (article articles)
            (gnus-summary-mark-article article gnus-spam-mark))
        (gnus-message 9 "Did not mark new messages as spam.")))))