From: Michael Albinus <michael.albinus@gmx.de>
To: Ted Zlatanov <tzz@lifelogs.com>
Cc: ding@gnus.org
Subject: Re: auth-source.el rewrite
Date: Wed, 26 Jan 2011 20:35:34 +0100 [thread overview]
Message-ID: <87fwsfihkp.fsf@gmx.de> (raw)
In-Reply-To: <8739ofzjfb.fsf@lifelogs.com> (Ted Zlatanov's message of "Wed, 26 Jan 2011 11:03:36 -0600")
[-- Attachment #1: Type: text/plain, Size: 508 bytes --]
Ted Zlatanov <tzz@lifelogs.com> writes:
> MA> OK, but short tests help me to understand the API better. And if it
> MA> comes to creation of new entries, I would like to *see* how it works.
>
> Bah. Now I have to write auth-source-netrc-create before the weekend :)
For the rest, I've played already around. In general, the new API looks
good to me. Appended is a patch for some few minor things I've observed
during the game.
And now waiting for the creation thingie ...
> Ted
Best regards, Michael.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 3582 bytes --]
*** /home/albinus/lisp/auth-source.el.~1~ 2011-01-25 13:55:05.000000000 +0100
--- /home/albinus/lisp/auth-source.el 2011-01-26 17:41:59.223404487 +0100
***************
*** 41,46 ****
--- 41,47 ----
(require 'gnus-util)
(require 'netrc)
+ (require 'assoc)
(eval-when-compile (require 'cl))
(eval-when-compile (require 'eieio))
***************
*** 93,104 ****
;;(auth-source-backend "netrc" :type 'netrc)
- (defcustom auth-source-do-cache t
- "Whether auth-source should cache information."
- :group 'auth-source
- :version "23.2" ;; No Gnus
- :type `boolean)
-
(defcustom auth-source-protocols '((imap "imap" "imaps" "143" "993")
(pop3 "pop3" "pop" "pop3s" "110" "995")
(ssh "ssh" "22")
--- 94,99 ----
***************
*** 173,179 ****
It's best to customize this with `M-x customize-variable' because the choices
can get pretty complex."
:group 'auth-source
! :version "23.2" ;; No Gnus
:type `(repeat :tag "Authentication Sources"
(choice
(string :tag "Just a file")
--- 168,174 ----
It's best to customize this with `M-x customize-variable' because the choices
can get pretty complex."
:group 'auth-source
! :version "24.1" ;; No Gnus
:type `(repeat :tag "Authentication Sources"
(choice
(string :tag "Just a file")
***************
*** 216,222 ****
"List of recipient keys that `authinfo.gpg' encrypted to.
If the value is not a list, symmetric encryption will be used."
:group 'auth-source
! :version "23.2" ;; No Gnus
:type '(choice (const :tag "Symmetric encryption" t)
(repeat :tag "Recipient public keys"
(string :tag "Recipient public key"))))
--- 211,217 ----
"List of recipient keys that `authinfo.gpg' encrypted to.
If the value is not a list, symmetric encryption will be used."
:group 'auth-source
! :version "24.1" ;; No Gnus
:type '(choice (const :tag "Symmetric encryption" t)
(repeat :tag "Recipient public keys"
(string :tag "Recipient public key"))))
***************
*** 592,598 ****
"Given a property list SPEC, return search matches from the :backend.
See `auth-source-search' for details on SPEC."
;; just in case, check that the type is correct
! (assert (eq type (oref backend type)))
(let ((results (auth-source-netrc-normalize
(auth-source-netrc-parse
--- 587,593 ----
"Given a property list SPEC, return search matches from the :backend.
See `auth-source-search' for details on SPEC."
;; just in case, check that the type is correct
! (assert (or (null type) (eq type (oref backend type))))
(let ((results (auth-source-netrc-normalize
(auth-source-netrc-parse
***************
*** 860,866 ****
host protocol username)
found) ; return the found data
;; else, if not found
! (let ((choices (apply 'auth-source-pick search)))
(dolist (choice choices)
(if delete-existing
(apply 'auth-source-delete choice search)
--- 855,861 ----
host protocol username)
found) ; return the found data
;; else, if not found
! (let ((choices (apply 'auth-source-search search)))
(dolist (choice choices)
(if delete-existing
(apply 'auth-source-delete choice search)
next prev parent reply other threads:[~2011-01-26 19:35 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 2:59 nnimap-username Daiki Ueno
2010-10-25 6:33 ` nnimap-username Reiner Steib
2010-10-25 7:13 ` nnimap-username Daiki Ueno
2010-10-25 18:09 ` auth-source tokens (was: nnimap-username) Ted Zlatanov
2010-10-26 16:56 ` auth-source tokens Ted Zlatanov
2010-10-29 8:04 ` Michael Albinus
2010-10-29 22:15 ` Lars Magne Ingebrigtsen
2010-11-11 16:22 ` Ted Zlatanov
2010-11-14 17:24 ` Michael Albinus
2010-11-15 0:59 ` Ted Zlatanov
2010-11-15 4:47 ` Michael Albinus
2010-11-15 15:14 ` Ted Zlatanov
2010-11-15 16:03 ` Michael Albinus
2011-01-24 17:27 ` auth-source.el rewrite (was: auth-source tokens) Ted Zlatanov
2011-01-24 23:36 ` auth-source.el rewrite Lars Ingebrigtsen
2011-01-25 16:59 ` Ted Zlatanov
2011-01-25 21:09 ` Michael Albinus
2011-01-25 21:42 ` Ted Zlatanov
2011-01-26 8:32 ` Michael Albinus
2011-01-26 17:03 ` Ted Zlatanov
2011-01-26 19:35 ` Michael Albinus [this message]
2011-01-26 20:35 ` Ted Zlatanov
2011-01-26 22:15 ` Ted Zlatanov
2011-01-27 16:49 ` Michael Albinus
2011-01-27 20:20 ` Ted Zlatanov
2011-01-29 14:11 ` Michael Albinus
2011-01-31 2:49 ` Ted Zlatanov
2011-01-31 14:30 ` Michael Albinus
2011-01-31 17:09 ` Ted Zlatanov
2011-01-27 12:35 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fwsfihkp.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=ding@gnus.org \
--cc=tzz@lifelogs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).