Re: SPAM in spam group is processed into that exact same group

[Ted Zlatanov <tzz@lifelogs.com>]

On Mon, 25 Oct 2010 22:05:05 +0200 Tassilo Horn <tassilo@member.fsf.org> wrote: 

TH> Ted Zlatanov <tzz@lifelogs.com> writes:
TH> Hi Ted,

>> You're classifying "nnimap+Fastmail:INBOX.training.spam" as a spam
>> group and also telling spam.el to move spam messages there.  So yes,
>> it will always respool messages on exit.  I think the proper fix is to
>> make the spam exit processor check if the destination group is the
>> same.  Can you try the attached patch?

TH> Till now, I didn't try your patch, but I think that it is not the proper
TH> fix, because right now, all the correctly classified SPAM messages in my
TH> "real" spam group "nnimap+Fastmail:INBOX.Junk Mail" are moved to the
TH> spam training group "nnimap+Fastmail:INBOX.training.spam".  Of course,
TH> in the training groups I only want to have the false positives and false
TH> negatives.

I forgot (it's been a while): copy/move is separate from the processors.
s/spam exit processor/spam mover/ above.

So we want to look at `spam-copy-or-move-routine' and not at the
processor routines.

TH> IMO, the proper way would be to invoke only the opposite processor of
TH> the groups' classification, that is, invoke the ham processor in groups
TH> classified as spam, and only the spam processor in ham (and
TH> unclassified) groups.  Or do you know any usecase for invoking the spam
TH> processor in spam groups or the ham processor in ham groups?

I think what you describe is already the case, but in any case is not
relevant to your problem, which is with the copy/move routine.

I think the logic should be:

1) when (and (eq classification 'spam)
             (spam-group-spam-contents-p gnus-newsgroup-name)
             (spam-group-spam-contents-p target))
   -> message "Sorry, can't move spam from spam group A to spam group B"

2) when (and (eq classification 'ham)
             (spam-group-ham-contents-p gnus-newsgroup-name)
             (spam-group-ham-contents-p target))
   -> message "Sorry, can't move ham from ham group A to ham group B"

3) any other case, operate normally and actually do the moves

WDYT?
Ted