From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/73598 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: SPAM in spam group is processed into that exact same group Date: Mon, 25 Oct 2010 15:23:17 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <87fwvu2f9m.fsf@lifelogs.com> References: <87ocan4cis.fsf@thinkpad.tsdh.de> <87tykbj4of.fsf@thinkpad.tsdh.de> <87iq0q3xzx.fsf@lifelogs.com> <87tykaf37y.fsf@thinkpad.tsdh.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1288038227 3106 80.91.229.12 (25 Oct 2010 20:23:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 25 Oct 2010 20:23:47 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M21967@lists.math.uh.edu Mon Oct 25 22:23:45 2010 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PATa5-0005Ss-02 for ding-account@gmane.org; Mon, 25 Oct 2010 22:23:45 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1PATZx-0000DE-TI; Mon, 25 Oct 2010 15:23:37 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1PATZw-0000Cy-96 for ding@lists.math.uh.edu; Mon, 25 Oct 2010 15:23:36 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1PATZv-0006jq-7q for ding@lists.math.uh.edu; Mon, 25 Oct 2010 15:23:36 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1PATZu-00087y-00 for ; Mon, 25 Oct 2010 22:23:34 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PATZr-0005Mj-Ee for ding@gnus.org; Mon, 25 Oct 2010 22:23:31 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Oct 2010 22:23:31 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 25 Oct 2010 22:23:31 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 49 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:pf1zbncbK3MG7tn/uvI8+nYxFIM= X-Spam-Score: -0.7 (/) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:73598 Archived-At: On Mon, 25 Oct 2010 22:05:05 +0200 Tassilo Horn wrote: TH> Ted Zlatanov writes: TH> Hi Ted, >> You're classifying "nnimap+Fastmail:INBOX.training.spam" as a spam >> group and also telling spam.el to move spam messages there. So yes, >> it will always respool messages on exit. I think the proper fix is to >> make the spam exit processor check if the destination group is the >> same. Can you try the attached patch? TH> Till now, I didn't try your patch, but I think that it is not the proper TH> fix, because right now, all the correctly classified SPAM messages in my TH> "real" spam group "nnimap+Fastmail:INBOX.Junk Mail" are moved to the TH> spam training group "nnimap+Fastmail:INBOX.training.spam". Of course, TH> in the training groups I only want to have the false positives and false TH> negatives. I forgot (it's been a while): copy/move is separate from the processors. s/spam exit processor/spam mover/ above. So we want to look at `spam-copy-or-move-routine' and not at the processor routines. TH> IMO, the proper way would be to invoke only the opposite processor of TH> the groups' classification, that is, invoke the ham processor in groups TH> classified as spam, and only the spam processor in ham (and TH> unclassified) groups. Or do you know any usecase for invoking the spam TH> processor in spam groups or the ham processor in ham groups? I think what you describe is already the case, but in any case is not relevant to your problem, which is with the copy/move routine. I think the logic should be: 1) when (and (eq classification 'spam) (spam-group-spam-contents-p gnus-newsgroup-name) (spam-group-spam-contents-p target)) -> message "Sorry, can't move spam from spam group A to spam group B" 2) when (and (eq classification 'ham) (spam-group-ham-contents-p gnus-newsgroup-name) (spam-group-ham-contents-p target)) -> message "Sorry, can't move ham from ham group A to ham group B" 3) any other case, operate normally and actually do the moves WDYT? Ted