From: Naohiro Aota <nao.aota@gmail.com>
To: ding@gnus.org
Subject: nnimap-demule shouldn't be called with nil
Date: Fri, 12 Dec 2008 12:11:14 +0900 [thread overview]
Message-ID: <87fxkuozot.fsf@yue.localnetwork> (raw)
[-- Attachment #1: Type: text/plain, Size: 418 bytes --]
Hi, list.
In some situations, Gnus call `nnimap-demule' with nil, and cause an
error: "insert: Wrong type argument: stringp, nil". This makes
`gnus-summary-prev-article' stop working in the situations.
Anyway, I wrote a patch for this. Please find the patch below.
2008-12-12 Naohiro Aota <nao.aota@gmail.com>
* nnimap.el (nnimap-request-article-part): Call nnimap-demule with
empty string, when data is nil.
[-- Attachment #2: Type: text/plain, Size: 727 bytes --]
Index: lisp/nnimap.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/nnimap.el,v
retrieving revision 7.55
diff -u -r7.55 nnimap.el
--- lisp/nnimap.el 3 Dec 2008 20:33:34 -0000 7.55
+++ lisp/nnimap.el 12 Dec 2008 02:11:50 -0000
@@ -950,9 +950,10 @@
(erase-buffer)
(let ((data (imap-fetch article part prop nil
nnimap-server-buffer)))
- (insert (nnimap-demule (if detail
- (nth 2 (car data))
- data))))
+ (insert (nnimap-demule (or (if detail
+ (nth 2 (car data))
+ data)
+ ""))))
(nnheader-ms-strip-cr)
(gnus-message
10 "nnimap: Fetching (part of) article %d from %s...done"
[-- Attachment #3: Type: text/plain, Size: 10 bytes --]
Regards,
reply other threads:[~2008-12-12 3:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fxkuozot.fsf@yue.localnetwork \
--to=nao.aota@gmail.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).