From: Andreas Seltenreich <andreas+ding@gate450.dyndns.org>
Subject: Re: bug in gnus-group-kill-group; smarter gnus-find-method-for-group
Date: Sun, 25 Jun 2006 12:47:13 +0200 [thread overview]
Message-ID: <87fyhttsum.fsf@gate450.dyndns.org> (raw)
In-Reply-To: <87bqsnfsqe.fsf@gate450.dyndns.org>
Andreas Seltenreich writes:
> Any objections to applying it?
I've committed the change to gnus-find-method-for-group to the trunk.
Putting a (debug) in the new code revealed some more places where the
function is called on killed/unknown groups, and the caller didn't
expect an all-new method. So, changing g-f-m-f-g fixes at least the
following bugs:
* gnus-group-secondary-p/gnus-group-foreign-p returning false-negative
when called on unknown/killed groups, as done by
gnus-group-change-level and gnus-group-read-ephemeral-group.
* gnus-server-method-cache corruption when renaming groups (through
gnus-agent-rename-group, but affecting all groups, even if the agent
is disabled).
* gnus-group-name-charset being schizophrenic when
gnus-group-name-charset-method-alist is used (E.g., creating groups
using a different encoding than the one used to access them later).
I've also had to massage gnus-group-server a bit, so that it is up for
the new job in gnus-find-method-for-group.
Btw: Is there a reason gnus-group-server is a defmacro instead of a
defsubst?
regards,
andreas
prev parent reply other threads:[~2006-06-25 10:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 20:59 Andreas Seltenreich
2006-06-25 10:47 ` Andreas Seltenreich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fyhttsum.fsf@gate450.dyndns.org \
--to=andreas+ding@gate450.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).