Gnus development mailing list
 help / color / mirror / Atom feed
From: joao.cachopo@inesc-id.pt (João Cachopo)
Subject: Re: [spam.el] Problem with obtaining the spam score for CRM114
Date: Mon, 17 Apr 2006 10:09:41 +0100	[thread overview]
Message-ID: <87fykc8t62.fsf@nabla.local> (raw)
In-Reply-To: <8764laz9lt.fsf@catnip.gol.com>

Miles Bader <miles@gnu.org> writes:

> joao.cachopo@inesc-id.pt (João Cachopo) writes:
>> +        (cond
>> +         ((eq header 'X-Spam-Status)
> ...
>> +         ;; for CRM checking, it's probably faster to just do the string match
>> +         ((and spam-use-crm114 (string-match "( pR: \\([0-9.-]+\\)" header-content))
>
> Faster to do a string match than eq?!?  Seems unlikely...

Actually, the comment and that part of the code was already in the
original code.

I agree with you that an eq is faster than a string-match when the
string-match can be replaced with an eq.

However, how would you replace the string-match with an eq in this
case?   Note that the value of header-content contains the score
assigned to the article...

I believe that the comment was comparing the string-match with the
gnus-replace-string used in the other cases.

--
João Cachopo




  reply	other threads:[~2006-04-17  9:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-15 11:59 João Cachopo
2006-04-15 23:45 ` Miles Bader
2006-04-17  9:09   ` João Cachopo [this message]
2006-04-18 20:27     ` Ted Zlatanov
2006-04-16 16:31 ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fykc8t62.fsf@nabla.local \
    --to=joao.cachopo@inesc-id.pt \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).