From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/62873 Path: news.gmane.org!not-for-mail From: joao.cachopo@inesc-id.pt (=?iso-8859-1?Q?Jo=E3o?= Cachopo) Newsgroups: gmane.emacs.gnus.general Subject: Re: [spam.el] Problem with obtaining the spam score for CRM114 Date: Mon, 17 Apr 2006 10:09:41 +0100 Organization: Grupo de Inteligencia Artificial, Instituto Superior Tecnico Message-ID: <87fykc8t62.fsf@nabla.local> References: <877j5rvykm.fsf@nabla.local> <8764laz9lt.fsf@catnip.gol.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Trace: sea.gmane.org 1145264907 28800 80.91.229.2 (17 Apr 2006 09:08:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 17 Apr 2006 09:08:27 +0000 (UTC) Original-X-From: ding-owner+m11400@lists.math.uh.edu Mon Apr 17 11:08:23 2006 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FVPiY-0003l4-Il for ding-account@gmane.org; Mon, 17 Apr 2006 11:08:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1FVPiT-0008Sq-00; Mon, 17 Apr 2006 04:08:17 -0500 Original-Received: from nas02.math.uh.edu ([129.7.128.40]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1FVPiJ-0008Sl-00 for ding@lists.math.uh.edu; Mon, 17 Apr 2006 04:08:07 -0500 Original-Received: from quimby.gnus.org ([80.91.224.244]) by nas02.math.uh.edu with esmtp (Exim 4.52) id 1FVPiH-0005Un-Av for ding@lists.math.uh.edu; Mon, 17 Apr 2006 04:08:06 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1FVPiG-0006uO-00 for ; Mon, 17 Apr 2006 11:08:04 +0200 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1FVPiD-0003i1-Ql for ding@gnus.org; Mon, 17 Apr 2006 11:08:02 +0200 Original-Received: from 87-196-199-204.net.novis.pt ([87.196.199.204]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Apr 2006 11:08:01 +0200 Original-Received: from joao.cachopo by 87-196-199-204.net.novis.pt with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 17 Apr 2006 11:08:01 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Lines: 26 Original-X-Complaints-To: usenet@sea.gmane.org X-Gmane-NNTP-Posting-Host: 87-196-199-204.net.novis.pt User-Agent: Gnus/5.110005 (No Gnus v0.5) Emacs/22.0.50 (gnu/linux) X-Personality: inesc Cancel-Lock: sha1:i7JoQ0Rnf5Z2E+gMwGAJF0ILW/0= X-Spam-Score: -2.6 (--) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: news.gmane.org gmane.emacs.gnus.general:62873 Archived-At: Miles Bader writes: > joao.cachopo@inesc-id.pt (Joćo Cachopo) writes: >> + (cond >> + ((eq header 'X-Spam-Status) > ... >> + ;; for CRM checking, it's probably faster to just do the string match >> + ((and spam-use-crm114 (string-match "( pR: \\([0-9.-]+\\)" header-content)) > > Faster to do a string match than eq?!? Seems unlikely... Actually, the comment and that part of the code was already in the original code. I agree with you that an eq is faster than a string-match when the string-match can be replaced with an eq. However, how would you replace the string-match with an eq in this case? Note that the value of header-content contains the score assigned to the article... I believe that the comment was comparing the string-match with the gnus-replace-string used in the other cases. -- Joćo Cachopo