Gnus development mailing list
 help / color / mirror / Atom feed
* C-u G DEL doesn't delete everything
@ 2002-03-12  3:27 Dan Christensen
  2002-03-12 21:35 ` Simon Josefsson
  0 siblings, 1 reply; 3+ messages in thread
From: Dan Christensen @ 2002-03-12  3:27 UTC (permalink / raw)


In the *Group* buffer, when I hit `C-u G DEL' on a group, which is
supposed to delete a group and all of its contents, it doesn't
delete the group from my backups on CD.  Just kidding.  What 
it does miss are the .mrk and .nov files, and I think they
should go.  Also, the groupname~ backup file should probably
be deleted as well.  (On the other hand, I think it is correct
that the .SCORE file remains, since it contains user supplied
data that the user might want to copy to another group.)

-- 
Dan Christensen
jdc+news@uwo.ca



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: C-u G DEL doesn't delete everything
  2002-03-12  3:27 C-u G DEL doesn't delete everything Dan Christensen
@ 2002-03-12 21:35 ` Simon Josefsson
  2002-03-12 22:24   ` Dan Christensen
  0 siblings, 1 reply; 3+ messages in thread
From: Simon Josefsson @ 2002-03-12 21:35 UTC (permalink / raw)


Dan Christensen <jdc+news@uwo.ca> writes:

> In the *Group* buffer, when I hit `C-u G DEL' on a group, which is
> supposed to delete a group and all of its contents, it doesn't
> delete the group from my backups on CD.  Just kidding.  What 
> it does miss are the .mrk and .nov files, and I think they
> should go.

Does this help?  

--- nnfolder.el.~6.38.~	Thu Feb 21 17:43:44 2002
+++ nnfolder.el	Tue Mar 12 22:33:37 2002
@@ -548,11 +548,13 @@
       ()				; Don't delete the articles.
     ;; Delete the file that holds the group.
     (ignore-errors
+      (let ((nov (nnfolder-group-nov-pathname group))
+	    (mrk (nnfolder-group-marks-pathname group)))
       (delete-file (nnfolder-group-pathname group))
-      (when (file-exists-p (nnfolder-group-nov-pathname group))
-	(delete-file (nnfolder-group-nov-pathname group)))
-      (when (file-exists-p (nnfolder-group-marks-pathname group))
-	(delete-file (nnfolder-group-marks-pathname group)))))
+	(when (file-exists-p nov)
+	  (delete-file nov))
+	(when (file-exists-p mrk)
+	  (delete-file mrk)))))
   ;; Remove the group from all structures.
   (setq nnfolder-group-alist
 	(delq (assoc group nnfolder-group-alist) nnfolder-group-alist)


> Also, the groupname~ backup file should probably be deleted as well.

I'm not sure.  It is a backup file for a reason.  What do people think?




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: C-u G DEL doesn't delete everything
  2002-03-12 21:35 ` Simon Josefsson
@ 2002-03-12 22:24   ` Dan Christensen
  0 siblings, 0 replies; 3+ messages in thread
From: Dan Christensen @ 2002-03-12 22:24 UTC (permalink / raw)


Simon Josefsson <jas@extundo.com> writes:

> Dan Christensen <jdc+news@uwo.ca> writes:
>
>> In the *Group* buffer, when I hit `C-u G DEL' on a group, which is
>> supposed to delete a group and all of its contents, it doesn't
>> delete the group from my backups on CD.  Just kidding.  What 
>> it does miss are the .mrk and .nov files, and I think they
>> should go.
>
> Does this help?  

The patch didn't apply for some reason, but applying it manually
make Gnus work.  Thanks!

>> Also, the groupname~ backup file should probably be deleted as well.
>
> I'm not sure.  It is a backup file for a reason.  What do people think?

How about a variable to control this, with values t, nil and 'query?
With the default set to query or nil.

-- 
Dan Christensen
jdc+news@uwo.ca



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-03-12 22:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-03-12  3:27 C-u G DEL doesn't delete everything Dan Christensen
2002-03-12 21:35 ` Simon Josefsson
2002-03-12 22:24   ` Dan Christensen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).