Re: URL button question

["Daniel Pittman" <daniel@danann.net>]

On 29 Jun 2000, Max Froumentin <masmef@bath.ac.uk> wrote:

> Dave Love <d.love@dl.ac.uk> writes:
> 
>> The problem with the new-window-p stuff in your copy is probably
>> fairly obvious.  It wasn't deemed a serious enough bug to be fixed
>> post-20.4.
> 
> Although my knowledge of elisp is very small, I've had a look at
> gnus-art.el and browse-url.el. What happens is that gnus calls
> browse-url with only the url as an argument. browse-url itself calls
> browse-url-netscape with the same arg, so the 'new-window' arg is
> never set.
> 
> The obvious fix is be to have gnus call browse-url with a second
> argument. What I did is replace the call to browse-url in
> gnus-button-alist with 'my-browse-url-new-window' defined as:

Well, I use:

,----
| (defadvice browse-url (around always-do-new-window (url &optional nw) activate)
|   (ad-set-arg 1 t)
|   ad-do-it)
`----

This forces `browse-url' to always open a new window (which I prefer.)

        Daniel

-- 
No story is the same to us after the lapse of time; or rather
we who read it are no longer the same interpreters.
        -- George Eliot