From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/31564 Path: main.gmane.org!not-for-mail From: "Daniel Pittman" Newsgroups: gmane.emacs.gnus.general Subject: Re: URL button question Date: 30 Jun 2000 10:30:14 +1000 Organization: Not today, thank you, Mother. Sender: owner-ding@hpc.uh.edu Message-ID: <87g0pwm2nd.fsf@inanna.danann.net> References: <200006271251.NAA32738@djlvig.dl.ac.uk> <200006281712.SAA00732@djlvig.dl.ac.uk> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035167959 14829 80.91.224.250 (21 Oct 2002 02:39:19 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 02:39:19 +0000 (UTC) Keywords: browse-url Return-Path: Original-Received: from karazm.math.uh.edu (karazm.math.uh.edu [129.7.128.1]) by mailhost.sclp.com (Postfix) with ESMTP id E0524D0574 for ; Thu, 29 Jun 2000 20:33:00 -0400 (EDT) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by karazm.math.uh.edu (8.9.3/8.9.3) with ESMTP id TAC12563; Thu, 29 Jun 2000 19:31:14 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Thu, 29 Jun 2000 19:30:11 -0500 (CDT) Original-Received: from mailhost.sclp.com (postfix@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id TAA24725 for ; Thu, 29 Jun 2000 19:30:00 -0500 (CDT) Original-Received: from fw01.osa.com.au (fw01.osa.com.au [203.6.130.130]) by mailhost.sclp.com (Postfix) with SMTP id 27819D0573 for ; Thu, 29 Jun 2000 20:30:26 -0400 (EDT) Original-Received: (qmail 1118 invoked by uid 0); 30 Jun 2000 00:30:22 -0000 Original-Received: (ofmipd 172.16.33.89); 30 Jun 2000 00:30:00 -0000 Original-Received: (qmail 25488 invoked by uid 0); 30 Jun 2000 00:30:21 -0000 Original-Received: from inanna.osa.com.au (HELO inanna.danann.net) (172.16.33.101) by excalibur.osa.com.au with SMTP; 30 Jun 2000 00:30:21 -0000 Original-Received: by inanna.danann.net (Postfix, from userid 1000) id A663A2806F; Fri, 30 Jun 2000 10:30:14 +1000 (EST) Original-To: ding@gnus.org In-Reply-To: Max Froumentin's message of "29 Jun 2000 16:01:59 +0100" X-Homepage: http://danann.net/ X-spies: Albania Watergate Craig Livingstone encryption FSF NORAD Roswell Delta Force strategic ECHELON Croatian Panama radar NSA BATF Original-Lines: 34 User-Agent: Gnus/5.0807 (Gnus v5.8.7) XEmacs/21.2 (Molpe) Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:31564 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:31564 On 29 Jun 2000, Max Froumentin wrote: > Dave Love writes: > >> The problem with the new-window-p stuff in your copy is probably >> fairly obvious. It wasn't deemed a serious enough bug to be fixed >> post-20.4. > > Although my knowledge of elisp is very small, I've had a look at > gnus-art.el and browse-url.el. What happens is that gnus calls > browse-url with only the url as an argument. browse-url itself calls > browse-url-netscape with the same arg, so the 'new-window' arg is > never set. > > The obvious fix is be to have gnus call browse-url with a second > argument. What I did is replace the call to browse-url in > gnus-button-alist with 'my-browse-url-new-window' defined as: Well, I use: ,---- | (defadvice browse-url (around always-do-new-window (url &optional nw) activate) | (ad-set-arg 1 t) | ad-do-it) `---- This forces `browse-url' to always open a new window (which I prefer.) Daniel -- No story is the same to us after the lapse of time; or rather we who read it are no longer the same interpreters. -- George Eliot