bug#20956: [PATCH] Fix imap message size parsing

bug#20956: [PATCH] Fix imap message size parsing

[Nikolaus Rath]

[-- Attachment #1: Type: text/plain, Size: 537 bytes --]

Package: gnus
Tags: patch

IMAP servers may sent the data items in a FETCH response in arbitrary
order. However, currently Gnus assumes that the UID item is sent before
the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
determine the message size.

The attached patch fixes this issue.

Best,
-Nikolaus

-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: transform_headers.patch --]
[-- Type: text/x-diff, Size: 313 bytes --]

--- nnimap.el.bak1	2015-05-26 19:26:56.646513004 -0700
+++ nnimap.el.bak2	2015-07-01 19:39:26.057089923 -0700
@@ -230,6 +230,7 @@
 				      t)
 		   (match-string 1)))
 	(setq lines nil)
+	(beginning-of-line)
 	(setq size
 	      (and (re-search-forward "RFC822.SIZE \\([0-9]+\\)"
 				      (line-end-position)

Re: bug#20956: [PATCH] Fix imap message size parsing

[Eric Abrahamsen]

Nikolaus Rath <Nikolaus@rath.org> writes:

> Package: gnus
> Tags: patch
>
> IMAP servers may sent the data items in a FETCH response in arbitrary
> order. However, currently Gnus assumes that the UID item is sent before
> the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
> determine the message size.
>
> The attached patch fixes this issue.
>
> Best,
> -Nikolaus

Hi Nikolaus,

Would you please resend the patch using git format-patch, and I'll apply
it? With just this patch file, I'd have to manually re-create the
commit, which would lose your metadata as author. Same for your other
two patches, if you don't mind.

Thanks!
Eric

Re: bug#20956: [PATCH] Fix imap message size parsing

[Nikolaus Rath]

On Jul 06 2015, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
> Nikolaus Rath <Nikolaus@rath.org> writes:
>
>> Package: gnus
>> Tags: patch
>>
>> IMAP servers may sent the data items in a FETCH response in arbitrary
>> order. However, currently Gnus assumes that the UID item is sent before
>> the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
>> determine the message size.
>>
>> The attached patch fixes this issue.
>>
>> Best,
>> -Nikolaus
>
> Hi Nikolaus,
>
> Would you please resend the patch using git format-patch, and I'll apply
> it? With just this patch file, I'd have to manually re-create the
> commit, which would lose your metadata as author. Same for your other
> two patches, if you don't mind.

I just did so. Please let me know if this worked correctly, this is the
first time I've used git.

Best,
-Nikolaus

-- 
GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F
Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F

             »Time flies like an arrow, fruit flies like a Banana.«

Re: bug#20956: [PATCH] Fix imap message size parsing

[Eric Abrahamsen]

Nikolaus Rath <Nikolaus@rath.org> writes:

> On Jul 06 2015, Eric Abrahamsen <eric@ericabrahamsen.net> wrote:
>> Nikolaus Rath <Nikolaus@rath.org> writes:
>>
>>> Package: gnus
>>> Tags: patch
>>>
>>> IMAP servers may sent the data items in a FETCH response in arbitrary
>>> order. However, currently Gnus assumes that the UID item is sent before
>>> the RFC822.SIZE item. If this assumption is wrong, Gnus is unable to
>>> determine the message size.
>>>
>>> The attached patch fixes this issue.
>>>
>>> Best,
>>> -Nikolaus
>>
>> Hi Nikolaus,
>>
>> Would you please resend the patch using git format-patch, and I'll apply
>> it? With just this patch file, I'd have to manually re-create the
>> commit, which would lose your metadata as author. Same for your other
>> two patches, if you don't mind.
>
> I just did so. Please let me know if this worked correctly, this is the
> first time I've used git.

Okay, I've pushed the size parsing fix as 1f1d39c. The other three
patches are quite a bit more complicated, and I'd like to run them
locally for just a few days just to see if anything explodes. Thanks for
your patience with working on the commits.

Katsumi Yamaoka, thanks for fixing up my commit messages, and sorry to
create extra work! I'll keep trying to get these things formatted
correctly...

Eric