* emacs22 fails opening nntp: Symbol's function definition is void: process-type
@ 2011-05-15 16:31 Steinar Bang
2011-05-15 22:58 ` Katsumi Yamaoka
0 siblings, 1 reply; 7+ messages in thread
From: Steinar Bang @ 2011-05-15 16:31 UTC (permalink / raw)
To: ding
Platform:
Ubuntu NE 10.10,
emacs22 22.2-0ubuntu9
git gnus
Recent gnusen fail opening all nntp servers on emacs22
Opening nntp servers fail with the error:
Symbol's function definition is void: process-type
Here's the full error message from *Messages*
Warning: Unable to open server nntp+dough.gmane.org due to: Symbol's function definition is void: process-type; Unable to open server nntp+news.eclipse.org due to: Symbol's function definition is void: process-type; Unable to open server nntp+news.opera.com due to: Symbol's function definition is void: process-type; Unable to open server nntp+news.gmane.org due to: Symbol's function definition is void: process-type; Unable to open server nntp+news due to: Symbol's function definition is void: process-type
Mark set
I did git bisect between
ORIG_HEAD: 444ee1f3a74bad82440f49a73e3140a0cf247e23
HEAD: bd74ba3e89556c0194b3ab3051226d3d8cb16cf0
Full rebuild with
(cd ~/git/gnus; make clean; make; cd lisp; make tags)
and start of gnus in a fresh emacs after each git bisect good/bad.
And git bisect points the finger at the following commit, which from its
description, doesn't sound related at all:
sb@aa1steinar:~/git/gnus$ git bisect good
387b3ba7d4c42771d541085cddfc02ebf276521d is the first bad commit
commit 387b3ba7d4c42771d541085cddfc02ebf276521d
Author: Katsumi Yamaoka <yamaoka@jpl.org>
Date: Tue May 10 03:10:49 2011 +0000
shr.el (shr-put-image-function): New variable.
(shr-image-fetched, shr-image-displayer, shr-tag-img): Funcall it.
(shr-put-image): Return scaled image.
gnus-art.el (gnus-shr-put-image): New function.
(gnus-article-prepare-display): Bind shr-put-image-function to it.
gnus-html.el (gnus-html-wash-images): Register scaled images, not original ones, as deletable.
:040000 040000 35f683e944f546382650c488218e8c895ae6cd5a 9fa356164b9f438eb9bbdbb5ee831098230889ef M lisp
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type
2011-05-15 16:31 emacs22 fails opening nntp: Symbol's function definition is void: process-type Steinar Bang
@ 2011-05-15 22:58 ` Katsumi Yamaoka
2011-05-16 6:38 ` Steinar Bang
0 siblings, 1 reply; 7+ messages in thread
From: Katsumi Yamaoka @ 2011-05-15 22:58 UTC (permalink / raw)
To: ding
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
Steinar Bang wrote:
> Platform:
> Ubuntu NE 10.10,
> emacs22 22.2-0ubuntu9
> git gnus
> Recent gnusen fail opening all nntp servers on emacs22
> Opening nntp servers fail with the error:
> Symbol's function definition is void: process-type
Currently I don't have Emacs 22 (in the office), but a workaround
(or a lasting solution?) seems to be:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 259 bytes --]
--- nntp.el~ 2011-05-09 22:22:01.078125000 +0000
+++ nntp.el 2011-05-15 22:54:46.005653400 +0000
@@ -1365,2 +1365,3 @@
(when (and (fboundp 'set-network-process-option)
+ (fboundp 'process-type)
(eq (process-type process) 'network))
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type
2011-05-15 22:58 ` Katsumi Yamaoka
@ 2011-05-16 6:38 ` Steinar Bang
2011-05-16 7:08 ` Katsumi Yamaoka
0 siblings, 1 reply; 7+ messages in thread
From: Steinar Bang @ 2011-05-16 6:38 UTC (permalink / raw)
To: ding
>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:
> Currently I don't have Emacs 22 (in the office), but a workaround
> (or a lasting solution?) seems to be:
> --- nntp.el~ 2011-05-09 22:22:01.078125000 +0000
> +++ nntp.el 2011-05-15 22:54:46.005653400 +0000
> @@ -1365,2 +1365,3 @@
> (when (and (fboundp 'set-network-process-option)
> + (fboundp 'process-type)
> (eq (process-type process) 'network))
I can verify that this patch works on emacs22.
(in fact I'm posting from gnus HEAD with this patch applied, right
now...:-) )
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type
2011-05-16 6:38 ` Steinar Bang
@ 2011-05-16 7:08 ` Katsumi Yamaoka
2011-05-16 8:34 ` David Engster
0 siblings, 1 reply; 7+ messages in thread
From: Katsumi Yamaoka @ 2011-05-16 7:08 UTC (permalink / raw)
To: ding
Steinar Bang wrote:
>>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:
>> Currently I don't have Emacs 22 (in the office), but a workaround
>> (or a lasting solution?) seems to be:
>> --- nntp.el~ 2011-05-09 22:22:01.078125000 +0000
>> +++ nntp.el 2011-05-15 22:54:46.005653400 +0000
>> @@ -1365,2 +1365,3 @@
>> (when (and (fboundp 'set-network-process-option)
>> + (fboundp 'process-type)
>> (eq (process-type process) 'network))
> I can verify that this patch works on emacs22.
> (in fact I'm posting from gnus HEAD with this patch applied, right
> now...:-) )
Ok. I'll install it after verifying with all Emacsen that Gnus
supports, later.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type
2011-05-16 7:08 ` Katsumi Yamaoka
@ 2011-05-16 8:34 ` David Engster
2011-05-16 14:46 ` Katsumi Yamaoka
0 siblings, 1 reply; 7+ messages in thread
From: David Engster @ 2011-05-16 8:34 UTC (permalink / raw)
To: Katsumi Yamaoka; +Cc: ding
Katsumi Yamaoka writes:
> Steinar Bang wrote:
>>>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:
>
>>> Currently I don't have Emacs 22 (in the office), but a workaround
>>> (or a lasting solution?) seems to be:
>
>>> --- nntp.el~ 2011-05-09 22:22:01.078125000 +0000
>>> +++ nntp.el 2011-05-15 22:54:46.005653400 +0000
>>> @@ -1365,2 +1365,3 @@
>>> (when (and (fboundp 'set-network-process-option)
>>> + (fboundp 'process-type)
>>> (eq (process-type process) 'network))
>
>> I can verify that this patch works on emacs22.
>> (in fact I'm posting from gnus HEAD with this patch applied, right
>> now...:-) )
>
> Ok. I'll install it after verifying with all Emacsen that Gnus
> supports, later.
So the buildbot was right after all... The patch should be fine for all
Emacsen. Could you please also remove the bogus process-type definition
for Emacs22 from lpath.el:
index 70e3bc5..2317d78 100644
--- a/lisp/lpath.el
+++ b/lisp/lpath.el
@@ -35,7 +35,7 @@
epg-check-configuration find-coding-system frame-device gnutls-negotiate
libxml-parse-html-region recenter-top-bottom rmail-swap-buffers-maybe
shr-insert-document w3-do-setup w3-parse-buffer w3-prepare-buffer
- w3-region w3m-detect-meta-charset w3m-region process-type))
+ w3-region w3m-detect-meta-charset w3m-region))
(maybe-bind
'(epa-file-encrypt-to w3m-link-map))))
Thanks,
David
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type
2011-05-16 8:34 ` David Engster
@ 2011-05-16 14:46 ` Katsumi Yamaoka
2011-05-21 8:21 ` Steinar Bang
0 siblings, 1 reply; 7+ messages in thread
From: Katsumi Yamaoka @ 2011-05-16 14:46 UTC (permalink / raw)
To: ding
David Engster <deng@randomsample.de> wrote:
> Could you please also remove the bogus process-type definition
> for Emacs22 from lpath.el:
[...]
Done.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: emacs22 fails opening nntp: Symbol's function definition is void: process-type
2011-05-16 14:46 ` Katsumi Yamaoka
@ 2011-05-21 8:21 ` Steinar Bang
0 siblings, 0 replies; 7+ messages in thread
From: Steinar Bang @ 2011-05-21 8:21 UTC (permalink / raw)
To: ding
>>>>> Katsumi Yamaoka <yamaoka@jpl.org>:
> David Engster <deng@randomsample.de> wrote:
>> Could you please also remove the bogus process-type definition
>> for Emacs22 from lpath.el:
> [...]
> Done.
I can verify that emacs22 works fine on the current gnus git master
branch HEAD, without the patch, I tried out earlier in the thread.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-05-21 8:21 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-15 16:31 emacs22 fails opening nntp: Symbol's function definition is void: process-type Steinar Bang
2011-05-15 22:58 ` Katsumi Yamaoka
2011-05-16 6:38 ` Steinar Bang
2011-05-16 7:08 ` Katsumi Yamaoka
2011-05-16 8:34 ` David Engster
2011-05-16 14:46 ` Katsumi Yamaoka
2011-05-21 8:21 ` Steinar Bang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).