Re: auth-source.el and eieio

[Ted Zlatanov <tzz@lifelogs.com>]

[-- Attachment #1: Type: text/plain, Size: 850 bytes --]

On Mon, 14 Feb 2011 16:47:18 +0100 Michael Albinus <michael.albinus@gmx.de> wrote: 

MA> Ted Zlatanov <tzz@lifelogs.com> writes:
>> It's all autoloaded, so the user will get an error when he searches.  I
>> can do an assert in `auth-source-secrets-search' to fail early or fail
>> even earlier in `auth-source-backend-parse'.  WDYT?

MA> If there are no compilation errors, I believe it is OK to fail with a
MA> meaningful message.

MA> However, it gives the burden to the user to initialize auth-sources
MA> depending on availability of secrets.el. So maybe it is more convenient
MA> to ignore :secrets entries in such a case, raising a warning (with
MA> confirmation to continue).

Something like this, except using another warning facility besides
`auth-source-do-debug'?  I assume (featurep 'secrets) will work even
if autoloading is used.

Ted


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: auth-nosecrets.patch --]
[-- Type: text/x-diff, Size: 1129 bytes --]

diff --git a/lisp/auth-source.el b/lisp/auth-source.el
index 0692dbb..6a2e500 100644
--- a/lisp/auth-source.el
+++ b/lisp/auth-source.el
@@ -312,12 +312,19 @@ If the value is not a list, symmetric encryption will be used."
          (setq source (or (secrets-get-alias (symbol-name source))
                           "Login")))
 
-       (auth-source-backend
-        (format "Secrets API (%s)" source)
-        :source source
-        :type 'secrets
-        :search-function 'auth-source-secrets-search
-        :create-function 'auth-source-secrets-create)))
+       (if (featurep 'secrets)
+           (auth-source-backend
+            (format "Secrets API (%s)" source)
+            :source source
+            :type 'secrets
+            :search-function 'auth-source-secrets-search
+            :create-function 'auth-source-secrets-create)
+         (auth-source-do-debug
+          "auth-source-backend-parse: no Secrets API, ignoring spec: %S" entry)
+         (auth-source-backend
+          (format "Ignored Secrets API (%s)" source)
+          :source ""
+          :type 'ignore))))
 
     ;; none of them
     (t