Gnus development mailing list
 help / color / mirror / Atom feed
From: Andrew Cohen <cohen@andy.bu.edu>
To: ding@gnus.org
Subject: carriage-returns and nnimap
Date: Fri, 17 Dec 2010 07:58:29 -0500	[thread overview]
Message-ID: <87hbech7yi.fsf@andy.bu.edu> (raw)

I had noticed that gnus-registry-split-fancy-with-parent had stopped
working with "sender" splitting. I finally decided to track this down.

Looking at the registry I noticed that the "sender" and "subject" fields
(and some others) had a spurious space at the end of them (which is
wrong), while an old copy of the registry (from months ago) has no such
spaces (which is right). I can't pinpoint exactly when this changed so
I'm not sure of the exact cause.

Tracing this a bit I found that 'gnus-get-newsgroup-headers translates
\r into spaces, so I suspect that this is where the extra spaces are
coming from. I added a call to 'nnheader-remove-cr-followed-by-lf in
'gnus-get-newsgroup-headers just before the \r->space translation and it
seems to fix the problem. 

I didn't want to just push this in case I've missed something. The whole
carriage-return thing in nnimap confuses me.

Regards,
Andy


diff --git a/lisp/gnus-sum.el b/lisp/gnus-sum.el
index ceaa014..dbd25ca 100644
--- a/lisp/gnus-sum.el
+++ b/lisp/gnus-sum.el
@@ -6262,6 +6262,7 @@ The resulting hash table is returned, or nil if no Xrefs were found."
                               gnus-newsgroup-ignored-charsets)))
     (with-current-buffer nntp-server-buffer
       ;; Translate all TAB characters into SPACE characters.
+      (nnheader-remove-cr-followed-by-lf)
       (subst-char-in-region (point-min) (point-max) ?\t ?  t)
       (subst-char-in-region (point-min) (point-max) ?\r ?  t)
       (ietf-drums-unfold-fws)




             reply	other threads:[~2010-12-17 12:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-17 12:58 Andrew Cohen [this message]
2010-12-17 14:09 ` Ted Zlatanov
2010-12-17 14:18   ` Andrew Cohen
2010-12-17 15:36     ` Ted Zlatanov
2010-12-17 16:17     ` Lars Magne Ingebrigtsen
2010-12-17 16:16 ` Lars Magne Ingebrigtsen
2010-12-17 16:25   ` Andrew Cohen
2010-12-17 16:33     ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hbech7yi.fsf@andy.bu.edu \
    --to=cohen@andy.bu.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).