Re: Error in `mail-source-bind' when fetching mail

Re: Error in `mail-source-bind' when fetching mail

[Ted Zlatanov]

On Sat, 26 Apr 2008 07:52:26 +0200 Christoph Conrad <christoph.conrad@gmx.de> wrote: 

CC> mail-source-fetch-file -> mail-source-bind

CC> => Mail source (file :path /var/spool/mail/cc :plugged t) error (user).  Continue? (y or n) 

CC> Backtrace see below. Obviously "user" and "password" in the let form in
CC> mail-source-bind can not determine the values with
CC> auth-source-user-or-password and try to use the variables user and
CC> password. This variables are not defined in that scope.

TZ> On Thu, 28 Feb 2008 09:38:21 -0600 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> I've now set up mail-source-bind to always check auth-sources (through
TZ> auth-source.el) for IMAP, POP, and everything else mail-source.el
TZ> supports.  The user name and password will override any others that have
TZ> been set up; if this is incorrect I can rearrange the priority but I
TZ> think it's sensible and will make it easier for users to migrate to an
TZ> authinfo-centered setup.

Sometimes user and password are set (due to the macro that extracts them
from the mail source).  In fact they were for me, that's why I didn't
notice the bug.  I made a fix that should do the right thing; it may be
better to do it with macro facilities but I wanted to get the fix out
ASAP and I did it the simplest way possible (with boundp, symbol-value,
and unintern).

Thanks
Ted

Re: Error in `mail-source-bind' when fetching mail

[Christoph Conrad]

Hi Ted,

> In fact they were for me, that's why I didn't notice the bug.

I suspected that. Works again for me - thanks!

With kind regards,
Christoph

Re: Error in `mail-source-bind' when fetching mail

[Andreas Schwab]

Ted Zlatanov <tzz@lifelogs.com> writes:

> I made a fix that should do the right thing;

Unfortunately not.

Andreas.

2008-04-28  Andreas Schwab  <schwab@suse.de>

	* mail-source.el (mail-source-bind): Fix password vs. user mixup.

--- lisp/mail-source.el.~7.35.~	2008-04-28 11:49:11.000000000 +0200
+++ lisp/mail-source.el	2008-04-28 12:06:45.000000000 +0200
@@ -466,7 +466,7 @@ the `mail-source-keyword-map' variable."
 	      ;; this is "host" in auth-sources
 	      (if (boundp 'server) (symbol-value 'server) "")
 	      ',(car type-source))
-	     (when (boundp 'user) (symbol-value 'user)))))
+	     (when (boundp 'password) (symbol-value 'password)))))
        (unless user
 	 (unintern 'user))
        (unless password

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Error in `mail-source-bind' when fetching mail

[Andreas Schwab]

Ted Zlatanov <tzz@lifelogs.com> writes:

> I made a fix that should do the right thing; it may be
> better to do it with macro facilities but I wanted to get the fix out
> ASAP and I did it the simplest way possible (with boundp, symbol-value,
> and unintern).

The use of unintern is broken.  You want makunbound instead.

Andreas.

2008-04-28  Andreas Schwab  <schwab@suse.de>

	* mail-source.el (mail-source-bind): Use makunbound instead of
	unintern.

--- lisp/mail-source.el.~7.35.~	2008-04-28 11:49:11.000000000 +0200
+++ lisp/mail-source.el	2008-04-28 12:21:22.000000000 +0200
@@ -466,9 +466,9 @@ the `mail-source-keyword-map' variable."
 	      ',(car type-source))
 	     (when (boundp 'password) (symbol-value 'password)))))
        (unless user
-	 (unintern 'user))
+	 (makunbound 'user))
        (unless password
-	 (unintern 'password))
+	 (makunbound 'password))
        ,@body)))
 
 (put 'mail-source-bind 'lisp-indent-function 1)

-- 
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux Products GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

Re: Error in `mail-source-bind' when fetching mail

[Ted Zlatanov]

On Mon, 28 Apr 2008 12:28:13 +0200 Andreas Schwab <schwab@suse.de> wrote: 

AS> Ted Zlatanov <tzz@lifelogs.com> writes:
>> I made a fix that should do the right thing; it may be
>> better to do it with macro facilities but I wanted to get the fix out
>> ASAP and I did it the simplest way possible (with boundp, symbol-value,
>> and unintern).

AS> The use of unintern is broken.  You want makunbound instead.

Thanks.  I moved the code out of the macro altogether, I didn't think it
was clear anyhow, and it was much harder to debug.  The restructured
version is much cleaner IMO, and only calls the auth-source functions if
the keywords actually show up.  Please let me know if you find other
problems or issues.

As an aside, I kept making fixes and re-evaluating the defmacro but it
wouldn't take effect.  I guess I don't know defmacro well enough, but I
didn't expect that from the documentation (I usually only use the
backquote macros).  It was a bit annoying until I finally realized what
was happening.

Ted

Re: Error in `mail-source-bind' when fetching mail

[Cezar Halmagean]

Ted Zlatanov <tzz@lifelogs.com> writes:

> Thanks.  I moved the code out of the macro altogether, I didn't think it
> was clear anyhow, and it was much harder to debug.  The restructured
> version is much cleaner IMO, and only calls the auth-source functions if
> the keywords actually show up.  Please let me know if you find other
> problems or issues.
>
> As an aside, I kept making fixes and re-evaluating the defmacro but it
> wouldn't take effect.  I guess I don't know defmacro well enough, but I
> didn't expect that from the documentation (I usually only use the
> backquote macros).  It was a bit annoying until I finally realized what
> was happening.
>
> Ted

I still get the same error message with the latest version of emacs from
cvs.

Gnus v5.13

GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of
2008-04-28

Mail source (maildir :path /home/cezar/Mail) error (user).  Continue?
(yes or no)


Regards,
Cezar

Re: Error in `mail-source-bind' when fetching mail

[Ted Zlatanov]

On Mon, 28 Apr 2008 20:26:10 -0700 Cezar Halmagean <cezar@mixandgo.ro> wrote: 

CH> Ted Zlatanov <tzz@lifelogs.com> writes:
>> Thanks.  I moved the code out of the macro altogether, I didn't think it
>> was clear anyhow, and it was much harder to debug.  The restructured
>> version is much cleaner IMO, and only calls the auth-source functions if
>> the keywords actually show up.  Please let me know if you find other
>> problems or issues.
>> 
>> As an aside, I kept making fixes and re-evaluating the defmacro but it
>> wouldn't take effect.  I guess I don't know defmacro well enough, but I
>> didn't expect that from the documentation (I usually only use the
>> backquote macros).  It was a bit annoying until I finally realized what
>> was happening.
>> 
>> Ted

CH> I still get the same error message with the latest version of emacs from
CH> cvs.

CH> Gnus v5.13

CH> GNU Emacs 23.0.60.1 (i686-pc-linux-gnu, GTK+ Version 2.12.9) of
CH> 2008-04-28

CH> Mail source (maildir :path /home/cezar/Mail) error (user).  Continue?
CH> (yes or no)

Maybe it wasn't synchronized yet.  I don't do the synchronization into
Emacs manually, but it has happened as of this morning (2008-04-30 at
09:30 CST).  Update from CVS, exit Emacs altogether (re-evaluating the
mail-source.el macros doesn't do it), and see if the problem happens
again.

Sorry for the inconvenience.

Ted

Re: Error in `mail-source-bind' when fetching mail

[Reiner Steib]

Hi Ted,

has this been fixed?  If not, could you look into this, please?

Bye, Reiner.

On Sat, Apr 26 2008, Christoph Conrad wrote:

> No Gnus v0.9
> GNU Emacs 23.0.60.2 (i686-pc-linux-gnu, GTK+ Version 2.12.9)
>  of 2008-04-24 on brabbelbox
> 200 news.gmane.org InterNetNews NNRP server INN 2.4.1 ready (posting ok).
>
> mail-source-fetch-file -> mail-source-bind
>
> => Mail source (file :path /var/spool/mail/cc :plugged t) error (user).  Continue? (y or n) 
>
> Backtrace see below. Obviously "user" and "password" in the let form in
> mail-source-bind can not determine the values with
> auth-source-user-or-password and try to use the variables user and
> password. This variables are not defined in that scope.
>
> My workaround is setting:
>
>      (let ((user (or
> 		  (auth-source-user-or-password
> 		   "login"
> 		   server	      ; this is "host" in auth-sources
> 		   ',(car type-source))
> 		  "")) ;; -cco-, was: user
> 	   (password (or
> 		      (auth-source-user-or-password
> 		       "password"
> 		       server	      ; this is "host" in auth-sources
> 		       ',(car type-source))
> 		      ""))) ;; -cco-, was: password
>
> Then fetching mail works for me again, but it's clearly a workaround.
>
> The suspected change is:
>
> date: 2008/04/25 18:42:18;  author: tzz;  state: Exp;  lines: +24 -4
> * mail-source.el: Load auth-source.el.
> (mail-source-bind): Add comments.  Call auth-source-user-or-password to
> get user name or password, if auth-sources is set up.
>
> With kind regards,
> Christoph
>
> Debugger entered--Lisp error: (void-variable user)
> (or (auth-source-user-or-password "login" server 'file) user)
>   (let ((user ...) (password ...)) (mail-source-run-script prescript (format-spec-make 116 mail-source-crash-box) prescript-delay) (let (...) (if ... ... 0)))
>   (let* ((path nil) (postscript nil) (prescript-delay nil) (prescript nil)) (mail-source-set-1 source) (let (... ...) (mail-source-run-script prescript ... prescript-delay) (let ... ...)))
>   (mail-source-bind (file source) (mail-source-run-script prescript (format-spec-make 116 mail-source-crash-box) prescript-delay) (let (...) (if ... ... 0)))
>   mail-source-fetch-file((file :path "/var/spool/mail/cc" :plugged t) #[(file orig-file) "Ã\bÄÅ	†.\0\b\nš?….\0Æ\nÇ\"È%‡" [file in-group orig-file nnmail-split-incoming nnml-save-mail nil nnmail-get-split-group (file :path "/var/spool/mail/cc" :plugged t) nnml-active-number] 7])
>   mail-source-fetch((file :path "/var/spool/mail/cc" :plugged t) #[(file orig-file) "Ã\bÄÅ	†.\0\b\nš?….\0Æ\nÇ\"È%‡" [file in-group orig-file nnmail-split-incoming nnml-save-mail nil nnmail-get-split-group (file :path "/var/spool/mail/cc" :plugged t) nnml-active-number] 7])
>   nnmail-get-new-mail-1(nnml nnml-save-nov "~/Mail/" "Incoming" nil nil)
>   nnmail-get-new-mail(nnml nnml-save-nov "~/Mail/" "Incoming")
>   nnml-request-scan("Incoming" "")
>   gnus-request-scan("Incoming" (nnml ""))
>   gnus-activate-group("Incoming" scan nil (nnml ""))
>   gnus-group-get-new-news-this-group(nil)
>   gnus-topic-get-new-news-this-topic(nil)
>   call-interactively(gnus-topic-get-new-news-this-topic nil nil)