Gnus development mailing list
 help / color / mirror / Atom feed
From: Christian Plate <cplate@web.de>
To: ding@gnus.org
Subject: nnmaildir: Performance in nnmaildir-request-update-info
Date: Sat, 01 Dec 2007 23:29:49 +0100	[thread overview]
Message-ID: <87hcj2kq02.fsf@43289468.dialin.t-online.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

Hello,

I found a performance problem in nnmaildir and think i solved it.

Problem: I have various maildirs with >9000 mails. If i read a new
mail, quit the group and then hit "gnus-group-get-new-news" in the
Groups-buffer, it takes 30s till i get an updated Groups-buffer.

Profiling shows that nnmaildir-request-update-info is to
blame. gnus-add-to-range is called for every single article which is
found in the markdirs.

I changed the implementation to collect all article numbers in a list
and then call gnus-add-to-range only once with that list of article
numbers.

This causes a huge performance gain on my machine. For my big
mailboxes now the time for gnus-group-get-new-news is only 0.3s.

Unfortunately I don't have a working installation of latest gnus
sources. I used:
GNU Emacs 22.1.1 (i686-pc-linux-gnu, GTK+ Version 2.6.4) of 2007-06-09 on rhada

Therefore I attached a tar file containing my patch and two dirs: "old"
contains the version i based my work on. "new" contains my patch.

Please take a look at it. For me this delay was a major flaw in my
daily work with nnmaildir. It would be great if a change like this
could be integrated into gnus/emacs.

Thanks for your attention,
  Christian


[-- Attachment #2: patch-performance-nnmaildir-request-update-info.tar.gz --]
[-- Type: application/octet-stream, Size: 27508 bytes --]

             reply	other threads:[~2007-12-01 22:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-01 22:29 Christian Plate [this message]
2007-12-02  0:32 ` Paul Jarc
2007-12-02 11:51   ` Christian Plate
2007-12-06  5:51     ` Paul Jarc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hcj2kq02.fsf@43289468.dialin.t-online.de \
    --to=cplate@web.de \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).