From: Dan Christensen <jdc@uwo.ca>
Subject: Re: (display . [not expire]) and (gnus-show-threads nil)
Date: Tue, 06 Jul 2004 10:52:32 -0400 [thread overview]
Message-ID: <87hdsl89xr.fsf@uwo.ca> (raw)
In-Reply-To: <m3hdugk2ac.fsf@quimbies.gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 16 May 2004 14:02:51 +0200")
[-- Attachment #1: Type: text/plain, Size: 848 bytes --]
Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
> Dan Christensen <jdc@uwo.ca> writes:
>
>> In my spam group, I want to hide expirable articles, so I set
>> (display. [not expire]) in my group parameters. This works find with
>> a threaded display. But I want to sort the articles, not the threads,
>> by spamminess, so I set (gnus-show-threads nil). But when I do the
>> latter, I see the expirable articles now. Any idea what's going on?
>
> It's a bug, I guess. The same thing happens with dormant articles --
> they're only dormant if they're in a threaded display.
...
> Anybody object to changing the code so that unthreaded display hides
> dormants and respects `display'?
It's been six weeks and there weren't any objections. Could someone
apply the following patch? (I have copyright assignment papers on file.)
Thanks,
Dan
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-sum.el.patch --]
[-- Type: text/x-patch, Size: 840 bytes --]
--- gnus-sum.el.orig 2004-07-06 10:32:35.000000000 -0400
+++ gnus-sum.el 2004-07-06 10:38:29.000000000 -0400
@@ -3602,16 +3602,10 @@
(when gnus-build-sparse-threads
(gnus-build-sparse-threads))
;; Find the initial limit.
- (if gnus-show-threads
- (if show-all
- (let ((gnus-newsgroup-dormant nil))
- (gnus-summary-initial-limit show-all))
- (gnus-summary-initial-limit show-all))
- ;; When unthreaded, all articles are always shown.
- (setq gnus-newsgroup-limit
- (mapcar
- (lambda (header) (mail-header-number header))
- gnus-newsgroup-headers)))
+ (if show-all
+ (let ((gnus-newsgroup-dormant nil))
+ (gnus-summary-initial-limit show-all))
+ (gnus-summary-initial-limit show-all))
;; Generate the summary buffer.
(unless no-display
(gnus-summary-prepare))
next prev parent reply other threads:[~2004-07-06 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-27 19:15 Dan Christensen
2004-05-16 12:02 ` Lars Magne Ingebrigtsen
2004-07-06 14:52 ` Dan Christensen [this message]
2004-07-06 23:12 ` Katsumi Yamaoka
2004-07-07 2:19 ` Dan Christensen
2004-07-07 2:36 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hdsl89xr.fsf@uwo.ca \
--to=jdc@uwo.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).