From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/58066 Path: main.gmane.org!not-for-mail From: Dan Christensen Newsgroups: gmane.emacs.gnus.general Subject: Re: (display . [not expire]) and (gnus-show-threads nil) Date: Tue, 06 Jul 2004 10:52:32 -0400 Sender: ding-owner@lists.math.uh.edu Message-ID: <87hdsl89xr.fsf@uwo.ca> References: <873c6pw7tj.fsf@uwo.ca> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1089125714 30323 80.91.224.253 (6 Jul 2004 14:55:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Jul 2004 14:55:14 +0000 (UTC) Original-X-From: ding-owner+M6607@lists.math.uh.edu Tue Jul 06 16:55:06 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BhrLe-0003Ja-00 for ; Tue, 06 Jul 2004 16:55:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1BhrJW-0002cS-00; Tue, 06 Jul 2004 09:52:54 -0500 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1BhrJN-0002cK-00 for ding@lists.math.uh.edu; Tue, 06 Jul 2004 09:52:45 -0500 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1BhrJN-0003rU-A1 for ding@lists.math.uh.edu; Tue, 06 Jul 2004 09:52:45 -0500 Original-Received: from pony.its.uwo.ca (pony.its.uwo.ca [129.100.2.63]) by justine.libertine.org (Postfix) with ESMTP id 3618C3A003E for ; Tue, 6 Jul 2004 09:52:44 -0500 (CDT) Original-Received: from spork.its.uwo.ca (ride.its.uwo.ca [10.10.10.10]) by pony.its.uwo.ca (8.12.10/8.12.10) with ESMTP id i66Eqfbu015497 for ; Tue, 6 Jul 2004 10:52:42 -0400 (EDT) Original-Received: from localhost (jdc.math.uwo.ca [129.100.75.77]) by spork.its.uwo.ca (8.12.10/8.12.10) with ESMTP id i66EqYlF022724 for ; Tue, 6 Jul 2004 10:52:34 -0400 Original-Received: from jdc by localhost with local (Exim 3.36 #1 (Debian)) id 1BhrJA-0000RE-00; Tue, 06 Jul 2004 10:52:32 -0400 Original-To: ding@gnus.org In-Reply-To: (Lars Magne Ingebrigtsen's message of "Sun, 16 May 2004 14:02:51 +0200") Mail-Copies-To: nobody User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) X-Scanned-By: MIMEDefang 2.39 Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:58066 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:58066 --=-=-= Lars Magne Ingebrigtsen writes: > Dan Christensen writes: > >> In my spam group, I want to hide expirable articles, so I set >> (display. [not expire]) in my group parameters. This works find with >> a threaded display. But I want to sort the articles, not the threads, >> by spamminess, so I set (gnus-show-threads nil). But when I do the >> latter, I see the expirable articles now. Any idea what's going on? > > It's a bug, I guess. The same thing happens with dormant articles -- > they're only dormant if they're in a threaded display. ... > Anybody object to changing the code so that unthreaded display hides > dormants and respects `display'? It's been six weeks and there weren't any objections. Could someone apply the following patch? (I have copyright assignment papers on file.) Thanks, Dan --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=gnus-sum.el.patch --- gnus-sum.el.orig 2004-07-06 10:32:35.000000000 -0400 +++ gnus-sum.el 2004-07-06 10:38:29.000000000 -0400 @@ -3602,16 +3602,10 @@ (when gnus-build-sparse-threads (gnus-build-sparse-threads)) ;; Find the initial limit. - (if gnus-show-threads - (if show-all - (let ((gnus-newsgroup-dormant nil)) - (gnus-summary-initial-limit show-all)) - (gnus-summary-initial-limit show-all)) - ;; When unthreaded, all articles are always shown. - (setq gnus-newsgroup-limit - (mapcar - (lambda (header) (mail-header-number header)) - gnus-newsgroup-headers))) + (if show-all + (let ((gnus-newsgroup-dormant nil)) + (gnus-summary-initial-limit show-all)) + (gnus-summary-initial-limit show-all)) ;; Generate the summary buffer. (unless no-display (gnus-summary-prepare)) --=-=-=--