From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/56737 Path: main.gmane.org!not-for-mail From: Stefan Wiens Newsgroups: gmane.emacs.gnus.general Subject: Re: In gnus-sum.el: Incorrect handling of sparse articles Date: Mon, 15 Mar 2004 11:50:12 +0100 Organization: lieber nicht Sender: ding-owner@lists.math.uh.edu Message-ID: <87hdwqe657.fsf@xenon.eswe.dyndns.org> References: <871xnvh94z.fsf@xenon.eswe.dyndns.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1079348015 18656 80.91.224.253 (15 Mar 2004 10:53:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 15 Mar 2004 10:53:35 +0000 (UTC) Original-X-From: ding-owner+M5276@lists.math.uh.edu Mon Mar 15 11:53:27 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2pip-0005Qs-00 for ; Mon, 15 Mar 2004 11:53:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1B2phj-0007Wz-00; Mon, 15 Mar 2004 04:52:19 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1B2phZ-0007Wr-00 for ding@lists.math.uh.edu; Mon, 15 Mar 2004 04:52:09 -0600 Original-Received: from quimby.gnus.org (quimby.gnus.org [80.91.224.244]) by justine.libertine.org (Postfix) with ESMTP id B5E473A005D for ; Mon, 15 Mar 2004 04:52:07 -0600 (CST) Original-Received: from news by quimby.gnus.org with local (Exim 3.35 #1 (Debian)) id 1B2phX-0002yT-00 for ; Mon, 15 Mar 2004 11:52:07 +0100 Original-To: ding@gnus.org Original-Path: xenon.eswe.dyndns.org!nobody Original-Newsgroups: gnus.ding Original-Lines: 36 Original-NNTP-Posting-Host: 1cust65.tnt6.hnr2.deu.da.uu.net Original-X-Trace: quimby.gnus.org 1079347927 11436 149.225.148.65 (15 Mar 2004 10:52:07 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: Mon, 15 Mar 2004 10:52:07 +0000 (UTC) User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.2 (gnu/linux) Cancel-Lock: sha1:tQXs5SVuifrvhaWRQIawd5LkKT0= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:56737 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:56737 > in gnus-sum.el, function gnus-read-header: > > ;; If this is a sparse article, we have to nix out its > ;; previous entry in the thread hashtb. > (when (and header > (gnus-summary-article-sparse-p (mail-header-number header))) > (let* ((parent (gnus-parent-id (mail-header-references header))) > (thread (and parent (gnus-id-to-thread parent)))) > (when thread > (delq (assq header thread) thread)))) That code was introduced on Nov 24, 1997 (no CVS comment). The damage gnus-read-header does to gnus-newsgroup-dependencies was probably exposed by: ,----[ ChangeLog ] | | 2002-02-21 ShengHuo ZHU | [...] | * gnus-sum.el (gnus-dependencies-add-header): If replaced, don't | rebuild. | (gnus-summary-edit-article-done): Gnus-get-newsgroup-headers takes | nil as dependencies as well. `---- Next day, on Feb 22, 2002, first reporting of `This is a pseudo-article' errors after upgrading. (gnus.ding ) > I am currently testing with the offending code (cited above) commented > out, and everything seems to work fine. Still works. IMHO the code section should simply be removed. Stefan