Gnus development mailing list
 help / color / mirror / Atom feed
From: "Matt Armstrong" <matt+dated+1007413744.f977c8@lickey.com>
Subject: [PATCH] Bug fix for mail-followup-to
Date: Sat, 03 Nov 2001 14:09:01 -0700	[thread overview]
Message-ID: <87hesbef4i.fsf@squeaker.lickey.com> (raw)

If you trace through message-send-mail, you'll see that the second
call to message-generate-headers -- the one that adds the
Mail-Followup-To: header -- erases the previously generated Date:,
Message-Id: and Lines: headers.  This is bad because only the Lines:
header gets subsequently generated, so the Message-Id: and Date:
headers must be inserted by the MTA (sendmail, etc.).

This patch fixes that:

Index: lisp/ChangeLog
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/ChangeLog,v
retrieving revision 6.825
diff -u -r6.825 ChangeLog
--- lisp/ChangeLog	2001/11/01 18:53:26	6.825
+++ lisp/ChangeLog	2001/11/03 20:38:06
@@ -1,3 +1,9 @@
+2001-11-03  Matt Armstrong  <matt@lickey.com>
+
+	* message.el (message-send-mail): Set message-deletable-headers to
+	nil around call to message-generate-headers when generating
+	Mail-Followup-To: (so Message-Id:, Date:, etc. are not deleted).
+
 2001-11-01  Simon Josefsson  <jas@extundo.com>
 
 	* message.el (message-insert-canlock): New variable.
Index: lisp/message.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/message.el,v
retrieving revision 6.145
diff -u -r6.145 message.el
--- lisp/message.el	2001/11/01 18:53:26	6.145
+++ lisp/message.el	2001/11/03 20:38:16
@@ -2572,8 +2572,9 @@
 		   message-subscribed-addresses
 		   message-subscribed-address-functions)
 	       (not (mail-fetch-field "mail-followup-to")))
-	  (message-generate-headers
-	   `(("Mail-Followup-To" . ,(message-make-mft))))
+	  (let ((message-deletable-headers nil))
+	    (message-generate-headers
+	     `(("Mail-Followup-To" . ,(message-make-mft)))))
 	;; otherwise, delete the MFT header if the field is empty
 	(when (equal "" (mail-fetch-field "mail-followup-to"))
 	  (message-remove-header "Mail-Followup-To")))




             reply	other threads:[~2001-11-03 21:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-11-03 21:09 Matt Armstrong [this message]
2001-11-04 14:33 ` ShengHuo ZHU
2001-11-04 19:21   ` Matt Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hesbef4i.fsf@squeaker.lickey.com \
    --to=matt+dated+1007413744.f977c8@lickey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).