Gnus development mailing list
 help / color / mirror / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: Gnus automatic builds
Date: Thu, 07 Apr 2011 14:51:22 -0500	[thread overview]
Message-ID: <87ipuprgat.fsf@lifelogs.com> (raw)
In-Reply-To: <87vcyp27g5.fsf@randomsample.de>

On Thu, 07 Apr 2011 21:21:46 +0200 David Engster <deng@randomsample.de> wrote: 

DE> I've now added a new rule 'check' which will run the whole test suite. I
DE> think it's a good thing to have a rule for every test in lisp/Makefile,
DE> since during development one often has to run single tests and not the
DE> whole suite. I've now started with "test-registry".

DE> Problem is: ERT does not run under Emacs 22, nor under XEmacs. So only
DE> Emacs 23 and 24 will currently run the tests. Maybe someone will port
DE> ERT to XEmacs, then we can add that any time.

I guess we could bundle ERT with the Gnus tests.  I was hoping to avoid
that.  Can it be installed in XEmacs as a package?

DE> I've also written a little test for NNTP connections; I've attached it
DE> to this mail. It also shows how one can test "real" Gnus functionality
DE> in batch mode on the buildbot server. It will connect news.gmane.org,
DE> get gmane.discuss, retrieve a single article from it (via message-id)
DE> and exit Gnus. The problem with these kinds of tests is that they depend
DE> on an external server. I added a simple check so that those test will
DE> only run if a ping to news.gmane.org succeeds, but still, the server
DE> might have other problems, which will lead to a failing test. So a
DE> failed NNTP test might not necessarily mean the last commit actually
DE> broke something, but a look in the logs should clear that up.

That's reasonable.  We could also run a fake NNTP server on a local port
that knows only a few commands and send back replies for them, so the
interaction is scripted.  This approach will definitely help us find
Gnus issues quickly.  I don't like test-driven development, but once the
code has been written, it's extremely useful to write tests too.

DE> The reason I did not commit gnustest-nntp.el yet is that I don't know
DE> where it should live. I'm hesitant to add it to gnus/lisp, because maybe
DE> we should have a dedicated directory for tests? We could also put other
DE> files in there we'll need for testing (some dummy mails for populating
DE> an IMAP folder, for instance). Suggestions?

For the *registry.el ERT tests I tried to provide tests that show how to
use the functionality (I used to just put comments with typical usage
above each defun).  Sort of a self-documenting library approach and one
of the reasons I like tests in the first place.

For standalone tests it makes sense to keep them separate.  So
gnus/tests would IMHO be OK and ERT can live there too.  Lars?

Ted




  reply	other threads:[~2011-04-07 19:51 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06  4:28 no gnus registry new dependency on ert? Eric Abrahamsen
2011-04-06 10:03 ` Ted Zlatanov
2011-04-06 10:10   ` David Engster
2011-04-06 10:54     ` Ted Zlatanov
2011-04-06 13:10       ` Ted Zlatanov
2011-04-06 13:28         ` David Engster
2011-04-06 14:26           ` Ted Zlatanov
2011-04-06 14:57             ` David Engster
2011-04-06 15:00               ` Ted Zlatanov
2011-04-06 15:03               ` David Engster
2011-04-06 15:51                 ` Ted Zlatanov
2011-04-06 13:15 ` Gnus automatic builds (was: no gnus registry new dependency on ert?) Ted Zlatanov
2011-04-06 13:31   ` Gnus automatic builds David Engster
2011-04-06 16:14     ` David Engster
2011-04-06 16:30       ` Ted Zlatanov
2011-04-06 18:10         ` David Engster
2011-04-06 18:57           ` Ted Zlatanov
2011-04-07 19:21             ` David Engster
2011-04-07 19:51               ` Ted Zlatanov [this message]
2011-04-07 20:02                 ` David Engster
2011-04-07 21:19                   ` Ted Zlatanov
2011-04-12 16:08               ` Lars Magne Ingebrigtsen
2011-04-12 16:29                 ` David Engster
2011-04-12 16:36                   ` Lars Magne Ingebrigtsen
2011-04-12 18:33                     ` Jason L Tibbitts III
2011-04-12 18:41                       ` Lars Magne Ingebrigtsen
2011-04-12 19:35                         ` Jason L Tibbitts III
2011-04-12 19:46                           ` David Engster
2011-04-12 19:51                             ` Jason L Tibbitts III
2011-04-16  8:22                               ` David Engster
2011-04-16 15:19                                 ` Ted Zlatanov
2011-04-20 18:50                                   ` David Engster
2011-04-20 20:58                                     ` Ted Zlatanov
2011-04-22 11:27                                     ` Adam Sjøgren
2011-04-22 21:21                                       ` David Engster
2011-04-25  9:05                                         ` Adam Sjøgren
2011-04-12 20:00                           ` Lars Magne Ingebrigtsen
2011-04-20 20:59                         ` David Engster
2011-04-20 21:03                           ` Ted Zlatanov
2011-04-20 21:31                             ` Jason L Tibbitts III
2011-04-21  7:33                               ` David Engster
2011-04-25 12:28                             ` Ted Zlatanov
2011-04-06 20:26       ` David Engster
2011-04-07 19:30         ` David Engster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipuprgat.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).