Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Reiner Steib]

Hi,

could we please get nicer commit log mails (like we had with CVS)?

- "From: www-data ..." is useless.  I want the person who committed
  (pushed?) the change.

- "Subject: [git] Gnus Project branch, master, updated. [some_long_hash]"

  Please show the file names and the "one line summary" when possible.

  I mean, if even bzr (emacs-diffs = gmane.emacs.diffs) can do it, it
  should be possible with git? :-)

- Could the boilerplate text[1] be appended instead of putting it at
  the top of the message?

What happened to ding-patches (gmane.emacs.gnus.commits)?  No postings
since April 2010.

With CVS, ding-cvslog (gmane.emacs.gnus.cvs) showed only a summary
(e.g. http://article.gmane.org/gmane.emacs.gnus.cvs/9382) and
ding-patches (gmane.emacs.gnus.commits) included the diff output as
well.

Bye, Reiner.

[1]
| This is an automated email from the git hooks/post-receive script. It was
| generated because a ref change was pushed to the repository containing
| the project "Gnus Project".
| 
| The branch, master has been updated
|        via  35f4e5fdddf9b75bbe26c59060a170f16ffd28ed (commit)
|       from  f9af44eeb5dfed0fafaa920242831b63f28e6e64 (commit)
| 
| Those revisions listed above that are new to this repository have
| not appeared on any other notification email; so we list those
| revisions in full, below.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Ted Zlatanov]

On Wed, 01 Sep 2010 09:44:03 +0200 Reiner Steib <reinersteib+gmane@imap.cc> wrote: 

RS> - "From: www-data ..." is useless.  I want the person who committed
RS>   (pushed?) the change.

Done.

The cvslog post gets moderated because of this changed:

"Your message to ding-cvslog has been delayed, and requires the approval 
of the moderators"

so using the real author e-mail will require more work for the
moderator.  We could use the comitter instead to make it less variable
but I think you want the author, right?

RS> - "Subject: [git] Gnus Project branch, master, updated. [some_long_hash]"

RS>   Please show the file names and the "one line summary" when possible.

There can be many files.  Better to just show the one-line summary
(showing just one file when possible creates inconsistent output so I
thought it wasn't optimal).  If you want it otherwise, see below.

RS> - Could the boilerplate text[1] be appended instead of putting it at
RS>   the top of the message?

Done.

RS> What happened to ding-patches (gmane.emacs.gnus.commits)?  No postings
RS> since April 2010.

RS> With CVS, ding-cvslog (gmane.emacs.gnus.cvs) showed only a summary
RS> (e.g. http://article.gmane.org/gmane.emacs.gnus.cvs/9382) and
RS> ding-patches (gmane.emacs.gnus.commits) included the diff output as
RS> well.

Tell me how you want it to work.  For me the current situation is OK.
The posts get gatewayed to the mailing lists on quimby (listed below)
and I have never needed just the summary.

The changes mentioned above required the standard
git-core/post-receive-email, which I modified and configured so:

[hooks] 
        mailinglist = cvslog@quimby.gnus.org,ding-commits@quimby.gnus.org,tzz@lifelogs.com
        emailprefix = "[git] "
        envelopesender = git-logger
        showrev = "git show -C %s; echo"

The modified post-receive hook is under etc/post-receive in Git now.  So
you can look in there and make modifications (list files in the subject,
etc).  I can test and install them into gnus.git/hooks/post-receive on
the server.  We can also put the Git repo config file in the repo
(partially cited above) if you think it's necessary.

Ted

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Ted Zlatanov]

On Wed, 01 Sep 2010 06:18:22 -0500 Ted Zlatanov <tzz@lifelogs.com> wrote: 

TZ> The posts get gatewayed to the mailing lists on quimby (listed below)
TZ> and I have never needed just the summary.

TZ>         mailinglist = cvslog@quimby.gnus.org,ding-commits@quimby.gnus.org,tzz@lifelogs.com

Those gateway into:

nntp+news.gnus.org:gnus.commits 
nntp+news.gnus.org:gnus.cvslog 

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Jason L Tibbitts III]

>>>>> "TZ" == Ted Zlatanov <tzz@lifelogs.com> writes:

TZ> The cvslog post gets moderated because of this changed:

Nah, only the first time (well, the "who posted what" records do expire,
so if you don't commit in several months I'll have to approve your
messages again).

TZ> "Your message to ding-cvslog has been delayed, and requires the
TZ> approval of the moderators"

I'm generally pretty quick about that.

TZ> so using the real author e-mail will require more work for the
TZ> moderator.

It's not that much work, and if it really bothers me I'll just make
things detect actual commit messages and pass them without moderation
regardless of who wrote them.  I just want to make sure that spam
doesn't slip through.

 - J<

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Adam Sjøgren]

On Wed, 01 Sep 2010 06:18:22 -0500, Ted wrote:

> On Wed, 01 Sep 2010 09:44:03 +0200 Reiner Steib <reinersteib+gmane@imap.cc> wrote: 

RS> - Could the boilerplate text[1] be appended instead of putting it at
RS> the top of the message?

> Done.

I am trying to sort of follow what happens by looking at the emails, and
to me everything before the:

  - Log -----------------------------------------------------------------

-line is noise (or stuff I would be happy to scroll down and look at, in
the rare cases I need that information). While log and diff are the
parts I most often want to read.

So I suggest that the part that looks like this at the top:

         via  f95141317eb39d9290d2fb9e7794b42db17b8991 (commit)
        from  d7c1cd6edd6b738730b0a646b7e8a257d30194df (commit)

  Those revisions listed above that are new to this repository have
  not appeared on any other notification email; so we list those
  revisions in full, below.

also is moved after the log and diff-parts.

What do you think?


  Best regards,

    Adam

-- 
 "Didn't matter to me what I said. Still doesn't,             Adam Sjøgren
  really."                                               asjo@koldfront.dk

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Lars Magne Ingebrigtsen]

asjo@koldfront.dk (Adam Sjøgren) writes:

> also is moved after the log and diff-parts.
>
> What do you think?

Yes, I agree.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Ted Zlatanov]

On Wed, 01 Sep 2010 22:28:00 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> asjo@koldfront.dk (Adam Sjøgren) writes:
>> also is moved after the log and diff-parts.
>> 
>> What do you think?

LMI> Yes, I agree.

OK, now post-receive will merge multiple commit messages into one long
subject line and format the message as Adam proposed.  Changes are in
etc/post-receive and comitted.

Ted

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> OK, now post-receive will merge multiple commit messages into one long
> subject line and format the message as Adam proposed.  Changes are in
> etc/post-receive and comitted.

They now look like this:

Subject: [git] Gnus Project branch, master, updated. 56bbe449783867ec4d9d92387172383531ead4ec Remove %O (moderated) from group line format, since it isn't very interesting.

Isn't the first bit kinda not very interesting to humans?  I mean the

"[git] Gnus Project branch, master, updated. 56bbe449783867ec4d9d92387172383531ead4ec"

bit.  Does that have to be in the Subject header?  Perhaps just "Gnus
Project" is sufficient?

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Ted Zlatanov]

On Thu, 02 Sep 2010 04:57:29 +0200 Lars Magne Ingebrigtsen <larsi@gnus.org> wrote: 

LMI> Ted Zlatanov <tzz@lifelogs.com> writes:
>> OK, now post-receive will merge multiple commit messages into one long
>> subject line and format the message as Adam proposed.  Changes are in
>> etc/post-receive and comitted.

LMI> They now look like this:

LMI> Subject: [git] Gnus Project branch, master, updated. 56bbe449783867ec4d9d92387172383531ead4ec Remove %O (moderated) from group line format, since it isn't very interesting.

LMI> Isn't the first bit kinda not very interesting to humans?  I mean the

LMI> "[git] Gnus Project branch, master, updated. 56bbe449783867ec4d9d92387172383531ead4ec"

LMI> bit.  Does that have to be in the Subject header?  Perhaps just "Gnus
LMI> Project" is sufficient?

The branch is necessary.  "updated" denoted the action taken.  The [git]
prefix is, I think, a nice visual filter (especially since we set the
sender to the author).  "Gnus Project" is the Git repo's config
description which we know.  The revision ID could be omitted, sure.  So
maybe this is better.

Subject: [gnus git] master updated. Remove %O (moderated) from group line format, since it isn't very interesting.

I made the change after my last commit so the next push will show the
new format.

One inaccuracy is that with multiple authors, only the most recent one
is used, and perhaps the comitter is the right name to put in From
instead of the author.  OTOH when Katsumi synchronizes, it's better to
see who made the change originally.  I'm open to suggestions.

Ted

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Adam Sjøgren]

On Wed, 01 Sep 2010 21:42:58 -0500, Ted wrote:

> OK, now post-receive will merge multiple commit messages into one long
> subject line and format the message as Adam proposed.  Changes are in
> etc/post-receive and comitted.

Just nitpicking: I proposed that everything above the --Log------ line
should move to the bottom, so it isn't exactly the format I proposed.

The sha1s at the top are still there (and I don't get any readily useful
information from reading them - if I want to look something up, they are
useful, but for following what happened the log and diff are more
interesting, to me).


  :-),

   Adam

-- 
 "Never never mind."                                          Adam Sjøgren
                                                         asjo@koldfront.dk

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Ted Zlatanov]

On Thu, 02 Sep 2010 12:55:12 +0200 asjo@koldfront.dk (Adam Sjøgren) wrote: 

AS> On Wed, 01 Sep 2010 21:42:58 -0500, Ted wrote:
>> OK, now post-receive will merge multiple commit messages into one long
>> subject line and format the message as Adam proposed.  Changes are in
>> etc/post-receive and comitted.

AS> Just nitpicking: I proposed that everything above the --Log------ line
AS> should move to the bottom, so it isn't exactly the format I proposed.

AS> The sha1s at the top are still there (and I don't get any readily useful
AS> information from reading them - if I want to look something up, they are
AS> useful, but for following what happened the log and diff are more
AS> interesting, to me).

It was intentional: I think it's better to see what commits are
summarized in the message and the revision IDs are very useful if you
plan to do anything beyond a quick review.

Ted

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Lars Magne Ingebrigtsen]

Ted Zlatanov <tzz@lifelogs.com> writes:

> It was intentional: I think it's better to see what commits are
> summarized in the message and the revision IDs are very useful if you
> plan to do anything beyond a quick review.

But do they need to be at the top?  They're not very human-readable...

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: Git, ding-cvslog (gmane.emacs.gnus.cvs), ding-patches (gmane.emacs.gnus.commits)

[Ted Zlatanov]

On Wed, 01 Sep 2010 22:22:05 +0200 asjo@koldfront.dk (Adam Sjøgren) wrote: 

AS> I am trying to sort of follow what happens by looking at the emails, and
AS> to me everything before the:

AS>   - Log -----------------------------------------------------------------

AS> -line is noise (or stuff I would be happy to scroll down and look at, in
AS> the rare cases I need that information). While log and diff are the
AS> parts I most often want to read.

AS> So I suggest that the part that looks like this at the top:

AS>          via  f95141317eb39d9290d2fb9e7794b42db17b8991 (commit)
AS>         from  d7c1cd6edd6b738730b0a646b7e8a257d30194df (commit)

AS>   Those revisions listed above that are new to this repository have
AS>   not appeared on any other notification email; so we list those
AS>   revisions in full, below.

AS> also is moved after the log and diff-parts.

I can do it, sure, but the revision list is a table of contents and
pretty nice in any non-trivial situation so I'd leave it on top.  Would
something like the following work for you?

Ted


diff --git a/etc/post-receive b/etc/post-receive
index 37ec5f9..9309ea3 100755
--- a/etc/post-receive
+++ b/etc/post-receive
@@ -405,10 +405,6 @@ generate_update_branch_email()
 
 	echo ""
 	if [ -z "$rewind_only" ]; then
-		echo "Those revisions listed above that are new to this repository have"
-		echo "not appeared on any other notification email; so we list those"
-		echo "revisions in full, below."
-
 		echo ""
 		echo $LOGBEGIN
 		show_new_revisions
@@ -418,6 +414,11 @@ generate_update_branch_email()
 		# revisions added by this update" message
 
 		echo $LOGEND
+
+		echo "Those revisions listed above that are new to this repository have"
+		echo "not appeared on any other notification email; so we listed those"
+		echo "revisions in full, above."
+
 	else
 		echo "No new revisions were added by this update."
 	fi