Re: smtpmail.el: set-buffer-file-coding-system takes too many args

[Simon Josefsson <simon@josefsson.org>]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> What do you suggest for contrib/smtpmail.el?  As `contrib/smtpmail.el'
> should only be used with Emacs 21, we probably can simply remove the
> NOMODIFY argument (and add a comment to explain it).
>
> Suggestion (similar for the second location):
>
> --- smtpmail.el	04 Dec 2006 23:32:00 +0100	7.5
> +++ smtpmail.el	06 Jan 2007 20:58:24 +0100	
> @@ -248,7 +248,11 @@
>  	  ;; buffer, otherwise any write-region invocations (e.g., in
>  	  ;; mail-do-fcc below) will annoy with asking for a suitable
>  	  ;; encoding.
> -	  (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
> +	  ;; (set-buffer-file-coding-system smtpmail-code-conv-from nil t)
> +	  (set-buffer-file-coding-system smtpmail-code-conv-from nil)
> +	  ;; This file (`gnus/contrib/smtpmail.el') is only useful for Emacs
> +	  ;; which doesn't support the thried argument (NOMODIFY) of
> +	  ;; `set-buffer-file-coding-system'.
>  	  (insert-buffer-substring mailbuf)
>  	  (goto-char (point-max))
>  	  ;; require one newline at the end.

If there is sufficient interest to maintain yet another smtpmail.el,
different from both Emacs CVS and XEmacs mail-lib, sure.  Another
approach would be to stop synchronizing smtpmail.el, and use the copy
that worked fine before the changes in CVS.

> BTW: Is NOMODIFY really useful here?  In both cases,
> `set-buffer-file-coding-system' is followed by
> `insert-buffer-substring' which will mark the buffer modified anyhow.
> What am I missing?

Hm, I agree that it looks funny.  Maybe you could ask whomever applied
this, if it is really needed?  I agree that it doesn't seem very
useful, and the modified-flag seems rather pointless for temporary
buffers anyway.

/Simon