From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/64233 Path: news.gmane.org!not-for-mail From: Simon Josefsson Newsgroups: gmane.emacs.gnus.general Subject: Re: smtpmail.el: set-buffer-file-coding-system takes too many args Date: Sun, 07 Jan 2007 11:12:46 +0100 Message-ID: <87irfjf8m9.fsf@latte.josefsson.org> References: <87d55svxxu.fsf@latte.josefsson.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1168164856 17749 80.91.229.12 (7 Jan 2007 10:14:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 7 Jan 2007 10:14:16 +0000 (UTC) Cc: David Z Maze Original-X-From: ding-owner+M12756@lists.math.uh.edu Sun Jan 07 11:14:13 2007 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1H3V2a-0002q0-NX for ding-account@gmane.org; Sun, 07 Jan 2007 11:14:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1H3V1U-0005SS-5K; Sun, 07 Jan 2007 04:13:04 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1H3V1S-0005S9-Ow for ding@lists.math.uh.edu; Sun, 07 Jan 2007 04:13:02 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.63) (envelope-from ) id 1H3V1M-0005qo-Rq for ding@lists.math.uh.edu; Sun, 07 Jan 2007 04:13:02 -0600 Original-Received: from 178.230.13.217.in-addr.dgcsystems.net ([217.13.230.178] helo=yxa.extundo.com) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1H3V1H-00057q-00 for ; Sun, 07 Jan 2007 11:12:51 +0100 Original-Received: from localhost.localdomain (yxa.extundo.com [217.13.230.178]) (authenticated bits=0) by yxa.extundo.com (8.13.4/8.13.4/Debian-3sarge3) with ESMTP id l07ACkNU009650 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 7 Jan 2007 11:12:47 +0100 Original-To: ding@gnus.org OpenPGP: id=B565716F; url=http://josefsson.org/key.txt Mail-Copies-To: nobody X-Hashcash: 1:22:070107:dmaze@mit.edu::HStJYXRViLT34bNs:1QIV X-Hashcash: 1:22:070107:ding@gnus.org::ZQVwm1gJfRscGfUf:3Gxc In-Reply-To: (Reiner Steib's message of "Sat\, 06 Jan 2007 21\:11\:25 +0100") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/22.0.92 (gnu/linux) X-Spam-Status: No, score=-2.2 required=4.0 tests=AWL,BAYES_00, FORGED_RCVD_HELO autolearn=ham version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on yxa-iv X-Virus-Scanned: ClamAV version 0.88.2, clamav-milter version 0.88.2 on yxa.extundo.com X-Virus-Status: Clean X-Spam-Score: -2.5 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:64233 Archived-At: Reiner Steib writes: > What do you suggest for contrib/smtpmail.el? As `contrib/smtpmail.el' > should only be used with Emacs 21, we probably can simply remove the > NOMODIFY argument (and add a comment to explain it). > > Suggestion (similar for the second location): > > --- smtpmail.el 04 Dec 2006 23:32:00 +0100 7.5 > +++ smtpmail.el 06 Jan 2007 20:58:24 +0100 > @@ -248,7 +248,11 @@ > ;; buffer, otherwise any write-region invocations (e.g., in > ;; mail-do-fcc below) will annoy with asking for a suitable > ;; encoding. > - (set-buffer-file-coding-system smtpmail-code-conv-from nil t) > + ;; (set-buffer-file-coding-system smtpmail-code-conv-from nil t) > + (set-buffer-file-coding-system smtpmail-code-conv-from nil) > + ;; This file (`gnus/contrib/smtpmail.el') is only useful for Emacs > + ;; which doesn't support the thried argument (NOMODIFY) of > + ;; `set-buffer-file-coding-system'. > (insert-buffer-substring mailbuf) > (goto-char (point-max)) > ;; require one newline at the end. If there is sufficient interest to maintain yet another smtpmail.el, different from both Emacs CVS and XEmacs mail-lib, sure. Another approach would be to stop synchronizing smtpmail.el, and use the copy that worked fine before the changes in CVS. > BTW: Is NOMODIFY really useful here? In both cases, > `set-buffer-file-coding-system' is followed by > `insert-buffer-substring' which will mark the buffer modified anyhow. > What am I missing? Hm, I agree that it looks funny. Maybe you could ask whomever applied this, if it is really needed? I agree that it doesn't seem very useful, and the modified-flag seems rather pointless for temporary buffers anyway. /Simon