From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/59183 Path: main.gmane.org!not-for-mail From: Romain Francoise Newsgroups: gmane.emacs.gnus.general Subject: Re: CVS update of gnus/lisp (ChangeLog gnus-sum.el) Date: Tue, 16 Nov 2004 19:23:51 +0100 Organization: orebokech dot com Message-ID: <87is85tzyg.fsf@orebokech.com> References: <877josgsg9.fsf@seamus.arnested.dk> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1100629578 10544 80.91.229.6 (16 Nov 2004 18:26:18 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 16 Nov 2004 18:26:18 +0000 (UTC) Original-X-From: ding-owner+M7723@lists.math.uh.edu Tue Nov 16 19:26:03 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13] ident=mail) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CU81j-0007lz-00 for ; Tue, 16 Nov 2004 19:26:03 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu ident=lists) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1CU7zs-0000lf-00; Tue, 16 Nov 2004 12:24:08 -0600 Original-Received: from util2.math.uh.edu ([129.7.128.23]) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1CU7zk-0000lZ-00 for ding@lists.math.uh.edu; Tue, 16 Nov 2004 12:24:00 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by util2.math.uh.edu with esmtp (Exim 4.30) id 1CU7ze-0000yA-Mx for ding@lists.math.uh.edu; Tue, 16 Nov 2004 12:23:54 -0600 Original-Received: from yeast.orebokech.com (yeast.orebokech.com [82.67.41.165]) by justine.libertine.org (Postfix) with ESMTP id 5CF9A3A0014 for ; Tue, 16 Nov 2004 12:23:52 -0600 (CST) Original-Received: from pacem.orebokech.com (pacem.orebokech.com [192.168.1.3]) by yeast.orebokech.com (Postfix) with ESMTP id 3410A12CF8 for ; Tue, 16 Nov 2004 19:23:50 +0100 (CET) Original-Received: by pacem.orebokech.com (Postfix, from userid 1000) id 4ABF7B3007; Tue, 16 Nov 2004 19:23:51 +0100 (CET) Original-To: ding@gnus.org Mail-Copies-To: nobody X-Face: "1+OIb}NK>vxR1ZMk[Jx!/]O|A-v/P&|%hFquLxp20W.'g4KNUD/IdAUSmd'5`f)Q9%"4]%{P`TF2dC4v1~G5D}S( In-Reply-To: (Jesper Harder's message of "Sun, 14 Nov 2004 23:12:51 +0100") User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3.50 (gnu/linux) Precedence: bulk Original-Sender: ding-owner@lists.math.uh.edu Xref: main.gmane.org gmane.emacs.gnus.general:59183 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:59183 Jesper Harder writes: >> As a side(?) effect of this change my `gnus-summary-expunge-below' >> gets reset to nil every time I have visited a summary buffer. >> >> Is this the intended behaviour? How do I give it a global value >> then? > I guess it is, see below: > `gnus-summary-expunge-below' > Don't display the summary lines of articles that have scores lower > than this variable. This is `nil' by default, which means that no > articles will be hidden. This variable is local to the summary > buffers, and has to be set from `gnus-summary-mode-hook'. This is wrong. Why then would there be a defcustom for it? In gnus-sum you will see that some local variables get their value from global values (cons cells who have a 'global cdr), and your change has the side effect of making all global values be cleared on summary exit, losing the customization. This is also why articles with a negative score are no longer marked as read: gnus-summary-mark-below gets reset to nil from its default value of zero. I suggest the following patch which fixes both problems: it removes the "also clear global values" part, which in fact never worked since global variable were apparently not reset. (It may be fuzzy, I have other changes in gnus-sum.el.) Index: gnus-sum.el =================================================================== RCS file: /usr/local/cvsroot/gnus/lisp/gnus-sum.el,v retrieving revision 7.66 diff -u -r7.66 gnus-sum.el --- gnus-sum.el 7 Nov 2004 22:00:10 -0000 7.66 +++ gnus-sum.el 16 Nov 2004 18:18:30 -0000 @@ -6704,12 +6718,6 @@ (gnus-summary-clear-local-variables)) (when (get-buffer gnus-article-buffer) (bury-buffer gnus-article-buffer)) - ;; We clear the global counterparts of the buffer-local - ;; variables as well, just to be on the safe side. - (set-buffer gnus-group-buffer) - (gnus-summary-clear-local-variables) - (let ((gnus-summary-local-variables gnus-newsgroup-variables)) - (gnus-summary-clear-local-variables)) ;; Return to group mode buffer. (when (eq mode 'gnus-summary-mode) (gnus-kill-buffer buf))) -- Romain Francoise | There's no stronger wind than it's a miracle -- http://orebokech.com/ | the one that blows down a | lonesome railroad line.