Re: browse-url-new-window-p doesn't work?

[Daniel Neri <dne@mayonnaise.net>]

[-- Attachment #1: Type: text/plain, Size: 651 bytes --]

Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes:

> I have set browse-url-new-window-p to t and
> browse-url-browser-function to browse-url-netscape.  Yet, hitting
> mouse-2 on a link in an article (or RET) doesn't open a new Netscape
> window, it reuses an existing window.

Andreas Schwab <schwab@suse.de> writes:

> Use this instead:
> 
> (defun browse-url-netscape-new-window (url)
>   (browse-url-netscape url t))

Yeah, this fixes it. Though I think gnus-button-url should honour
browse-url-new-window-p instead. This also benefits users of other
browsers with this capability.

I'm attaching my patch (for 0.96).

Regards,
/Daniel



[-- Attachment #2: gnus-button-url patch --]
[-- Type: text/x-patch, Size: 636 bytes --]

*** gnus-art.el	1999/08/27 22:41:21	1.1
--- gnus-art.el	1999/08/27 22:58:00	1.2
***************
*** 4322,4331 ****
  
  (defun gnus-button-url (address)
    "Browse ADDRESS."
!   ;; In Emacs 20, `browse-url-browser-function' may be an alist.
!   (if (listp browse-url-browser-function)
!       (browse-url address)
!     (funcall browse-url-browser-function address)))
  
  (defun gnus-button-embedded-url (address)
    "Browse ADDRESS."
--- 4322,4328 ----
  
  (defun gnus-button-url (address)
    "Browse ADDRESS."
!   (browse-url address browse-url-new-window-p))
  
  (defun gnus-button-embedded-url (address)
    "Browse ADDRESS."

[-- Attachment #3: Type: TEXT/PLAIN, Size: 36 bytes --]


-- 
Daniel Neri
dne@mayonnaise.net