From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/24925 Path: main.gmane.org!not-for-mail From: Daniel Neri Newsgroups: gmane.emacs.gnus.general Subject: Re: browse-url-new-window-p doesn't work? Date: Sat, 28 Aug 1999 01:29:50 +0200 Sender: owner-ding@hpc.uh.edu Message-ID: <87iu60u7ip.fsf@nowhere.mayonnaise.net> References: NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="Boundary_(ID_HiM/G8Zit2NHVk9QNkTnTQ)" X-Trace: main.gmane.org 1035162406 11357 80.91.224.250 (21 Oct 2002 01:06:46 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 01:06:46 +0000 (UTC) Return-Path: Original-Received: from farabi.math.uh.edu (farabi.math.uh.edu [129.7.128.57]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id TAA17282 for ; Fri, 27 Aug 1999 19:31:20 -0400 (EDT) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by farabi.math.uh.edu (8.9.3/8.9.3) with ESMTP id SAB25145; Fri, 27 Aug 1999 18:31:02 -0500 (CDT) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Fri, 27 Aug 1999 18:31:17 -0500 (CDT) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.9.3/8.9.3) with ESMTP id SAA16806 for ; Fri, 27 Aug 1999 18:31:07 -0500 (CDT) Original-Received: from ratatosk.utfors.se (ratatosk.utfors.se [195.58.103.123]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id TAA17252 for ; Fri, 27 Aug 1999 19:30:16 -0400 (EDT) Original-Received: from nowhere (md4691053.utfors.se) by ratatosk.utfors.se (Sun Internet Mail Server sims.3.5.1999.03.02.17.58.p5) with ESMTP id <0FH500EDVDACO9@ratatosk.utfors.se> for ding@gnus.org; Sat, 28 Aug 1999 01:30:13 +0200 (MET DST) Original-Received: (qmail 21920 invoked by uid 1000); Fri, 27 Aug 1999 23:29:50 +0000 In-reply-to: Kai.Grossjohann@CS.Uni-Dortmund.DE's message of "Wed, 18 Aug 1999 09:23:41 GMT" Original-To: ding@gnus.org User-Agent: Gnus/5.070096 (Pterodactyl Gnus v0.96) Emacs/20.4 Original-Lines: 30 Precedence: list X-Majordomo: 1.94.jlt7 Xref: main.gmane.org gmane.emacs.gnus.general:24925 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:24925 --Boundary_(ID_HiM/G8Zit2NHVk9QNkTnTQ) Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 8BIT Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann) writes: > I have set browse-url-new-window-p to t and > browse-url-browser-function to browse-url-netscape. Yet, hitting > mouse-2 on a link in an article (or RET) doesn't open a new Netscape > window, it reuses an existing window. Andreas Schwab writes: > Use this instead: > > (defun browse-url-netscape-new-window (url) > (browse-url-netscape url t)) Yeah, this fixes it. Though I think gnus-button-url should honour browse-url-new-window-p instead. This also benefits users of other browsers with this capability. I'm attaching my patch (for 0.96). Regards, /Daniel --Boundary_(ID_HiM/G8Zit2NHVk9QNkTnTQ) Content-type: text/x-patch; NAME=gnus-button-url.patch Content-description: gnus-button-url patch Content-disposition: attachment; filename=gnus-button-url.patch Content-transfer-encoding: 7BIT *** gnus-art.el 1999/08/27 22:41:21 1.1 --- gnus-art.el 1999/08/27 22:58:00 1.2 *************** *** 4322,4331 **** (defun gnus-button-url (address) "Browse ADDRESS." ! ;; In Emacs 20, `browse-url-browser-function' may be an alist. ! (if (listp browse-url-browser-function) ! (browse-url address) ! (funcall browse-url-browser-function address))) (defun gnus-button-embedded-url (address) "Browse ADDRESS." --- 4322,4328 ---- (defun gnus-button-url (address) "Browse ADDRESS." ! (browse-url address browse-url-new-window-p)) (defun gnus-button-embedded-url (address) "Browse ADDRESS." --Boundary_(ID_HiM/G8Zit2NHVk9QNkTnTQ) Content-type: TEXT/PLAIN Content-transfer-encoding: 7BIT -- Daniel Neri dne@mayonnaise.net --Boundary_(ID_HiM/G8Zit2NHVk9QNkTnTQ)--