What's the best way to auto-sign some emails but not all?

What's the best way to auto-sign some emails but not all?

[Bjørn Mork]

Is there a nice way to always sign emails based on e.g. the current From
address?  I don't want to sign everything, but I would like to sign all
emails I send from one specific address.

I'm using gnus-posting-styles to automatically set up things like from
address, default headers and signature based on context.  But I can't
figure out how to enable automatic signing.  A simple approach like
adding

 (body "<#secure method=pgpmime mode=sign>")

to an existing posting style rule sort of works.  But it fails on
replies with quoted original text.  The body text end up between the
quoted text and the signature, which obviously makes sense for any real
body.  But the mml tag is not recognised and is sent verbatim.

I tried adding the tag in more complicated ways, using posting style
eval and a function inserting the mml tag on the first line of the body.
But the message buffer is always empty when this runs, so that doesn't
work any better.  The tag still ends up the same place.

I guess I'm looking at this the wrong way.  But I'm stuck.

(My elisp skills are extremely limited, so I didn't want to re-implement
the posting style context matching in a sending hook or similar.  That's
way out of my league)


Bjørn

Re: What's the best way to auto-sign some emails but not all?

[Trevor Arjeski]

Bjørn Mork <bjorn@mork.no> writes:

> Is there a nice way to always sign emails based on e.g. the current From
> address?  I don't want to sign everything, but I would like to sign all
> emails I send from one specific address.

Hi Bjørn,

For me, I am signing all messages and just removing the "secure" tag
when I am writing on a mailing list or something.

I do this by adding a hook on `message-setup-hook' that calls
`mml-secure-message-encrypt'.

Therefore, you can add a similar hook with the help of a function (or
just lambda), for example:

#+BEGIN_SRC emacs-lisp
(defun my/mml-secure-message-encrypt ()
  "Encrypt all messages when we are sending as bjorn@mork.no. Do nothing
for all other From addresses."
  (when (string= message-sendmail-envelope-from
                 "bjorn@mork.no")
    (mml-secure-message-encrypt)))

(add-hook 'message-setup-hook #'my/mml-secure-message-encrypt)
#+END_SRC

Let me know if that is what you want or helps at all.

Trevor

Re: What's the best way to auto-sign some emails but not all?

[Bjørn Mork]

Trevor Arjeski <tmarjeski@gmail.com> writes:
> Bjørn Mork <bjorn@mork.no> writes:
>
>> Is there a nice way to always sign emails based on e.g. the current From
>> address?  I don't want to sign everything, but I would like to sign all
>> emails I send from one specific address.
>
> Hi Bjørn,
>
> For me, I am signing all messages and just removing the "secure" tag
> when I am writing on a mailing list or something.

Yes, that's a possibilty.  But do hate manual procedures for anything
that can be automated.  And knowing myself, I am going to forget this
47% of the time.  I'll remember it if the passphrase box shows up.  But
I don't want to disable caching, and I am sure that will result in some
emails going out with an unwanted gpg signature. Not a big problem,
maybe.  But we're looking for the perfect solution here :-)

> I do this by adding a hook on `message-setup-hook' that calls
> `mml-secure-message-encrypt'.
>
> Therefore, you can add a similar hook with the help of a function (or
> just lambda), for example:
>
> #+BEGIN_SRC emacs-lisp
> (defun my/mml-secure-message-encrypt ()
>   "Encrypt all messages when we are sending as bjorn@mork.no. Do nothing
> for all other From addresses."
>   (when (string= message-sendmail-envelope-from
>                  "bjorn@mork.no")
>     (mml-secure-message-encrypt)))
>
> (add-hook 'message-setup-hook #'my/mml-secure-message-encrypt)
> #+END_SRC
>
> Let me know if that is what you want or helps at all.

Thanks a lot!  It does not work any better, but at least it shows me how
easy adding a hook would be.

And it also made me look at how the gnus posting styles are implemented.

I tried your suggestion with message-sendmail-envelope-from replaced by
user-mail-address, since SPF prevents me from changing the envelope
along with the from address.

Unfortunately, this works exacly like using "body" or "eval" in a
posting style.  It's fine with an empty buffer, but not when replying
with quoted text.  Which isn't surprising after having looked at
gnus-configure-posting-styles in gnus-msg.el.

What gnus-configure-posting-styles does under the hood is

        (add-hook 'message-setup-hook
                  (cond
                   ((eq 'eval (car result))
                    #'ignore)
                   ((eq 'body (car result))
                    (let ((txt (cdr result)))
                      (lambda ()
                        (save-excursion
                          (message-goto-body)
                          (insert txt)))))

etc.

Not exactly sure how all this works, but it looks like the yanked text
must be inserted into the buffer at a later stage.


Bjørn

Re: What's the best way to auto-sign some emails but not all?

[Trevor Arjeski]

Bjørn Mork <bjorn@mork.no> writes:

> Trevor Arjeski <tmarjeski@gmail.com> writes:
>> Bjørn Mork <bjorn@mork.no> writes:
>>
>>> Is there a nice way to always sign emails based on e.g. the current From
>>> address?  I don't want to sign everything, but I would like to sign all
>>> emails I send from one specific address.
>>
>> Hi Bjørn,
>>
>> For me, I am signing all messages and just removing the "secure" tag
>> when I am writing on a mailing list or something.
>
> Yes, that's a possibilty.  But do hate manual procedures for anything
> that can be automated.  And knowing myself, I am going to forget this
> 47% of the time.  I'll remember it if the passphrase box shows up.  But
> I don't want to disable caching, and I am sure that will result in some
> emails going out with an unwanted gpg signature. Not a big problem,
> maybe.  But we're looking for the perfect solution here :-)

Of course! I wasn't suggesting it for you, just leading up to the hook.

>
>> I do this by adding a hook on `message-setup-hook' that calls
>> `mml-secure-message-encrypt'.
>>
>> Therefore, you can add a similar hook with the help of a function (or
>> just lambda), for example:
>>
>> #+BEGIN_SRC emacs-lisp
>> (defun my/mml-secure-message-encrypt ()
>>   "Encrypt all messages when we are sending as bjorn@mork.no. Do nothing
>> for all other From addresses."
>>   (when (string= message-sendmail-envelope-from
>>                  "bjorn@mork.no")
>>     (mml-secure-message-encrypt)))
>>
>> (add-hook 'message-setup-hook #'my/mml-secure-message-encrypt)
>> #+END_SRC
>>
>> Let me know if that is what you want or helps at all.
>
> Thanks a lot!  It does not work any better, but at least it shows me how
> easy adding a hook would be.
>
> And it also made me look at how the gnus posting styles are implemented.
>
> I tried your suggestion with message-sendmail-envelope-from replaced by
> user-mail-address, since SPF prevents me from changing the envelope
> along with the from address.
>
> Unfortunately, this works exacly like using "body" or "eval" in a
> posting style.  It's fine with an empty buffer, but not when replying
> with quoted text.  Which isn't surprising after having looked at
> gnus-configure-posting-styles in gnus-msg.el.

My mistake, I completely missed that you only want to sign certain parts
of the message. (also I wrote -encrypt instead of -sign in the function)

Ignore me!

Trevor

Re: What's the best way to auto-sign some emails but not all?

[Bjørn Mork]

Thanks for all the great ideas.  I have realized that there are probably
more ways to do this than there are Gnus users :-)

The discussion made me look closer at the code in question, which I
should have done in the first place. And I believe my problem is that
there are no hooks in the appropriate places.  Yanking the original
message happens very late, long after message-setup is finished.

Most of the suggestions depend on message-setup-hook in some way, making
them work and fail similar to my existing gnus-posting-styles setup. One
exception is gnus-alias which AFAIU can apply a new identity to an
existing message buffer.  But that's an interactive choice, which is
what I'm trying to avoid. After all, I could just run
mml-secure-message-sign if I wanted to.

So what I have ended up with is this ugly hack:

#+BEGIN_SRC emacs-lisp
(defun bjorn/message--yank-original-advice (arg)
  "Leave sign/encrypt mml tags untouched when yanking original"
  (when (looking-at "<#secure")
    (forward-line 1)))
(advice-add 'message--yank-original-internal :before #'bjorn/message--yank-original-advice)
#+END_SRC


which does the job for me when combined

       (body "<#secure method=pgpmime mode=sign>")

in the appropriate posting style(s).


Bjørn

Re: What's the best way to auto-sign some emails but not all?

[Björn Bidar]

Bjørn Mork <bjorn@mork.no> writes:

> Thanks for all the great ideas.  I have realized that there are probably
> more ways to do this than there are Gnus users :-)
>
> The discussion made me look closer at the code in question, which I
> should have done in the first place. And I believe my problem is that
> there are no hooks in the appropriate places.  Yanking the original
> message happens very late, long after message-setup is finished.
>
> Most of the suggestions depend on message-setup-hook in some way, making
> them work and fail similar to my existing gnus-posting-styles setup. One
> exception is gnus-alias which AFAIU can apply a new identity to an
> existing message buffer.  But that's an interactive choice, which is
> what I'm trying to avoid.

That is not true. gnus-alias has rules which make it possible to
automatically apply an identity. Check C-h v gnus-alias-identity-rules RET. 

Message-signature manual or automatically should also take into account
a yanked article AFAIU.

Re: What's the best way to auto-sign some emails but not all?

[Bjørn Mork]

Björn Bidar <bjorn.bidar@thaodan.de> writes:
> Bjørn Mork <bjorn@mork.no> writes:
>
>> Most of the suggestions depend on message-setup-hook in some way, making
>> them work and fail similar to my existing gnus-posting-styles setup. One
>> exception is gnus-alias which AFAIU can apply a new identity to an
>> existing message buffer.  But that's an interactive choice, which is
>> what I'm trying to avoid.
>
> That is not true. gnus-alias has rules which make it possible to
> automatically apply an identity. Check C-h v gnus-alias-identity-rules RET. 

Yes, I know, and I didn't mean to say anything else.

But AFAICS, the result of the gnus-alias automatic identity mapping is
limited by what is possible in a message-setup-hook.  That's what I tried
to express.

> Message-signature manual or automatically should also take into account
> a yanked article AFAIU.

Sorry if I've misunderstood something, but I really don't understand how
that could work.  Not sure where the authoritative source of gnus-alias
is.  Doesn't look like it is part of emacs.  Google gave me a github
repo, but I don't know if that's correct?

Anyway, that version seems to do automatic identity mapping by adding a
hook to message-setup-hook - which makes sense:

https://github.com/altruizine/gnus-alias/blob/master/gnus-alias.el#L666

I understand that you can insert anything into the message buffer here.
But Gnus has not yet inserted the yanked text, so you cannot position
your inserts relative to that text.  Anything you place at the beginning
of the body will be moved around later.

There's a lot of code spread over many functions, but I believe
gnus-summary-reply() is the best place to start looking at the problem:

https://github.com/emacs-mirror/emacs/blob/master/lisp/gnus/gnus-msg.el#L1061

It ends with:

	(message-reply nil wide)
	(when yank
	  (gnus-inews-yank-articles yank))
	(gnus-summary-handle-replysign)))))


Where message-reply() will call message-setup() as its final step, which
in turn will run all the message-setup-hook hooks.  See

https://github.com/emacs-mirror/emacs/blob/master/lisp/gnus/message.el#L7314
https://github.com/emacs-mirror/emacs/blob/master/lisp/gnus/message.el#L6823

This means that gnus-inews-yank-articles() runs after any automatic
message setup by gnus-posting-styles, gnus-alias or my own personal
setup hook.

gnus-inews-yank-articles() can be configured to insert the quoted text
above or below the message, but I can't see any obvious way to allow it
to insert the text between any existing mml tag and the rest of the
message body.  Which is where I'd like it to end up.

One could also have imagined a solution where it was possible to control
gnus-summary-handle-replysign() by a buffer local variable.  But it
depends on the sign/encrypt status of the message being replied to, using
the variables

 gnus-message-replyencrypt
 gnus-message-replysign

And that is not exactly what I want either.  I want to sign *all*
replies from a specific address, whether the original was sined or not.


Bjørn

Re: What's the best way to auto-sign some emails but not all?

[Björn Bidar]

Bjørn Mork <bjorn@mork.no> writes:

> Björn Bidar <bjorn.bidar@thaodan.de> writes:
>> Bjørn Mork <bjorn@mork.no> writes:
>>
>>> Most of the suggestions depend on message-setup-hook in some way, making
>>> them work and fail similar to my existing gnus-posting-styles setup. One
>>> exception is gnus-alias which AFAIU can apply a new identity to an
>>> existing message buffer.  But that's an interactive choice, which is
>>> what I'm trying to avoid.
>>
>> That is not true. gnus-alias has rules which make it possible to
>> automatically apply an identity. Check C-h v gnus-alias-identity-rules RET. 
>
> Yes, I know, and I didn't mean to say anything else.
>
> But AFAICS, the result of the gnus-alias automatic identity mapping is
> limited by what is possible in a message-setup-hook.  That's what I tried
> to express.
>
>> Message-signature manual or automatically should also take into account
>> a yanked article AFAIU.
>
> Sorry if I've misunderstood something, but I really don't understand how
> that could work.  Not sure where the authoritative source of gnus-alias
> is.  Doesn't look like it is part of emacs.  Google gave me a github
> repo, but I don't know if that's correct?

I was talking of the builtin message-signature function which can be
called automatically or manually using C-c C-w. From what I read it did
look like that these look to not insert into the yanked article but at
the signature marker at the end of the article where the don't conflict
with the yanked article/message.

> Anyway, that version seems to do automatic identity mapping by adding a
> hook to message-setup-hook - which makes sense:
>
> https://github.com/altruizine/gnus-alias/blob/master/gnus-alias.el#L666
>
> I understand that you can insert anything into the message buffer here.
> But Gnus has not yet inserted the yanked text, so you cannot position
> your inserts relative to that text.  Anything you place at the beginning
> of the body will be moved around later.
>
> There's a lot of code spread over many functions, but I believe
> gnus-summary-reply() is the best place to start looking at the problem:
>
> https://github.com/emacs-mirror/emacs/blob/master/lisp/gnus/gnus-msg.el#L1061
>
> It ends with:
>
> 	(message-reply nil wide)
> 	(when yank
> 	  (gnus-inews-yank-articles yank))
> 	(gnus-summary-handle-replysign)))))
>
> Where message-reply() will call message-setup() as its final step, which
> in turn will run all the message-setup-hook hooks.  See
>
> https://github.com/emacs-mirror/emacs/blob/master/lisp/gnus/message.el#L7314
> https://github.com/emacs-mirror/emacs/blob/master/lisp/gnus/message.el#L6823
>
> This means that gnus-inews-yank-articles() runs after any automatic
> message setup by gnus-posting-styles, gnus-alias or my own personal
> setup hook.

> gnus-inews-yank-articles() can be configured to insert the quoted text
> above or below the message, but I can't see any obvious way to allow it
> to insert the text between any existing mml tag and the rest of the
> message body.  Which is where I'd like it to end up.

From what I read the message-mode yank functions took account of not
interfering with the signature. To me it does sound like a bug if
gnus-inews-yank-articles would break the signature.

Looking at comment in message.el:4037
at (message--yank-original-internal (arg)):
;; Add a `message-setup-very-last-hook' here?

It does appear like this a known possible issue.

I assume gnus-message-setup-hook doesn't work either.

Maybe it's worth to look for an existing bug report for possible context
or open a new one.

Anway good that you found a solution.

Re: What's the best way to auto-sign some emails but not all?

[Sean Whitton]

Hello,

I use https://tracker.debian.org/pkg/message-templ for this.

-- 
Sean Whitton

Re: What's the best way to auto-sign some emails but not all?

[Björn Bidar]

Hey,

Could you "hack" `message-signature' or respectively message-signature
file todo this?

You could also combine it with posting styles I think.

Br,

Björn with an Ö (:

Re: What's the best way to auto-sign some emails but not all?

[Bob Newell]

> Could you "hack" `message-signature' or respectively message-signature
> file todo this?
>
> You could also combine it with posting styles I think.

I'm sure these are all feasible but I've been able to do this
with relative ease with the gnus-alias facility.  There's a
field in which you can put a custom function to select or
generate a sig, or no sig at all, based initially on the
sender identity as determined by gnus-alias, but really on
just about any critera.

This allows me to activate any of my multiple personalities in
a nearly arbitrary fashion.

-- 
Bob Newell
Honolulu, Hawai`i

- Via GNU-Linux/Emacs/Gnus/BBDB

Re: What's the best way to auto-sign some emails but not all?

[James Thomas]

Bjørn Mork <bjorn@mork.no> writes:

> Is there a nice way to always sign emails based on e.g. the current
> From
> address? I don't want to sign everything, but I would like to sign all
> emails I send from one specific address.
>
> I'm using gnus-posting-styles to automatically set up things like from
> address, default headers and signature based on context. But I can't
> figure out how to enable automatic signing. A simple approach like
> adding
>
>  (body "<#secure method=pgpmime mode=sign>")
>
> to an existing posting style rule sort of works.  But it fails on
> replies with quoted original text. The body text end up between the
> quoted text and the signature, which obviously makes sense for any
> real
> body.  But the mml tag is not recognised and is sent verbatim.
>
> I tried adding the tag in more complicated ways, using posting style
> eval and a function inserting the mml tag on the first line of the
> body.
> But the message buffer is always empty when this runs, so that doesn't
> work any better.  The tag still ends up the same place.
>
> I guess I'm looking at this the wrong way.  But I'm stuck.
>
> (My elisp skills are extremely limited, so I didn't want to
> re-implement
> the posting style context matching in a sending hook or similar.
> That's
> way out of my league)

This seems to work:

(setq gnus-posting-styles
      '((t
	 (eval (setq-local message-cite-reply-position 'above))
	 (body "<#secure method=pgpmime mode=sign>"))))


Regards,
James

Re: What's the best way to auto-sign some emails but not all?

[Bjørn Mork]

James Thomas <jimjoe@gmx.net> writes:

> This seems to work:
>
> (setq gnus-posting-styles
>       '((t
> 	 (eval (setq-local message-cite-reply-position 'above))
> 	 (body "<#secure method=pgpmime mode=sign>"))))

Sort of.  But it also places the signature (i.e. the "-- \n" etc, not
the pgp signature) above the quoted text.  But that might be controlled
by some other variable?

Works pretty well if combined with

	(signature nil))

Still adds an unwanted empty line above "foo writes:"

So the message--yank-original-internal advice hack is my preferred
solution.



Bjørn

Re: What's the best way to auto-sign some emails but not all?

[James Thomas]

Bjørn Mork wrote:

> James Thomas writes:
>
>> This seems to work:
>>
>> (setq gnus-posting-styles
>>       '((t
>> 	 (eval (setq-local message-cite-reply-position 'above))
>> 	 (body "<#secure method=pgpmime mode=sign>"))))
>
> Sort of.  But it also places the signature (i.e. the "-- \n" etc, not
> the pgp signature) above the quoted text.  But that might be controlled
> by some other variable?
>
> Works pretty well if combined with
>
> 	(signature nil))
>
> Still adds an unwanted empty line above "foo writes:"

Have you seen (info "(message) Insertion Variables")? There's a lot of
stuff in there.

--