From: Eric Abrahamsen <firstname.lastname@example.org>
To: Eli Zaretskii <email@example.com>
Cc: Florian Weimer <firstname.lastname@example.org>,
email@example.com, firstname.lastname@example.org, email@example.com
Subject: Re: master ef14acf: Make nnml handle invalid non-ASCII headers more consistently
Date: Mon, 19 Dec 2022 09:48:15 -0800 [thread overview]
Message-ID: <firstname.lastname@example.org> (raw)
In-Reply-To: <email@example.com> (Eli Zaretskii's message of "Mon, 19 Dec 2022 19:07:57 +0200")
On 12/19/22 19:07 PM, Eli Zaretskii wrote:
>> From: Florian Weimer <firstname.lastname@example.org>
>> Cc: email@example.com, firstname.lastname@example.org, email@example.com,
>> Date: Mon, 19 Dec 2022 14:59:17 +0100
>> > I'm not sure this is related. I was talking about the missing SPC
>> > character before the parentheses. But I know very little about this
>> > stuff, so maybe I'm just misunderstanding you.
>> I was responding to “this From header is invalid”. I'm not sure if the
>> original message is actually malformed.
> Ah, okay. I'm not sure, either, although I don't think I've ever seen
> such addresses. But I'm no expert. Maybe rfc2047.el needs to be more
> tolerant and less dependent on whitespace; I'll leave that to experts.
> But even if there's nothing wrong with this particular header, I think
> you will agree that signaling and error and thus failing the entire
> storage of the message is not TRT, especially since the change which
> causes this was done for basically aesthetic reasons. Falling back to
> previous behavior in these cases is better, I think.
>> As I expected, I could reproduce the issue with new mail. I'm happy to
>> report that replacing nnml--encode-headers with your new version fixes
>> the issue.
> Thanks, so I've now installed this on the emacs-29 branch, for the
> upcoming Emacs 29.1.
>> Going back to older mail, I see that previously the From: header was
>> written in encoded form to .overview (slightly wrapped to avoid SMTP
>> 8523 Re: [PATCH 1/7] Rename 'hello2.spec.' -> 'hello2.spec'
>> 'hello3.spec.' -> 'hello3.spec'
>> <firstname.lastname@example.org> Thu, 24 Nov 2022 16:27:56 +0800
>> 705 32 Xref: oldenburg.str.redhat.com
>> lists.sourceware.elfutils-devel:8523 Cc: "Frank Ch. Eigler"
>> <email@example.com>, firstname.lastname@example.org To: Mark Wielaard
>> Now it uses unencoded form:
>> 8762 Re: [PATCH v2 13/16] lib: isatty is not available on windows 罗
>> 勇刚(Yonggang Luo) via Elfutils-devel
>> <email@example.com> Mon, 19 Dec 2022 20:32:48 +0800
>> <firstname.lastname@example.org> 1074 43 Xref:
>> oldenburg.str.redhat.com lists.sourceware.elfutils-devel:8762 To:
> Is that a problem? I think this was part of the reason for that
> change in nnml.el.
It would definitely be a problem to change the on-disk representation of
data in the .overview files! Lots of code depends on a very specific
format for those files; I've broken things badly in the past by removing
header encoding there.
next prev parent reply other threads:[~2022-12-19 17:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <email@example.com>
[not found] ` <20210122180802.F0A1E20A10@vcs0.savannah.gnu.org>
2022-12-16 22:42 ` Florian Weimer
2022-12-17 7:45 ` Eli Zaretskii
2022-12-17 14:57 ` Florian Weimer
2022-12-17 15:52 ` Eli Zaretskii
2022-12-19 13:59 ` Florian Weimer
2022-12-19 17:07 ` Eli Zaretskii
2022-12-19 17:27 ` Florian Weimer
2022-12-19 17:44 ` Eli Zaretskii
2022-12-19 17:48 ` Eric Abrahamsen [this message]
2022-12-19 17:58 ` Eli Zaretskii
2022-12-19 18:05 ` Eric Abrahamsen
2022-12-19 18:16 ` Eli Zaretskii
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).