Re: New "gnus-search" syntax and interface

[Eric Abrahamsen <eric@ericabrahamsen.net>]

[-- Attachment #1: Type: text/plain, Size: 1159 bytes --]

"Jose A. Ortega Ruiz" <jao@gnu.org> writes:

> On Thu, Nov 12 2020, Eric Abrahamsen wrote:
>
>> On 11/08/20 07:16 AM, Jose A. Ortega Ruiz wrote:
>>> On Sat, Nov 07 2020, Eric Abrahamsen wrote:
>>>
>>>>> Hmmm, are nested topics supported?  That is, if i search on a topic that
>>>>> contains subtopics, is the search including groups inside those
>>>>> subtopics?
>>>>
>>>> That's it! Nested topics are not supported. I'll put this on the list
>>>> and get it fixed in the next couple days.
>>>
>>> Excellent. Count on me to give it a test drive!
>>
>> Okay here goes -- the attached patch should make topic searching work as
>> expected. Would you give it a try?
>
> hmmm, no.  with this patch applied, GG on a topic raises:
>
>   gnus-topic-find-groups("inbox" nil all nil recursive)
>   gnus-group-read-ephemeral-search-group(nil)
>   funcall-interactively(gnus-group-read-ephemeral-search-group nil)
>   call-interactively(gnus-group-read-ephemeral-search-group nil nil)
>   command-execute(gnus-group-read-ephemeral-search-group)

Bah, it's always the last minute little "inconsequential" changes that
get you. This version should at least not explode.



[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gnus-search-topics.diff --]
[-- Type: text/x-patch, Size: 1022 bytes --]

diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el
index c8b97c0852..ec3a49344e 100644
--- a/lisp/gnus/gnus-group.el
+++ b/lisp/gnus/gnus-group.el
@@ -3194,8 +3194,10 @@ gnus-group-make-search-group
 		  (or gnus-group-marked
 		      (if (gnus-group-group-name)
 			  (list (gnus-group-group-name))
-			(cdr
-			 (assoc (gnus-group-topic-name) gnus-topic-alist))))))))
+			(mapcar #'caadr
+				(gnus-topic-find-groups
+				 (gnus-group-topic-name)
+				 nil 'all nil t))))))))
 	     (query-spec
 	      (or
 	       (cdr (assq 'search-query-spec specs))
@@ -3243,8 +3245,10 @@ gnus-group-read-ephemeral-search-group
 		 (or gnus-group-marked
 		     (if (gnus-group-group-name)
 			 (list (gnus-group-group-name))
-		       (cdr
-			(assoc (gnus-group-topic-name) gnus-topic-alist))))))))
+		       (mapcar #'caadr
+				(gnus-topic-find-groups
+				 (gnus-group-topic-name)
+				 nil 'all nil t))))))))
 	 (query-spec
 	  (or (cdr (assq 'search-query-spec specs))
 	      (cdr (assq 'nnir-query-spec specs))