From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24842 invoked from network); 13 Nov 2020 06:40:02 -0000 Received: from mx1.math.uh.edu (129.7.128.32) by inbox.vuxu.org with ESMTPUTF8; 13 Nov 2020 06:40:02 -0000 Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kdSjD-003Epd-La; Fri, 13 Nov 2020 00:38:35 -0600 Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.94) (envelope-from ) id 1kdSjC-00AjcX-M8; Fri, 13 Nov 2020 00:38:34 -0600 Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kdSj7-00Ajar-Ut for ding@lists.math.uh.edu; Fri, 13 Nov 2020 00:38:29 -0600 Received: from quimby.gnus.org ([95.216.78.240]) by mx2.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1kdSj6-009q79-3r for ding@lists.math.uh.edu; Fri, 13 Nov 2020 00:38:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yoQWXOhVnp1ypOM53DXeXLqZ3Ws+htnUouf+oippZhE=; b=f1F1bdr2JrA6dq7vgsaQJpKgPH 13+TZ8iA4aFDFUrRj75IxGLJDkyhGwmLvhG7PuUn71vkGgYAj/70PwnED4SC7UuXpPSR77eYoEIbl yjITnWRkGXvEm6S0hJc2Ibk9Qkg7SACmIa+hA+V46af1yNuFNop1xA7s83voSFmERUOs=; Received: from ericabrahamsen.net ([52.70.2.18] helo=mail.ericabrahamsen.net) by quimby.gnus.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kdSix-00006O-2i for ding@gnus.org; Fri, 13 Nov 2020 07:38:23 +0100 Received: from localhost (24-113-150-48.wavecable.com [24.113.150.48]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id 0CBFFFA18E; Fri, 13 Nov 2020 06:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1605249496; bh=yoQWXOhVnp1ypOM53DXeXLqZ3Ws+htnUouf+oippZhE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nwpjpGAveqjL7sT40HLCgMxCzBBQFob59mhrmMDYnHF7eErYIN2p3gCSqCkflQIIZ twcXZ7i/qVTSMFHNsDxFW3Qyd3VlID1rgbxmLUtiNHxFAmTGQFPdfbtL1SBv9YA0Uj WmdOyqFJa9SaWZUq+ginUfRNq85Lo4WVjYpA6D+0= From: Eric Abrahamsen To: "Jose A. Ortega Ruiz" Cc: Subject: Re: New "gnus-search" syntax and interface References: <87blgdavsb.fsf@ericabrahamsen.net> <87y2jfvw9t.fsf@gnus.jao.io> <871rh569u1.fsf@ericabrahamsen.net> <87zh3s7em0.fsf@gnus.jao.io> <87zh3sa19i.fsf@ericabrahamsen.net> <877dqw71y8.fsf@gnus.jao.io> <878sb6qox3.fsf@ericabrahamsen.net> <87imaadjy1.fsf@gnus.jao.io> Date: Thu, 12 Nov 2020 22:38:14 -0800 In-Reply-To: <87imaadjy1.fsf@gnus.jao.io> (Jose A. Ortega Ruiz's message of "Fri, 13 Nov 2020 03:17:26 +0000") Message-ID: <87k0uphicp.fsf@ericabrahamsen.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" List-ID: Precedence: bulk --=-=-= Content-Type: text/plain "Jose A. Ortega Ruiz" writes: > On Thu, Nov 12 2020, Eric Abrahamsen wrote: > >> On 11/08/20 07:16 AM, Jose A. Ortega Ruiz wrote: >>> On Sat, Nov 07 2020, Eric Abrahamsen wrote: >>> >>>>> Hmmm, are nested topics supported? That is, if i search on a topic that >>>>> contains subtopics, is the search including groups inside those >>>>> subtopics? >>>> >>>> That's it! Nested topics are not supported. I'll put this on the list >>>> and get it fixed in the next couple days. >>> >>> Excellent. Count on me to give it a test drive! >> >> Okay here goes -- the attached patch should make topic searching work as >> expected. Would you give it a try? > > hmmm, no. with this patch applied, GG on a topic raises: > > gnus-topic-find-groups("inbox" nil all nil recursive) > gnus-group-read-ephemeral-search-group(nil) > funcall-interactively(gnus-group-read-ephemeral-search-group nil) > call-interactively(gnus-group-read-ephemeral-search-group nil nil) > command-execute(gnus-group-read-ephemeral-search-group) Bah, it's always the last minute little "inconsequential" changes that get you. This version should at least not explode. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=gnus-search-topics.diff diff --git a/lisp/gnus/gnus-group.el b/lisp/gnus/gnus-group.el index c8b97c0852..ec3a49344e 100644 --- a/lisp/gnus/gnus-group.el +++ b/lisp/gnus/gnus-group.el @@ -3194,8 +3194,10 @@ gnus-group-make-search-group (or gnus-group-marked (if (gnus-group-group-name) (list (gnus-group-group-name)) - (cdr - (assoc (gnus-group-topic-name) gnus-topic-alist)))))))) + (mapcar #'caadr + (gnus-topic-find-groups + (gnus-group-topic-name) + nil 'all nil t)))))))) (query-spec (or (cdr (assq 'search-query-spec specs)) @@ -3243,8 +3245,10 @@ gnus-group-read-ephemeral-search-group (or gnus-group-marked (if (gnus-group-group-name) (list (gnus-group-group-name)) - (cdr - (assoc (gnus-group-topic-name) gnus-topic-alist)))))))) + (mapcar #'caadr + (gnus-topic-find-groups + (gnus-group-topic-name) + nil 'all nil t)))))))) (query-spec (or (cdr (assq 'search-query-spec specs)) (cdr (assq 'nnir-query-spec specs)) --=-=-=--