From: Eric Abrahamsen <eric@ericabrahamsen.net>
To: "Adam Sjøgren" <asjo@koldfront.dk>
Cc: ding@gnus.org
Subject: Re: New "gnus-search" syntax and interface
Date: Thu, 05 Nov 2020 08:14:20 -0800 [thread overview]
Message-ID: <87k0uz93xf.fsf@ericabrahamsen.net> (raw)
In-Reply-To: <87o8kb94e1.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of "Thu, 05 Nov 2020 08:04:22 -0800")
Eric Abrahamsen <eric@ericabrahamsen.net> writes:
> Adam Sjøgren <asjo@koldfront.dk> writes:
>
>> Eric writes:
>>
>>> Past that, the fun stuff comes if you set
>>> `gnus-search-use-parsed-queries' to t. That will enable the "generalized
>>> query syntax", a single search syntax that can be used across any
>>> supported search engine.
>>
>> I did that, placed point on nnml:normal and pressed G G as I usually do.
>> Entered at string to search for at the Query: prompt, and instead of the
>> expected results returned from notmuch, I got:
>>
>> No search engine defined for nnml:
>> cl-no-applicable-method: No applicable method: gnus-search-run-search,
>> nil, "nnml:", ((parsed-query "Leaf") (query . "Leaf") (raw)),
>> ("nnml:normal")
>>
>> My mail method is defined like this:
>>
>> (setq asjo-local-mail-method '(nnml ""
>> (nnir-search-engine notmuch)))
>>
>> [...]
>>
>> (setq gnus-secondary-select-methods
>> `(
>> ,asjo-local-mail-method
>> [...]
>>
>> (My archive method is also nnml - nnml:archive, and also has
>> (nnir-search-engine notmuch).)
>>
>> I get the same error if I switch gnus-search-use-parsed-queries to nil.
>>
>> Do I need to tell Gnus that I want to use notmuch in a new way?
>
> Apparently I borked the backward compatibility. The new way to define
> the search engine (in your case) would be
>
> (gnus-search-engine gnus-search-notmuch)
>
> but old `nnir-search-engine' way should definitely be supported. Would
> you please eval the below and confirm that it works correctly?
>
> Thanks!
>
> (defun gnus-search-server-to-engine (srv)
> (let* ((method (gnus-server-to-method srv))
> (server
> (or (assoc 'gnus-search-engine (cddr method))
> (assoc (car method) gnus-search-default-engines)
> (when-let ((old (assoc 'nnir-search-engine
> (cddr method))))
> (nnheader-message
> 8 "\"nnir-search-engine\" is no longer a valid parameter")
> (pcase (nth 1 old)
> ('notmuch 'gnus-search-notmuch)
> ('namazu 'gnus-search-namazu)
> ('find-grep 'gnus-search-find-grep)))))
> (inst
> (cond
> ((null server) nil)
> ((eieio-object-p (cadr server))
> (cadr server))
> ((class-p (cadr server))
> (make-instance (cadr server)))
> (t nil))))
> (if inst
> (when (cddr server)
> (pcase-dolist (`(,key ,value) (cddr server))
> (condition-case nil
> (setf (slot-value inst key) value)
> ((invalid-slot-name invalid-slot-type)
> (nnheader-message
> 5 "Invalid search engine parameter: (%s %s)"
> key value)))))
> (nnheader-message 5 "No search engine defined for %s" srv))
> inst))
This is wrong too, let me just take a deep breath and do this right...
next prev parent reply other threads:[~2020-11-05 16:15 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 17:15 Eric Abrahamsen
2020-11-04 18:14 ` Pankaj Jangid
2020-11-04 18:45 ` Eric Abrahamsen
2020-11-04 19:32 ` Pankaj Jangid
2020-11-04 19:39 ` Pankaj Jangid
2020-11-04 19:49 ` Eric Abrahamsen
2020-11-05 2:19 ` Eric Abrahamsen
2020-11-05 11:58 ` Adam Sjøgren
2020-11-05 16:04 ` Eric Abrahamsen
2020-11-05 16:14 ` Eric Abrahamsen [this message]
2020-11-05 16:41 ` Adam Sjøgren
2020-11-05 17:18 ` Eric Abrahamsen
2020-11-05 17:34 ` Adam Sjøgren
2020-11-06 3:50 ` Eric Abrahamsen
2020-11-06 6:23 ` Jose A. Ortega Ruiz
[not found] ` <12MvvhYMQyipeZzkJx1ODwHAD4xQZo6qw1FSX6nvgZAyLZCPkEVFXXGxOQTuxL1zvwZC6BER4jnUFXNgIEjIZA==@protonmail.internalid>
2020-11-07 4:59 ` Eric Abrahamsen
2020-11-08 1:23 ` Jose A. Ortega Ruiz
[not found] ` <VEKLrJRKnbVIVztgsX0O5q0i9OwitXf-t5q2hcVN-ZDq0SRE1KS4DIpk7iNeQxIhD1_9AC4DWOdDJsJW2XCMlg==@protonmail.internalid>
2020-11-08 2:38 ` Eric Abrahamsen
2020-11-08 2:51 ` Jose A. Ortega Ruiz
2020-11-08 2:55 ` Andrew Cohen
2020-11-08 2:43 ` Jose A. Ortega Ruiz
2020-11-08 5:03 ` Eric Abrahamsen
2020-11-08 7:16 ` Jose A. Ortega Ruiz
2020-11-12 20:51 ` Eric Abrahamsen
2020-11-13 3:17 ` Jose A. Ortega Ruiz
[not found] ` <-NlYHnQ3eprZs5vpzJzwiWpUHjyOUwbkarR4R4m8DK_5ik1XoE8SVsxNfQWJwgUWVIfjwxU5eCbwaWIzwZUJNQ==@protonmail.internalid>
2020-11-13 6:38 ` Eric Abrahamsen
2020-11-13 19:15 ` Jose A. Ortega Ruiz
2020-11-14 1:02 ` Eric Abrahamsen
2020-11-13 11:07 ` Eric S Fraga
2020-11-13 12:39 ` Gijs Hillenius
2020-11-13 13:01 ` Eric S Fraga
2020-11-13 16:15 ` Eric Abrahamsen
2020-11-13 16:56 ` Eric S Fraga
2020-11-13 17:21 ` Eric Abrahamsen
2020-11-13 20:06 ` Jose A. Ortega Ruiz
2020-11-16 10:44 ` Eric S Fraga
2020-11-16 15:00 ` Eric S Fraga
2020-11-16 18:47 ` Eric Abrahamsen
2020-11-17 11:04 ` Eric S Fraga
2020-11-17 23:58 ` Eric Abrahamsen
2020-11-18 0:46 ` Jose A. Ortega Ruiz
2020-11-18 20:40 ` Eric Abrahamsen
[not found] ` <1x7NOCTHudFuCvB0kEBCGDds7KKAdbu-tZRD41ue36qG8dPBUSj7W9lq7CK5WJwL50cGQKZcom2KMkW_2VZi8Q==@protonmail.internalid>
[not found] ` <871rgqz98k.fsf@ericabrahamsen.net>
2020-11-18 21:05 ` Jose A. Ortega Ruiz
2020-11-18 21:31 ` Eric Abrahamsen
2020-11-18 9:21 ` yoctocell
2020-11-18 20:53 ` Eric Abrahamsen
2020-11-19 11:02 ` yoctocell
2020-11-22 12:56 ` yoctocell
2020-11-22 16:31 ` Eric Abrahamsen
[not found] ` <86lfel9z1b.fsf@yoctocell.xyz>
2020-11-30 4:40 ` Eric Abrahamsen
2020-11-30 8:17 ` yoctocell
2020-11-30 17:30 ` Eric Abrahamsen
2020-12-01 7:47 ` yoctocell
2020-12-02 2:16 ` Eric Abrahamsen
2020-12-02 7:17 ` yoctocell
2020-12-11 1:39 ` Eric Abrahamsen
2020-12-11 7:55 ` yoctocell
2020-12-13 10:18 ` yoctocell
2020-12-13 11:23 ` yoctocell
2020-12-13 16:49 ` Eric Abrahamsen
2020-12-13 21:13 ` yoctocell
2020-12-18 4:30 ` Eric Abrahamsen
2020-12-18 8:21 ` yoctocell
2020-12-22 17:05 ` Eric Abrahamsen
2020-12-22 18:10 ` yoctocell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0uz93xf.fsf@ericabrahamsen.net \
--to=eric@ericabrahamsen.net \
--cc=asjo@koldfront.dk \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).